mirror of
https://github.com/n8n-io/n8n.git
synced 2025-03-05 20:50:17 -08:00
test(core): Fix a typo and add an additional test (#12725)
This commit is contained in:
parent
967ee4b89b
commit
d25817c5cc
|
@ -123,6 +123,7 @@ describe('cleanRunData', () => {
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// ►
|
||||||
// ┌─────┐ ┌────────┐
|
// ┌─────┐ ┌────────┐
|
||||||
// │node1├─────►rootNode│
|
// │node1├─────►rootNode│
|
||||||
// └─────┘ └───▲────┘
|
// └─────┘ └───▲────┘
|
||||||
|
@ -156,6 +157,7 @@ describe('cleanRunData', () => {
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// ►
|
||||||
// ┌─────┐ ┌─────┐ ┌────────┐
|
// ┌─────┐ ┌─────┐ ┌────────┐
|
||||||
// │node1├───►node2├────►rootNode│
|
// │node1├───►node2├────►rootNode│
|
||||||
// └─────┘ └─────┘ └───▲────┘
|
// └─────┘ └─────┘ └───▲────┘
|
||||||
|
@ -191,4 +193,42 @@ describe('cleanRunData', () => {
|
||||||
[node1.name]: [toITaskData([{ data: { value: 1 } }])],
|
[node1.name]: [toITaskData([{ data: { value: 1 } }])],
|
||||||
});
|
});
|
||||||
});
|
});
|
||||||
|
|
||||||
|
// ►
|
||||||
|
// ┌─────┐ ┌────────┐ ┌────────┐
|
||||||
|
// │node1├──►rootNode├──►rootNode│
|
||||||
|
// └─────┘ └───▲────┘ └───▲────┘
|
||||||
|
// │ │
|
||||||
|
// │ ┌───┴───┐
|
||||||
|
// └───────┤subNode│
|
||||||
|
// └───────┘
|
||||||
|
test('removes run data of sub nodes as well if the sub node is shared between multiple root nodes', () => {
|
||||||
|
// ARRANGE
|
||||||
|
const node1 = createNodeData({ name: 'Node1' });
|
||||||
|
const rootNode1 = createNodeData({ name: 'Root Node 1' });
|
||||||
|
const rootNode2 = createNodeData({ name: 'Root Node 2' });
|
||||||
|
const subNode = createNodeData({ name: 'Sub Node' });
|
||||||
|
const graph = new DirectedGraph()
|
||||||
|
.addNodes(node1, rootNode1, rootNode2, subNode)
|
||||||
|
.addConnections(
|
||||||
|
{ from: node1, to: rootNode1 },
|
||||||
|
{ from: rootNode1, to: rootNode2 },
|
||||||
|
{ from: subNode, to: rootNode1, type: NodeConnectionType.AiLanguageModel },
|
||||||
|
{ from: subNode, to: rootNode2, type: NodeConnectionType.AiLanguageModel },
|
||||||
|
);
|
||||||
|
const runData: IRunData = {
|
||||||
|
[node1.name]: [toITaskData([{ data: { value: 1 } }])],
|
||||||
|
[rootNode1.name]: [toITaskData([{ data: { value: 1 } }])],
|
||||||
|
[rootNode2.name]: [toITaskData([{ data: { value: 2 } }])],
|
||||||
|
[subNode.name]: [toITaskData([{ data: { value: 3 } }])],
|
||||||
|
};
|
||||||
|
|
||||||
|
// ACT
|
||||||
|
const newRunData = cleanRunData(runData, graph, new Set([rootNode1]));
|
||||||
|
|
||||||
|
// ASSERT
|
||||||
|
expect(newRunData).toEqual({
|
||||||
|
[node1.name]: [toITaskData([{ data: { value: 1 } }])],
|
||||||
|
});
|
||||||
|
});
|
||||||
});
|
});
|
||||||
|
|
|
@ -24,7 +24,7 @@ export function cleanRunData(
|
||||||
// Delete runData for subNodes
|
// Delete runData for subNodes
|
||||||
const subNodeConnections = graph.getParentConnections(node);
|
const subNodeConnections = graph.getParentConnections(node);
|
||||||
for (const subNodeConnection of subNodeConnections) {
|
for (const subNodeConnection of subNodeConnections) {
|
||||||
// Sub nodes never use the Main connection type, so this filters our
|
// Sub nodes never use the Main connection type, so this filters out
|
||||||
// the connection that goes upstream of the startNode.
|
// the connection that goes upstream of the startNode.
|
||||||
if (subNodeConnection.type === NodeConnectionType.Main) {
|
if (subNodeConnection.type === NodeConnectionType.Main) {
|
||||||
continue;
|
continue;
|
||||||
|
|
Loading…
Reference in a new issue