refactor(core): apply lint rule node-class-description-non-core-color-present (#4426)

* 👕 Enable rule `node-class-description-non-core-color-present`

* 👕 Apply rule to remove deprecated `color`

* ✏️ Fix unrelated typos

* ✏️ Fix another unrelated typo

Co-authored-by: Michael Kret <michael.k@radency.com>
This commit is contained in:
Iván Ovejero 2022-10-25 09:06:54 +02:00 committed by GitHub
parent 408bd96815
commit d2b97c0713
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
33 changed files with 7 additions and 35 deletions

View file

@ -87,6 +87,7 @@ module.exports = {
'n8n-nodes-base/node-class-description-inputs-wrong-regular-node': 'error', 'n8n-nodes-base/node-class-description-inputs-wrong-regular-node': 'error',
'n8n-nodes-base/node-class-description-inputs-wrong-trigger-node': 'error', 'n8n-nodes-base/node-class-description-inputs-wrong-trigger-node': 'error',
'n8n-nodes-base/node-class-description-missing-subtitle': 'error', 'n8n-nodes-base/node-class-description-missing-subtitle': 'error',
'n8n-nodes-base/node-class-description-non-core-color-present': 'error',
'n8n-nodes-base/node-class-description-name-unsuffixed-trigger-node': 'error', 'n8n-nodes-base/node-class-description-name-unsuffixed-trigger-node': 'error',
'n8n-nodes-base/node-class-description-outputs-wrong': 'error', 'n8n-nodes-base/node-class-description-outputs-wrong': 'error',
'n8n-nodes-base/node-dirname-against-convention': 'error', 'n8n-nodes-base/node-dirname-against-convention': 'error',

View file

@ -21,7 +21,6 @@ export class Adalo implements INodeType {
description: 'Consume Adalo API', description: 'Consume Adalo API',
defaults: { defaults: {
name: 'Adalo', name: 'Adalo',
color: '#4f44d7',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -17,7 +17,6 @@ export class AwsCertificateManager implements INodeType {
description: 'Sends data to AWS Certificate Manager', description: 'Sends data to AWS Certificate Manager',
defaults: { defaults: {
name: 'AWS Certificate Manager', name: 'AWS Certificate Manager',
color: '#7d9a4b',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -30,7 +30,6 @@ export class AwsElb implements INodeType {
description: 'Sends data to AWS ELB API', description: 'Sends data to AWS ELB API',
defaults: { defaults: {
name: 'AWS ELB', name: 'AWS ELB',
color: '#FF9900',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -21,7 +21,6 @@ export class CalTrigger implements INodeType {
description: 'Handle Cal events via webhooks', description: 'Handle Cal events via webhooks',
defaults: { defaults: {
name: 'Cal Trigger', name: 'Cal Trigger',
color: '#888',
}, },
inputs: [], inputs: [],
outputs: ['main'], outputs: ['main'],

View file

@ -24,7 +24,6 @@ export class Cloudflare implements INodeType {
description: 'Consume Cloudflare API', description: 'Consume Cloudflare API',
defaults: { defaults: {
name: 'Cloudflare', name: 'Cloudflare',
color: '#000000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -13,7 +13,6 @@ export class GoogleAds implements INodeType {
description: 'Use the Google Ads API', description: 'Use the Google Ads API',
defaults: { defaults: {
name: 'Google Ads', name: 'Google Ads',
color: '#ff0000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -48,7 +48,6 @@ export class GoogleChat implements INodeType {
description: 'Consume Google Chat API', description: 'Consume Google Chat API',
defaults: { defaults: {
name: 'Google Chat', name: 'Google Chat',
color: '#0aa55c',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -14,7 +14,6 @@ export class GoogleCloudStorage implements INodeType {
description: 'Use the Google Cloud Storage API', description: 'Use the Google Cloud Storage API',
defaults: { defaults: {
name: 'Google Cloud Storage', name: 'Google Cloud Storage',
color: '#ff0000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -45,7 +45,6 @@ export class HaloPSA implements INodeType {
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
defaults: { defaults: {
name: 'HaloPSA', name: 'HaloPSA',
color: '#fd314e',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -46,7 +46,6 @@ export class HighLevel implements INodeType {
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
defaults: { defaults: {
name: 'HighLevel', name: 'HighLevel',
color: '#f1be40',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -32,7 +32,6 @@ export class Jenkins implements INodeType {
description: 'Consume Jenkins API', description: 'Consume Jenkins API',
defaults: { defaults: {
name: 'Jenkins', name: 'Jenkins',
color: '#04AA51',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -36,7 +36,6 @@ export class KoBoToolbox implements INodeType {
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
defaults: { defaults: {
name: 'KoBoToolbox', name: 'KoBoToolbox',
color: '#64C0FF',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -27,7 +27,6 @@ export class KoBoToolboxTrigger implements INodeType {
description: 'Process KoBoToolbox submissions', description: 'Process KoBoToolbox submissions',
defaults: { defaults: {
name: 'KoBoToolbox Trigger', name: 'KoBoToolbox Trigger',
color: '#64C0FF',
}, },
inputs: [], inputs: [],
outputs: ['main'], outputs: ['main'],

View file

@ -21,7 +21,6 @@ export class LinearTrigger implements INodeType {
description: 'Starts the workflow when Linear events occur', description: 'Starts the workflow when Linear events occur',
defaults: { defaults: {
name: 'Linear Trigger', name: 'Linear Trigger',
color: '#D9DCF8',
}, },
inputs: [], inputs: [],
outputs: ['main'], outputs: ['main'],

View file

@ -27,7 +27,6 @@ export class Markdown implements INodeType {
description: 'Convert data between Markdown and HTML', description: 'Convert data between Markdown and HTML',
defaults: { defaults: {
name: 'Markdown', name: 'Markdown',
color: '#000000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -39,7 +39,6 @@ export class Mautic implements INodeType {
description: 'Consume Mautic API', description: 'Consume Mautic API',
defaults: { defaults: {
name: 'Mautic', name: 'Mautic',
color: '#52619b',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -19,7 +19,6 @@ export class Metabase implements INodeType {
description: 'Use the Metabase API', description: 'Use the Metabase API',
defaults: { defaults: {
name: 'Metabase', name: 'Metabase',
color: '#ff0000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -26,7 +26,6 @@ export class MicrosoftGraphSecurity implements INodeType {
description: 'Consume the Microsoft Graph Security API', description: 'Consume the Microsoft Graph Security API',
defaults: { defaults: {
name: 'Microsoft Graph Security', name: 'Microsoft Graph Security',
color: '#0078d4',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -21,7 +21,6 @@ export const versionDescription: INodeTypeDescription = {
description: 'Consume Notion API (Beta)', description: 'Consume Notion API (Beta)',
defaults: { defaults: {
name: 'Notion', name: 'Notion',
color: '#000000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -21,7 +21,6 @@ export const versionDescription: INodeTypeDescription = {
description: 'Consume Notion API (Beta)', description: 'Consume Notion API (Beta)',
defaults: { defaults: {
name: 'Notion', name: 'Notion',
color: '#000000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -52,7 +52,6 @@ export class Odoo implements INodeType {
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
defaults: { defaults: {
name: 'Odoo', name: 'Odoo',
color: '#714B67',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -48,7 +48,6 @@ export class Onfleet implements INodeType {
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}', subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
description: 'Consume Onfleet API', description: 'Consume Onfleet API',
defaults: { defaults: {
color: '#AA81F3',
name: 'Onfleet', name: 'Onfleet',
}, },
inputs: ['main'], inputs: ['main'],

View file

@ -25,7 +25,6 @@ export class OnfleetTrigger implements INodeType {
description: 'Starts the workflow when Onfleet events occur', description: 'Starts the workflow when Onfleet events occur',
defaults: { defaults: {
name: 'Onfleet Trigger', name: 'Onfleet Trigger',
color: '#AA81F3',
}, },
inputs: [], inputs: [],
outputs: ['main'], outputs: ['main'],

View file

@ -15,7 +15,6 @@ export class PostBin implements INodeType {
description: 'Consume PostBin API', description: 'Consume PostBin API',
defaults: { defaults: {
name: 'PostBin', name: 'PostBin',
color: '#4dc0b5',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -16,7 +16,6 @@ export class SendInBlue implements INodeType {
description: 'Consume Sendinblue API', description: 'Consume Sendinblue API',
defaults: { defaults: {
name: 'SendInBlue', name: 'SendInBlue',
color: '#044a75',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -21,7 +21,6 @@ export class SendInBlueTrigger implements INodeType {
displayName: 'SendInBlue Trigger', displayName: 'SendInBlue Trigger',
defaults: { defaults: {
name: 'SendInBlue-Trigger', name: 'SendInBlue-Trigger',
color: '#044a75',
}, },
description: 'Starts the workflow when SendInBlue events occur', description: 'Starts the workflow when SendInBlue events occur',
group: ['trigger'], group: ['trigger'],

View file

@ -40,7 +40,6 @@ export class Supabase implements INodeType {
description: 'Add, get, delete and update data in a table', description: 'Add, get, delete and update data in a table',
defaults: { defaults: {
name: 'Supabase', name: 'Supabase',
color: '#ea5929',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -17,7 +17,6 @@ export const versionDescription: INodeTypeDescription = {
description: 'Gets data from SyncroMSP', description: 'Gets data from SyncroMSP',
defaults: { defaults: {
name: 'SyncroMSP', name: 'SyncroMSP',
color: '#08a4ab',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -19,7 +19,6 @@ export class VenafiTlsProtectDatacenter implements INodeType {
description: 'Consume Venafi TLS Protect Datacenter', description: 'Consume Venafi TLS Protect Datacenter',
defaults: { defaults: {
name: 'Venafi TLS Protect Datacenter', name: 'Venafi TLS Protect Datacenter',
color: '#000000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -14,10 +14,9 @@ export class VenafiTlsProtectDatacenterTrigger implements INodeType {
group: ['trigger'], group: ['trigger'],
version: 1, version: 1,
subtitle: '={{$parameter["triggerOn"]}}', subtitle: '={{$parameter["triggerOn"]}}',
description: 'Starts the workflow when Venafi events occure', description: 'Starts the workflow when Venafi events occur',
defaults: { defaults: {
name: 'Venafi TLS Protect Datacenter', name: 'Venafi TLS Protect Datacenter',
color: '#000000',
}, },
credentials: [ credentials: [
{ {

View file

@ -37,7 +37,6 @@ export class VenafiTlsProtectCloud implements INodeType {
description: 'Consume Venafi TLS Protect Cloud API', description: 'Consume Venafi TLS Protect Cloud API',
defaults: { defaults: {
name: 'Venafi TLS Protect Cloud', name: 'Venafi TLS Protect Cloud',
color: '#000000',
}, },
inputs: ['main'], inputs: ['main'],
outputs: ['main'], outputs: ['main'],

View file

@ -17,10 +17,9 @@ export class VenafiTlsProtectCloudTrigger implements INodeType {
icon: 'file:../venafi.svg', icon: 'file:../venafi.svg',
group: ['trigger'], group: ['trigger'],
version: 1, version: 1,
description: 'Starts the workflow when Venafi events occure', description: 'Starts the workflow when Venafi events occur',
defaults: { defaults: {
name: 'Venafi TLS Protect Cloud Trigger', name: 'Venafi TLS Protect Cloud Trigger',
color: '#000000',
}, },
credentials: [ credentials: [
{ {
@ -87,7 +86,10 @@ export class VenafiTlsProtectCloudTrigger implements INodeType {
const activity = activitytypes.find(({ key }: { key: string }) => key === resource) as { const activity = activitytypes.find(({ key }: { key: string }) => key === resource) as {
values: [{ key: string; readableName: string }]; values: [{ key: string; readableName: string }];
}; };
const subActivities = activity.values.map(({ key, readableName }) => ({ name: readableName, value: key })); const subActivities = activity.values.map(({ key, readableName }) => ({
name: readableName,
value: key,
}));
subActivities.unshift({ name: '[All]', value: '*' }); subActivities.unshift({ name: '[All]', value: '*' });
return subActivities; return subActivities;
}, },