mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(RSS Feed Trigger Node): Fix regression on missing timestamps (#10991)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2024-09-27 11:56:04 +02:00 committed by GitHub
parent fe7d060568
commit d2bc0760e2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 18 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
packages/nodes-base/nodes/RssFeedRead/RssFeedReadTrigger.node.ts
View file

@ -78,14 +78,15 @@ export class RssFeedReadTrigger implements INodeType {
return [this.helpers.returnJsonArray(feed.items[0])]; return [this.helpers.returnJsonArray(feed.items[0])];
} }
feed.items.forEach((item) => { feed.items.forEach((item) => {
if (Date.parse(item.isoDate as string) > dateToCheck) { if (item.isoDate && Date.parse(item.isoDate) > dateToCheck) {
returnData.push(item); returnData.push(item);
} }
}); });
if (feed.items.length) { if (feed.items.length) {
const maxIsoDate = Math.max(...feed.items.map(({ isoDate }) => Date.parse(isoDate!))); pollData.lastItemDate = feed.items.reduce((a, b) =>
pollData.lastItemDate = new Date(maxIsoDate).toISOString(); new Date(a.isoDate!) > new Date(b.isoDate!) ? a : b,
).isoDate;
} }
} }

14
packages/nodes-base/nodes/RssFeedRead/test/RssFeedRead.test.ts
View file

@ -46,6 +46,20 @@ describe('RssFeedReadTrigger', () => {
expect(pollData.lastItemDate).toEqual(newItemDate); expect(pollData.lastItemDate).toEqual(newItemDate);
}); });
it('should gracefully handle missing timestamps', async () => {
const pollData = mock();
pollFunctions.getNodeParameter.mockReturnValue(feedUrl);
pollFunctions.getWorkflowStaticData.mockReturnValue(pollData);
(Parser.prototype.parseURL as jest.Mock).mockResolvedValue({ items: [{}, {}] });
const result = await node.poll.call(pollFunctions);
expect(result).toEqual(null);
expect(pollFunctions.getWorkflowStaticData).toHaveBeenCalledWith('node');
expect(pollFunctions.getNodeParameter).toHaveBeenCalledWith('feedUrl');
expect(Parser.prototype.parseURL).toHaveBeenCalledWith(feedUrl);
});
it('should return null if the feed is empty', async () => { it('should return null if the feed is empty', async () => {
const pollData = mock({ lastItemDate }); const pollData = mock({ lastItemDate });
pollFunctions.getNodeParameter.mockReturnValue(feedUrl); pollFunctions.getNodeParameter.mockReturnValue(feedUrl);