mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 12:44:07 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Report when waitTill is invalid and handle it (#8356)

Browse source
This commit is contained in:
Omar Ajoue 2024-01-17 12:08:20 +00:00 committed by GitHub
parent 48a0f91c72
commit d5455d7acc
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 15 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
packages/cli/src/WaitTracker.ts
View file

@ -53,6 +53,21 @@ export class WaitTracker {
for (const execution of executions) { for (const execution of executions) {
const executionId = execution.id; const executionId = execution.id;
if (this.waitingExecutions[executionId] === undefined) { if (this.waitingExecutions[executionId] === undefined) {
if (!(execution.waitTill instanceof Date)) {
// n8n expects waitTill to be a date object
// but for some reason it's not being converted
// we are handling this like this since it seems to address the issue
// for some users, as reported by Jon when using a custom image.
// Once we figure out why this it not a Date object, we can remove this.
ErrorReporter.error('Wait Till is not a date object', {
extra: {
variableType: typeof execution.waitTill,
},
});
if (typeof execution.waitTill === 'string') {
execution.waitTill = new Date(execution.waitTill);
}
}
const triggerTime = execution.waitTill!.getTime() - new Date().getTime(); const triggerTime = execution.waitTill!.getTime() - new Date().getTime();
this.waitingExecutions[executionId] = { this.waitingExecutions[executionId] = {
executionId, executionId,