From d5a6e6c3c29a1c75e7c519620cdd22a585f75462 Mon Sep 17 00:00:00 2001 From: Charlie Kolb Date: Mon, 11 Nov 2024 09:42:41 +0100 Subject: [PATCH] self review --- cypress/e2e/30-langchain.cy.ts | 7 ++----- packages/editor-ui/src/components/OutputPanel.vue | 6 +----- packages/editor-ui/src/plugins/i18n/locales/en.json | 3 +-- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/cypress/e2e/30-langchain.cy.ts b/cypress/e2e/30-langchain.cy.ts index a7a0175984..453d5c9b7f 100644 --- a/cypress/e2e/30-langchain.cy.ts +++ b/cypress/e2e/30-langchain.cy.ts @@ -459,7 +459,7 @@ describe('Langchain Integration', () => { getNoToolsUsedCallout().should('exist'); }); - it('should not show tool info notice if tools were used during execution', () => { + it.only('should not show tool info notice if tools were used during execution', () => { addNodeToCanvas(MANUAL_CHAT_TRIGGER_NODE_NAME, true); addNodeToCanvas(AGENT_NODE_NAME, true); @@ -492,10 +492,7 @@ describe('Langchain Integration', () => { main: { output: outputMessage }, }, metadata: { - subRun: [ - { node: AI_LANGUAGE_MODEL_OPENAI_CHAT_MODEL_NODE_NAME, runIndex: 0 }, - { node: AI_TOOL_CALCULATOR_NODE_NAME, runIndex: 0 }, - ], + subRun: [{ node: AI_LANGUAGE_MODEL_OPENAI_CHAT_MODEL_NODE_NAME, runIndex: 0 }], }, }), createMockNodeExecutionData(AI_TOOL_CALCULATOR_NODE_NAME, {}), diff --git a/packages/editor-ui/src/components/OutputPanel.vue b/packages/editor-ui/src/components/OutputPanel.vue index 81aedaecd9..2091d52e15 100644 --- a/packages/editor-ui/src/components/OutputPanel.vue +++ b/packages/editor-ui/src/components/OutputPanel.vue @@ -387,11 +387,7 @@ const shouldShowWarning = computed(() => { diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json index cc77c502b6..f1d5b0de44 100644 --- a/packages/editor-ui/src/plugins/i18n/locales/en.json +++ b/packages/editor-ui/src/plugins/i18n/locales/en.json @@ -978,8 +978,7 @@ "ndv.output.tooMuchData.showDataAnyway": "Show data", "ndv.output.tooMuchData.title": "Display data?", "ndv.output.waitingToRun": "Waiting to execute...", - "ndv.output.noToolUsedInfo.title": "None of your tools were used in this run", - "ndv.output.noToolUsedInfo.description": "Try giving your tools clearer names and descriptions to help the AI", + "ndv.output.noToolUsedInfo": "None of your tools were used in this run. Try giving your tools clearer names and descriptions to help the AI", "ndv.title.cancel": "Cancel", "ndv.title.rename": "Rename", "ndv.title.renameNode": "Rename node",