mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Date & Time Node): Dont parse date if it's not set (null or undefined) (#7050)

Browse source 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/date-time-node-transforming-null-to-19700101/29339

null/undefined input was converted to 01/01/1970 instead of being passed
through as-is
This commit is contained in:
Elias Meire 2023-08-31 12:33:26 +02:00 committed by GitHub
parent d3f635657c
commit d72f79ffb3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 108 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
packages/nodes-base/nodes/DateTime/V2/DateTimeV2.node.ts
View file

@ -134,18 +134,24 @@ export class DateTimeV2 implements INodeType {
const outputFieldName = this.getNodeParameter('outputFieldName', i) as string;
const { timezone } = this.getNodeParameter('options', i) as { timezone: boolean };
const dateLuxon = timezone
? parseDate.call(this, date, workflowTimezone)
: parseDate.call(this, date);
if (format === 'custom') {
const customFormat = this.getNodeParameter('customFormat', i) as string;
if (date === null || date === undefined) {
responseData.push({
[outputFieldName]: dateLuxon.toFormat(customFormat),
[outputFieldName]: date,
});
} else {
responseData.push({
[outputFieldName]: dateLuxon.toFormat(format),
});
const dateLuxon = timezone
? parseDate.call(this, date, workflowTimezone)
: parseDate.call(this, date);
if (format === 'custom') {
const customFormat = this.getNodeParameter('customFormat', i) as string;
responseData.push({
[outputFieldName]: dateLuxon.toFormat(customFormat),
});
} else {
responseData.push({
[outputFieldName]: dateLuxon.toFormat(format),
});
}
}
} else if (operation === 'roundDate') {
const date = this.getNodeParameter('date', i) as string;

93
packages/nodes-base/nodes/DateTime/test/node/workflow.nullDate_v2.json Normal file
View file

@ -0,0 +1,93 @@
{
"name": "Null Date",
"nodes": [
{
"parameters": {},
"id": "62bb450c-f2e3-41c9-9894-a954d2c5e115",
"name": "When clicking \"Execute Workflow\"",
"type": "n8n-nodes-base.manualTrigger",
"typeVersion": 1,
"position": [
1600,
740
]
},
{
"parameters": {
"jsCode": "return {date: null}"
},
"id": "47e4ce5b-2365-4987-a058-ae21964d135d",
"name": "Code",
"type": "n8n-nodes-base.code",
"typeVersion": 2,
"position": [
1820,
740
]
},
{
"parameters": {
"operation": "formatDate",
"date": "={{ $json.date }}",
"options": {}
},
"id": "9af21b91-9db6-40cd-98ee-ee969eb0a348",
"name": "Date & Time",
"type": "n8n-nodes-base.dateTime",
"typeVersion": 2,
"position": [
2040,
740
]
}
],
"pinData": {
"Date & Time": [
{
"json": {
"formattedDate": null
}
}
],
"Code": [
{
"json": {
"date": null
}
}
]
},
"connections": {
"When clicking \"Execute Workflow\"": {
"main": [
[
{
"node": "Code",
"type": "main",
"index": 0
}
]
]
},
"Code": {
"main": [
[
{
"node": "Date & Time",
"type": "main",
"index": 0
}
]
]
}
},
"active": false,
"settings": {
"executionOrder": "v1"
},
"versionId": "",
"meta": {
"instanceId": "78577815012af39cf16dad7a787b0898c42fb7514b8a7f99b2136862c2af502c"
},
"tags": []
}