mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-13 16:14:07 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

refactor(editor): Remove tracking for SAML test success (no-changelog) (#8108)

Browse source 
Follow-up to: https://github.com/n8n-io/n8n/pull/8102

It turns out that SAML test success cannot be tracked on the FE. We
might track on the BE, but after further discussion with Product, we do
not really need to track this property, so this PR simply removes it.
This commit is contained in:
Iván Ovejero 2023-12-20 15:23:00 +01:00 committed by GitHub
parent 97aa38e783
commit d917dfe9f8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
packages/editor-ui/src/views/SettingsSso.vue
View file

@ -82,8 +82,6 @@ const getSamlConfig = async () => {
ssoSettingsSaved.value = !!config?.metadata; ssoSettingsSaved.value = !!config?.metadata;
}; };
let testSucceeded = false;
const onSave = async () => { const onSave = async () => {
try { try {
const config = const config =
@ -110,7 +108,6 @@ const onSave = async () => {
telemetry.track('User updated single sign on settings', { telemetry.track('User updated single sign on settings', {
instance_id: rootStore.instanceId, instance_id: rootStore.instanceId,
identity_provider: ipsType.value === 'url' ? 'metadata' : 'xml', identity_provider: ipsType.value === 'url' ? 'metadata' : 'xml',
is_valid: testSucceeded,
is_active: ssoStore.isSamlLoginEnabled, is_active: ssoStore.isSamlLoginEnabled,
}); });
} catch (error) { } catch (error) {
@ -128,10 +125,8 @@ const onTest = async () => {
if (typeof window !== 'undefined') { if (typeof window !== 'undefined') {
window.open(url, '_blank'); window.open(url, '_blank');
} }
testSucceeded = true;
} catch (error) { } catch (error) {
toast.showError(error, 'error'); toast.showError(error, 'error');
testSucceeded = false;
} }
}; };