refactor: Extract ISOCountryCodes into a single place (no-changelog) (#9947)

This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2024-07-04 21:18:28 +02:00 committed by GitHub
parent 908ddd8a24
commit ddfb240694
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 20 additions and 5171 deletions

View file

@ -1,6 +1,6 @@
import type { INodeProperties } from 'n8n-workflow';
import { isoCountryCodes } from '../utils/isoCountryCodes';
import { isoCountryCodes } from '@utils/ISOCountryCodes';
import { addressFixedCollection, phoneNumbersFixedCollection } from '../utils/sharedFields';

File diff suppressed because it is too large Load diff

File diff suppressed because it is too large Load diff

View file

@ -22,7 +22,7 @@ import { videoFields, videoOperations } from './VideoDescription';
import { videoCategoryFields, videoCategoryOperations } from './VideoCategoryDescription';
import { countriesCodes } from './CountryCodes';
import { isoCountryCodes } from '@utils/ISOCountryCodes';
const UPLOAD_CHUNK_SIZE = 1024 * 1024;
@ -120,7 +120,7 @@ export class YouTube implements INodeType {
// select them easily
async getCountriesCodes(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> {
const returnData: INodePropertyOptions[] = [];
for (const countryCode of countriesCodes) {
for (const countryCode of isoCountryCodes) {
const countryCodeName = `${countryCode.name} - ${countryCode.alpha2}`;
const countryCodeId = countryCode.alpha2;
returnData.push({

File diff suppressed because it is too large Load diff

View file

@ -10,7 +10,7 @@ import type {
} from 'n8n-workflow';
import { NodeOperationError } from 'n8n-workflow';
import { countriesCodes } from './CountriesCodes';
import { isoCountryCodes } from '@utils/ISOCountryCodes';
import { conversationFields, conversationOperations } from './ConversationDescription';
@ -91,7 +91,7 @@ export class HelpScout implements INodeType {
// select them easily
async getCountriesCodes(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> {
const returnData: INodePropertyOptions[] = [];
for (const countryCode of countriesCodes) {
for (const countryCode of isoCountryCodes) {
const countryCodeName = `${countryCode.name} - ${countryCode.alpha2}`;
const countryCodeId = countryCode.alpha2;
returnData.push({

View file

@ -16,7 +16,7 @@ import { invoiceFields, invoiceOperations } from './InvoiceDescription';
import type { IClient, IContact } from './ClientInterface';
import { countryCodes } from './ISOCountryCodes';
import { isoCountryCodes } from '@utils/ISOCountryCodes';
import type { IInvoice, IItem } from './invoiceInterface';
@ -210,9 +210,9 @@ export class InvoiceNinja implements INodeType {
// select them easily
async getCountryCodes(this: ILoadOptionsFunctions): Promise<INodePropertyOptions[]> {
const returnData: INodePropertyOptions[] = [];
for (let i = 0; i < countryCodes.length; i++) {
const countryName = countryCodes[i].name as string;
const countryId = countryCodes[i].numeric as string;
for (let i = 0; i < isoCountryCodes.length; i++) {
const countryName = isoCountryCodes[i].name;
const countryId = isoCountryCodes[i].numeric;
returnData.push({
name: countryName,
value: countryId,

File diff suppressed because it is too large Load diff

View file

@ -9,7 +9,7 @@ import type {
import { spotifyApiRequest, spotifyApiRequestAllItems } from './GenericFunctions';
import { isoCountryCodes } from './IsoCountryCodes';
import { isoCountryCodes } from '@utils/ISOCountryCodes';
export class Spotify implements INodeType {
description: INodeTypeDescription = {

View file

@ -1,6 +1,13 @@
import type { IDataObject } from 'n8n-workflow';
export interface ISOCountryCode {
name: string;
alpha2: string;
alpha3: string;
numeric: `${number}`;
altName?: string;
shortName?: string;
}
export const countryCodes = [
export const isoCountryCodes: ISOCountryCode[] = [
{
name: 'Afghanistan',
alpha2: 'AF',
@ -1578,4 +1585,4 @@ export const countryCodes = [
alpha3: 'ZWE',
numeric: '716',
},
] as IDataObject[];
];