mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

feat(editor): Do not show actions panel for single-action nodes (#5683)

Browse source
This commit is contained in:
OlegIvaniv 2023-03-14 16:41:49 +01:00 committed by GitHub
parent 39c871d514
commit de1db927cb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
cypress/e2e/4-node-creator.cy.ts
View file

@ -105,6 +105,31 @@ describe('Node Creator', () => {
NDVModal.getters.parameterInput('operation').should('contain.text', 'Rename'); NDVModal.getters.parameterInput('operation').should('contain.text', 'Rename');
}) })
it('should not show actions for single action nodes', () => {
const singleActionNodes = [
'DHL',
'iCalendar',
'LingvaNex',
'Mailcheck',
'MSG91',
'OpenThesaurus',
'Spontit',
'Vonage',
'Send Email',
'Toggl Trigger'
]
const doubleActionNode = 'OpenWeatherMap'
nodeCreatorFeature.actions.openNodeCreator();
singleActionNodes.forEach((node) => {
nodeCreatorFeature.getters.searchBar().find('input').clear().type(node);
nodeCreatorFeature.getters.getCreatorItem(node).find('button[class*="panelIcon"]').should('not.exist');
})
nodeCreatorFeature.getters.searchBar().find('input').clear().type(doubleActionNode);
nodeCreatorFeature.getters.getCreatorItem(doubleActionNode).click();
nodeCreatorFeature.getters.creatorItem().should('have.length', 2);
})
describe('should correctly append manual trigger for regular actions', () => { describe('should correctly append manual trigger for regular actions', () => {
// For these sources, manual node should be added // For these sources, manual node should be added
const sourcesWithAppend = [ const sourcesWithAppend = [

2
packages/editor-ui/src/stores/nodeCreator.ts
View file

@ -56,6 +56,8 @@ const customNodeActionsParsers: {
}; };
function filterActions(actions: INodeActionTypeDescription[]) { function filterActions(actions: INodeActionTypeDescription[]) {
// Do not show single action nodes
if (actions.length <= 1) return [];
return actions.filter( return actions.filter(
(action: INodeActionTypeDescription, _: number, arr: INodeActionTypeDescription[]) => { (action: INodeActionTypeDescription, _: number, arr: INodeActionTypeDescription[]) => {
const isApiCall = action.actionKey === CUSTOM_API_CALL_KEY; const isApiCall = action.actionKey === CUSTOM_API_CALL_KEY;