mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-23 11:44:06 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

test(UM tests): add missing UM tests n8n-3648 (#4077)

Browse source 
* ⚡ added test for users reinvite
This commit is contained in:
Michael Kret 2022-09-12 18:07:56 +03:00 committed by GitHub
parent 84b56eb48e
commit de4ca3b0cc
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 42 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

51
packages/cli/test/integration/users.api.test.ts
View file

@ -20,6 +20,9 @@ import * as utils from './shared/utils';
import * as testDb from './shared/testDb';
import { compareHash } from '../../src/UserManagement/UserManagementHelper';
import * as UserManagementMailer from '../../src/UserManagement/email/UserManagementMailer';
import { NodeMailer } from '../../src/UserManagement/email/NodeMailer';
jest.mock('../../src/telemetry');
jest.mock('../../src/UserManagement/email/NodeMailer');
@ -542,19 +545,45 @@ test('POST /users should ignore an empty payload', async () => {
expect(users.length).toBe(1);
});
// TODO: /users/:id/reinvite route tests missing
test('POST /users/:id/reinvite should send reinvite, but fail if user already accepted invite', async () => {
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
const authOwnerAgent = utils.createAgent(app, { auth: true, user: owner });
// TODO: UserManagementMailer is a singleton - cannot reinstantiate with wrong creds
// test('POST /users should error for wrong SMTP config', async () => {
// const owner = await Db.collections.User.findOneOrFail();
// const authOwnerAgent = utils.createAgent(app, { auth: true, user: owner });
config.set('userManagement.emails.mode', 'smtp');
// config.set('userManagement.emails.mode', 'smtp');
// config.set('userManagement.emails.smtp.host', 'XYZ'); // break SMTP config
// those configs are needed to make sure the reinvite email is sent,because of this check isEmailSetUp()
config.set('userManagement.emails.smtp.host', 'host');
config.set('userManagement.emails.smtp.auth.user', 'user');
config.set('userManagement.emails.smtp.auth.pass', 'pass');
// const payload = TEST_EMAILS_TO_CREATE_USER_SHELLS.map((e) => ({ email: e }));
const email = randomEmail();
const payload = [{ email }];
const response = await authOwnerAgent.post('/users').send(payload);
// const response = await authOwnerAgent.post('/users').send(payload);
expect(response.statusCode).toBe(200);
// expect(response.statusCode).toBe(500);
// });
const { data } = response.body;
const invitedUserId = data[0].user.id;
const reinviteResponse = await authOwnerAgent.post(`/users/${invitedUserId}/reinvite`);
expect(reinviteResponse.statusCode).toBe(200);
const member = await testDb.createUser({ globalRole: globalMemberRole });
const reinviteMemberResponse = await authOwnerAgent.post(`/users/${member.id}/reinvite`);
expect(reinviteMemberResponse.statusCode).toBe(400);
});
test('UserManagementMailer expect NodeMailer.verifyConnection have been called', async () => {
jest.spyOn(NodeMailer.prototype, 'verifyConnection').mockImplementation(async () => {});
// NodeMailer.verifyConnection called 1 time
const userManagementMailer = UserManagementMailer.getInstance();
// NodeMailer.verifyConnection called 2 time
(await userManagementMailer).verifyConnection();
expect(NodeMailer.prototype.verifyConnection).toHaveBeenCalledTimes(2);
// @ts-ignore
NodeMailer.prototype.verifyConnection.mockRestore();
});

2
packages/nodes-base/nodes/Function/Function.node.ts
View file

@ -95,7 +95,7 @@ return items;`,
if (item?.binary && item?.index !== undefined && item?.index !== null) {
for (const binaryPropertyName of Object.keys(item.binary)) {
item.binary[binaryPropertyName].data = (
await this.helpers.getBinaryDataBuffer(item.index, binaryPropertyName)
await this.helpers.getBinaryDataBuffer(item.index as number, binaryPropertyName)
)?.toString('base64');
}
}

2
packages/nodes-base/nodes/FunctionItem/FunctionItem.node.ts
View file

@ -113,7 +113,7 @@ return item;`,
if (item?.binary && item?.index !== undefined && item?.index !== null) {
for (const binaryPropertyName of Object.keys(item.binary)) {
item.binary[binaryPropertyName].data = (
await this.helpers.getBinaryDataBuffer(item.index, binaryPropertyName)
await this.helpers.getBinaryDataBuffer(item.index as number, binaryPropertyName)
)?.toString('base64');
}
}