mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

refactor(core): Better UX for maxStalledCount queue mode error (#9075)

Browse source
This commit is contained in:
Iván Ovejero 2024-04-05 20:03:49 +02:00 committed by GitHub
parent 7bf0f900f1
commit df56153f8b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 19 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/cli/src/commands/worker.ts
View file

@ -29,6 +29,7 @@ import { OrchestrationWorkerService } from '@/services/orchestration/worker/orch
import type { WorkerJobStatusSummary } from '@/services/orchestration/worker/types'; import type { WorkerJobStatusSummary } from '@/services/orchestration/worker/types';
import { ServiceUnavailableError } from '@/errors/response-errors/service-unavailable.error'; import { ServiceUnavailableError } from '@/errors/response-errors/service-unavailable.error';
import { BaseCommand } from './BaseCommand'; import { BaseCommand } from './BaseCommand';
import { MaxStalledCountError } from '@/errors/max-stalled-count.error';
export class Worker extends BaseCommand { export class Worker extends BaseCommand {
static description = '\nStarts a n8n worker'; static description = '\nStarts a n8n worker';
@ -366,6 +367,11 @@ export class Worker extends BaseCommand {
process.exit(2); process.exit(2);
} else { } else {
this.logger.error('Error from queue: ', error); this.logger.error('Error from queue: ', error);
if (error.message.includes('job stalled more than maxStalledCount')) {
throw new MaxStalledCountError(error);
}
throw error; throw error;
} }
}); });

13
packages/cli/src/errors/max-stalled-count.error.ts Normal file
View file

@ -0,0 +1,13 @@
import { ApplicationError } from 'n8n-workflow';
/**
* See https://github.com/OptimalBits/bull/blob/60fa88f08637f0325639988a3f054880a04ce402/docs/README.md?plain=1#L133
*/
export class MaxStalledCountError extends ApplicationError {
constructor(cause: Error) {
super('The execution has reached the maximum number of attempts and will no longer retry.', {
level: 'warning',
cause,
});
}
}