From dfff982662b7cee5c0203764a59d2355a02a9030 Mon Sep 17 00:00:00 2001 From: Jonathan Bennetts Date: Mon, 16 Jan 2023 13:12:58 +0000 Subject: [PATCH] feat(Google Ads Node): Update api version to v11 (#4427) --- .../nodes-base/credentials/GoogleAdsOAuth2Api.credentials.ts | 1 + packages/nodes-base/nodes/Google/Ads/CampaignDescription.ts | 5 ++--- packages/nodes-base/nodes/Google/Ads/GoogleAds.node.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/nodes-base/credentials/GoogleAdsOAuth2Api.credentials.ts b/packages/nodes-base/credentials/GoogleAdsOAuth2Api.credentials.ts index 5f7860c716..66ffc231d2 100644 --- a/packages/nodes-base/credentials/GoogleAdsOAuth2Api.credentials.ts +++ b/packages/nodes-base/credentials/GoogleAdsOAuth2Api.credentials.ts @@ -17,6 +17,7 @@ export class GoogleAdsOAuth2Api implements ICredentialType { name: 'developerToken', type: 'string', default: '', + required: true, }, { displayName: 'Scope', diff --git a/packages/nodes-base/nodes/Google/Ads/CampaignDescription.ts b/packages/nodes-base/nodes/Google/Ads/CampaignDescription.ts index 1a1eb4a4aa..83d21dbf32 100644 --- a/packages/nodes-base/nodes/Google/Ads/CampaignDescription.ts +++ b/packages/nodes-base/nodes/Google/Ads/CampaignDescription.ts @@ -45,7 +45,7 @@ export const campaignOperations: INodeProperties[] = [ routing: { request: { method: 'POST', - url: '={{"/v9/customers/" + $parameter["clientCustomerId"].toString().replace(/-/g, "") + "/googleAds:search"}}', + url: '={{"/v11/customers/" + $parameter["clientCustomerId"].toString().replace(/-/g, "") + "/googleAds:search"}}', body: { query: '={{ "' + @@ -93,7 +93,7 @@ export const campaignOperations: INodeProperties[] = [ routing: { request: { method: 'POST', - url: '={{"/v9/customers/" + $parameter["clientCustomerId"].toString().replace(/-/g, "") + "/googleAds:search"}}', + url: '={{"/v11/customers/" + $parameter["clientCustomerId"].toString().replace(/-/g, "") + "/googleAds:search"}}', returnFullResponse: true, body: { query: @@ -125,7 +125,6 @@ export const campaignOperations: INodeProperties[] = [ headers: { 'login-customer-id': '={{$parameter["managerCustomerId"].toString().replace(/-/g, "")}}', - 'content-type': 'application/x-www-form-urlencoded', }, }, output: { diff --git a/packages/nodes-base/nodes/Google/Ads/GoogleAds.node.ts b/packages/nodes-base/nodes/Google/Ads/GoogleAds.node.ts index 8a71399ddf..41714d355a 100644 --- a/packages/nodes-base/nodes/Google/Ads/GoogleAds.node.ts +++ b/packages/nodes-base/nodes/Google/Ads/GoogleAds.node.ts @@ -23,7 +23,7 @@ export class GoogleAds implements INodeType { testedBy: { request: { method: 'GET', - url: '/v9/customers:listAccessibleCustomers', + url: '/v11/customers:listAccessibleCustomers', }, }, },