mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 21:07:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

🎨 Rename setting "saveManualRuns" to "saveManualExecutions"

Browse source
This commit is contained in:
Jan Oberhauser 2019-07-10 18:06:26 +02:00
parent a56f477833
commit e00bc83f1b
8 changed files with 28 additions and 28 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/config/default.ts
View file

@ -27,7 +27,7 @@ module.exports = {
// are normally only for testing and debugging. This setting can
// also be overwritten on a per workflow basis in the workflow settings
// in the editor.
saveManualRuns: false,
saveManualExecutions: false,
},
nodes: {

2
packages/cli/src/Interfaces.ts
View file

@ -189,7 +189,7 @@ export interface IN8nConfigNodes {
export interface IN8nUISettings {
endpointWebhook: string;
endpointWebhookTest: string;
saveManualRuns: boolean;
saveManualExecutions: boolean;
timezone: string;
urlBaseWebhook: string;
}

10
packages/cli/src/Server.ts
View file

@ -73,7 +73,7 @@ class App {
testWebhooks: TestWebhooks.TestWebhooks;
endpointWebhook: string;
endpointWebhookTest: string;
saveManualRuns: boolean;
saveManualExecutions: boolean;
timezone: string;
activeExecutionsInstance: ActiveExecutions.ActiveExecutions;
push: Push.Push;
@ -83,7 +83,7 @@ class App {
this.endpointWebhook = config.get('urls.endpointWebhook') as string;
this.endpointWebhookTest = config.get('urls.endpointWebhookTest') as string;
this.saveManualRuns = config.get('executions.saveManualRuns') as boolean;
this.saveManualExecutions = config.get('executions.saveManualExecutions') as boolean;
this.timezone = config.get('timezone') as string;
this.config();
@ -271,9 +271,9 @@ class App {
// Do not save the default timezone
delete newWorkflowData.settings.timezone;
}
if (newWorkflowData.settings.saveManualRuns === 'DEFAULT') {
if (newWorkflowData.settings.saveManualExecutions === 'DEFAULT') {
// Do not save when default got set
delete newWorkflowData.settings.saveManualRuns;
delete newWorkflowData.settings.saveManualExecutions;
}
}
@ -900,7 +900,7 @@ class App {
return {
endpointWebhook: this.endpointWebhook,
endpointWebhookTest: this.endpointWebhookTest,
saveManualRuns: this.saveManualRuns,
saveManualExecutions: this.saveManualExecutions,
timezone: this.timezone,
urlBaseWebhook: WebhookHelpers.getWebhookBaseUrl(),
};

8
packages/cli/src/WorkflowExecuteAdditionalData.ts
View file

@ -120,13 +120,13 @@ const hooks = (mode: WorkflowExecuteMode, workflowData: IWorkflowBase, workflowI
const workflowSavePromise = WorkflowHelpers.saveStaticData(workflowInstance);
let saveManualRuns = config.get('executions.saveManualRuns') as boolean;
if (workflowInstance.settings !== undefined && workflowInstance.settings.saveManualRuns !== undefined) {
let saveManualExecutions = config.get('executions.saveManualExecutions') as boolean;
if (workflowInstance.settings !== undefined && workflowInstance.settings.saveManualExecutions !== undefined) {
// Apply to workflow override
saveManualRuns = workflowInstance.settings.saveManualRuns as boolean;
saveManualExecutions = workflowInstance.settings.saveManualExecutions as boolean;
}
if (mode === 'manual' && saveManualRuns === false) {
if (mode === 'manual' && saveManualExecutions === false) {
if (workflowSavePromise !== undefined) {
// If workflow had to be saved wait till it is done
await workflowSavePromise;

4
packages/editor-ui/src/Interface.ts
View file

@ -358,13 +358,13 @@ export interface IPushDataTestWebhook {
export interface IN8nUISettings {
endpointWebhook: string;
endpointWebhookTest: string;
saveManualRuns: boolean;
saveManualExecutions: boolean;
timezone: string;
urlBaseWebhook: string;
}
export interface IWorkflowSettings extends IWorkflowSettingsWorkflow {
errorWorkflow?: string;
saveManualRuns?: boolean;
saveManualExecutions?: boolean;
timezone?: string;
}

18
packages/editor-ui/src/components/WorkflowSettings.vue
View file

@ -42,14 +42,14 @@
</el-row>
<el-row>
<el-col :span="10" class="setting-name">
Save Manual Runs:
Save Manual Executions:
<el-tooltip class="setting-info" placement="top" effect="light">
<div slot="content" v-html="helpTexts.saveManualRuns"></div>
<div slot="content" v-html="helpTexts.saveManualExecutions"></div>
<font-awesome-icon icon="question-circle" />
</el-tooltip>
</el-col>
<el-col :span="14" class="ignore-key-press">
<el-select v-model="workflowSettings.saveManualRuns" placeholder="Select Option" size="small" filterable>
<el-select v-model="workflowSettings.saveManualExecutions" placeholder="Select Option" size="small" filterable>
<el-option
v-for="option of saveManualOptions"
:key="option.key"
@ -98,11 +98,11 @@ export default mixins(
helpTexts: {
errorWorkflow: 'The workflow to run in case the current one fails.<br />To function correctly that workflow has to contain an "Error Trigger" node!',
timezone: 'The timezone in which the workflow should run. Gets for example used by "Cron" node.',
saveManualRuns: 'If data data of executions should be saved when started manually from the editor.',
saveManualExecutions: 'If data data of executions should be saved when started manually from the editor.',
},
defaultValues: {
timezone: 'America/New_York',
saveManualRuns: false,
saveManualExecutions: false,
},
saveManualOptions: [] as Array<{ key: string | boolean, value: string }>,
timezones: [] as Array<{ key: string, value: string }>,
@ -128,7 +128,7 @@ export default mixins(
this.saveManualOptions.length = 0;
this.saveManualOptions.push({
key: 'DEFAULT',
value: 'Use default - ' + (this.defaultValues.saveManualRuns === true ? 'Yes' : 'No'),
value: 'Use default - ' + (this.defaultValues.saveManualExecutions === true ? 'Yes' : 'No'),
});
this.saveManualOptions.push({
key: true,
@ -196,7 +196,7 @@ export default mixins(
return;
}
this.defaultValues.saveManualRuns = this.$store.getters.saveManualRuns;
this.defaultValues.saveManualExecutions = this.$store.getters.saveManualExecutions;
this.defaultValues.timezone = this.$store.getters.timezone;
this.isLoading = true;
@ -216,8 +216,8 @@ export default mixins(
if (workflowSettings.timezone === undefined) {
workflowSettings.timezone = 'DEFAULT';
}
if (workflowSettings.saveManualRuns === undefined) {
workflowSettings.saveManualRuns = 'DEFAULT';
if (workflowSettings.saveManualExecutions === undefined) {
workflowSettings.saveManualExecutions = 'DEFAULT';
}
Vue.set(this, 'workflowSettings', workflowSettings);

10
packages/editor-ui/src/store.ts
View file

@ -46,7 +46,7 @@ export const store = new Vuex.Store({
executingNode: '' as string | null,
executionWaitingForWebhook: false,
pushConnectionActive: false,
saveManualRuns: false,
saveManualExecutions: false,
timezone: 'America/New_York',
workflowExecutionData: null as IExecutionResponse | null,
lastSelectedNode: null as string | null,
@ -458,8 +458,8 @@ export const store = new Vuex.Store({
Vue.set(state, 'endpointWebhookTest', endpointWebhookTest);
},
setSaveManualRuns (state, saveManualRuns: boolean) {
Vue.set(state, 'saveManualRuns', saveManualRuns);
setSaveManualExecutions (state, saveManualExecutions: boolean) {
Vue.set(state, 'saveManualExecutions', saveManualExecutions);
},
setTimezone (state, timezone: string) {
Vue.set(state, 'timezone', timezone);
@ -551,8 +551,8 @@ export const store = new Vuex.Store({
return `${state.urlBaseWebhook}${state.endpointWebhookTest}`;
},
saveManualRuns: (state): boolean => {
return state.saveManualRuns;
saveManualExecutions: (state): boolean => {
return state.saveManualExecutions;
},
timezone: (state): string => {
return state.timezone;

2
packages/editor-ui/src/views/NodeView.vue
View file

@ -1677,7 +1677,7 @@ export default mixins(
this.$store.commit('setUrlBaseWebhook', settings.urlBaseWebhook);
this.$store.commit('setEndpointWebhook', settings.endpointWebhook);
this.$store.commit('setEndpointWebhookTest', settings.endpointWebhookTest);
this.$store.commit('setSaveManualRuns', settings.saveManualRuns);
this.$store.commit('setSaveManualExecutions', settings.saveManualExecutions);
this.$store.commit('setTimezone', settings.timezone);
},
async loadNodeTypes (): Promise<void> {