mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 12:57:29 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

fix(editor): Prevent scrim on executable triggers (#5068)

Browse source 
🐛 Prevent scrim on executable triggers
This commit is contained in:
Iván Ovejero 2023-01-03 11:25:50 +01:00 committed by GitHub
parent 43304b0691
commit e1f9349c19
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/editor-ui/src/components/NodeDetailsView.vue
View file

@ -77,7 +77,7 @@
:linkedRuns="linked" :linkedRuns="linked"
:sessionId="sessionId" :sessionId="sessionId"
:isReadOnly="readOnly || hasForeignCredential" :isReadOnly="readOnly || hasForeignCredential"
:blockUI="blockUi && isTriggerNode" :blockUI="blockUi && isTriggerNode && !isExecutableTriggerNode"
:isProductionExecutionPreview="isProductionExecutionPreview" :isProductionExecutionPreview="isProductionExecutionPreview"
@linkRun="onLinkRunToOutput" @linkRun="onLinkRunToOutput"
@unlinkRun="() => onUnlinkRun('output')" @unlinkRun="() => onUnlinkRun('output')"
@ -143,6 +143,7 @@ import TriggerPanel from './TriggerPanel.vue';
import { import {
BASE_NODE_SURVEY_URL, BASE_NODE_SURVEY_URL,
EnterpriseEditionFeature, EnterpriseEditionFeature,
EXECUTABLE_TRIGGER_NODE_TYPES,
START_NODE_TYPE, START_NODE_TYPE,
STICKY_NODE_TYPE, STICKY_NODE_TYPE,
} from '@/constants'; } from '@/constants';
@ -269,6 +270,11 @@ export default mixins(
parentNode(): string | undefined { parentNode(): string | undefined {
return this.parentNodes[0]; return this.parentNodes[0];
}, },
isExecutableTriggerNode(): boolean {
if (!this.activeNodeType) return false;
return EXECUTABLE_TRIGGER_NODE_TYPES.includes(this.activeNodeType.name);
},
isTriggerNode(): boolean { isTriggerNode(): boolean {
return ( return (
!!this.activeNodeType && !!this.activeNodeType &&

8
packages/editor-ui/src/constants.ts
View file

@ -126,6 +126,14 @@ export const XERO_NODE_TYPE = 'n8n-nodes-base.xero';
export const ZENDESK_NODE_TYPE = 'n8n-nodes-base.zendesk'; export const ZENDESK_NODE_TYPE = 'n8n-nodes-base.zendesk';
export const ZENDESK_TRIGGER_NODE_TYPE = 'n8n-nodes-base.zendeskTrigger'; export const ZENDESK_TRIGGER_NODE_TYPE = 'n8n-nodes-base.zendeskTrigger';
export const EXECUTABLE_TRIGGER_NODE_TYPES = [
START_NODE_TYPE,
MANUAL_TRIGGER_NODE_TYPE,
SCHEDULE_TRIGGER_NODE_TYPE,
CRON_NODE_TYPE,
INTERVAL_NODE_TYPE,
];
export const NON_ACTIVATABLE_TRIGGER_NODE_TYPES = [ export const NON_ACTIVATABLE_TRIGGER_NODE_TYPES = [
ERROR_TRIGGER_NODE_TYPE, ERROR_TRIGGER_NODE_TYPE,
MANUAL_TRIGGER_NODE_TYPE, MANUAL_TRIGGER_NODE_TYPE,