mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

feat(MISP Node): Update credential to support HTTP Request node (#7268)

Browse source
This commit is contained in:
Jon 2023-09-27 11:05:48 +01:00 committed by GitHub
parent 6d7fe95c58
commit e4c302c683
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 25 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
packages/nodes-base/credentials/MispApi.credentials.ts
View file

@ -1,4 +1,9 @@
import type { ICredentialType, INodeProperties } from 'n8n-workflow';
import type {
IAuthenticateGeneric,
ICredentialTestRequest,
ICredentialType,
INodeProperties,
} from 'n8n-workflow';
export class MispApi implements ICredentialType {
name = 'mispApi';
@ -29,4 +34,21 @@ export class MispApi implements ICredentialType {
default: false,
},
];
authenticate: IAuthenticateGeneric = {
type: 'generic',
properties: {
headers: {
Authorization: '={{$credentials.apiKey}}',
},
},
};
test: ICredentialTestRequest = {
request: {
baseURL: '={{$credentials.baseUrl.replace(new RegExp("/$"), "")}}',
url: '/tags',
skipSslCertificateValidation: '={{$credentials.allowUnauthorizedCerts}}',
},
};
}

7
packages/nodes-base/nodes/Misp/GenericFunctions.ts
View file

@ -19,14 +19,11 @@ export async function mispApiRequest(
body: IDataObject = {},
qs: IDataObject = {},
) {
const { baseUrl, apiKey, allowUnauthorizedCerts } = (await this.getCredentials(
const { baseUrl, allowUnauthorizedCerts } = (await this.getCredentials(
'mispApi',
)) as MispCredentials;
const options: OptionsWithUri = {
headers: {
Authorization: apiKey,
},
method,
body,
qs,
@ -44,7 +41,7 @@ export async function mispApiRequest(
}
try {
return await this.helpers.request(options);
return await this.helpers.requestWithAuthentication.call(this, 'mispApi', options);
} catch (error) {
// MISP API wrongly returns 403 for malformed requests
if (error.statusCode === 403) {