From e5ad1e7e4df33a06c9649fe0652edfc80f7cb818 Mon Sep 17 00:00:00 2001 From: Michael Kret <88898367+michael-radency@users.noreply.github.com> Date: Thu, 5 Oct 2023 16:19:19 +0300 Subject: [PATCH] fix(Set Node): Increase search priority (#7358) Github issue / Community forum post (link here to close automatically): --- cypress/e2e/4-node-creator.cy.ts | 24 ++++++++++++++----- .../ExecutionData/ExecutionData.node.json | 2 +- packages/nodes-base/nodes/Set/Set.node.json | 2 +- 3 files changed, 20 insertions(+), 8 deletions(-) diff --git a/cypress/e2e/4-node-creator.cy.ts b/cypress/e2e/4-node-creator.cy.ts index ef057e8d78..c291bc5748 100644 --- a/cypress/e2e/4-node-creator.cy.ts +++ b/cypress/e2e/4-node-creator.cy.ts @@ -15,7 +15,10 @@ describe('Node Creator', () => { it('should open node creator on trigger tab if no trigger is on canvas', () => { nodeCreatorFeature.getters.canvasAddButton().click(); - nodeCreatorFeature.getters.nodeCreator().contains('What triggers this workflow?').should('be.visible'); + nodeCreatorFeature.getters + .nodeCreator() + .contains('What triggers this workflow?') + .should('be.visible'); }); it('should navigate subcategory', () => { @@ -73,7 +76,10 @@ describe('Node Creator', () => { nodeCreatorFeature.getters.nodeCreator().contains('What happens next?').should('be.visible'); nodeCreatorFeature.getters.getCreatorItem('Add another trigger').click(); - nodeCreatorFeature.getters.nodeCreator().contains('What triggers this workflow?').should('be.visible'); + nodeCreatorFeature.getters + .nodeCreator() + .contains('What triggers this workflow?') + .should('be.visible'); nodeCreatorFeature.getters.activeSubcategory().find('button').should('exist'); nodeCreatorFeature.getters.activeSubcategory().find('button').click(); nodeCreatorFeature.getters.nodeCreator().contains('What happens next?').should('be.visible'); @@ -321,7 +327,7 @@ describe('Node Creator', () => { nodeCreatorFeature.getters.searchBar().find('input').clear().type('email'); nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'Email Trigger (IMAP)'); - nodeCreatorFeature.getters.searchBar().find('input').clear().type('Edit Fields (Set)'); + nodeCreatorFeature.getters.searchBar().find('input').clear().type('Set'); nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'Edit Fields (Set)'); nodeCreatorFeature.getters.searchBar().find('input').clear().type('i'); @@ -329,7 +335,7 @@ describe('Node Creator', () => { nodeCreatorFeature.getters.nodeItemName().eq(1).should('have.text', 'Switch'); nodeCreatorFeature.getters.searchBar().find('input').clear().type('sw'); - nodeCreatorFeature.getters.searchBar().find('input').clear().type('Edit Fields (Set)'); + nodeCreatorFeature.getters.searchBar().find('input').clear().type('Edit F'); nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'Edit Fields (Set)'); nodeCreatorFeature.getters.searchBar().find('input').clear().type('i'); @@ -422,10 +428,16 @@ describe('Node Creator', () => { nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'S3'); nodeCreatorFeature.getters.searchBar().find('input').clear().type('no op'); - nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'No Operation, do nothing'); + nodeCreatorFeature.getters + .nodeItemName() + .first() + .should('have.text', 'No Operation, do nothing'); nodeCreatorFeature.getters.searchBar().find('input').clear().type('do no'); - nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'No Operation, do nothing'); + nodeCreatorFeature.getters + .nodeItemName() + .first() + .should('have.text', 'No Operation, do nothing'); nodeCreatorFeature.getters.searchBar().find('input').clear().type('htt'); nodeCreatorFeature.getters.nodeItemName().first().should('have.text', 'HTTP Request'); diff --git a/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.json b/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.json index da77f86d42..badc166987 100644 --- a/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.json +++ b/packages/nodes-base/nodes/ExecutionData/ExecutionData.node.json @@ -13,5 +13,5 @@ } ] }, - "alias": ["Filter", "Set", "Data"] + "alias": ["Filter", "_Set", "Data"] } diff --git a/packages/nodes-base/nodes/Set/Set.node.json b/packages/nodes-base/nodes/Set/Set.node.json index 3ca525fbee..ec62590cae 100644 --- a/packages/nodes-base/nodes/Set/Set.node.json +++ b/packages/nodes-base/nodes/Set/Set.node.json @@ -121,7 +121,7 @@ } ] }, - "alias": ["JSON", "Filter", "Transform", "Map", "Set"], + "alias": ["Set", "JSON", "Filter", "Transform", "Map"], "subcategories": { "Core Nodes": ["Data Transformation"] }