mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 04:04:06 -08:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity

refactor(core): Enable interim updates check (#4582)

Browse source 
* ⚡ Enable interim updates check

* ⚡ Set default value

* ⏪ Undo default value, keep as sentinel

* 🧪 Unskip tests
This commit is contained in:
Iván Ovejero 2022-11-14 15:38:19 +01:00 committed by GitHub
parent 0148631d28
commit e7316c588f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
packages/cli/src/workflows/workflows.services.ts
View file

@ -196,13 +196,13 @@ export class WorkflowsService {
);
}
// if (!forceSave && workflow.hash !== shared.workflow.hash) {
// throw new ResponseHelper.ResponseError(
// `Workflow ID ${workflowId} cannot be saved because it was changed by another user.`,
// undefined,
// 400,
// );
// }
if (!forceSave && workflow.hash !== '' && workflow.hash !== shared.workflow.hash) {
throw new ResponseHelper.ResponseError(
`Workflow ID ${workflowId} cannot be saved because it was changed by another user.`,
undefined,
400,
);
}
// check credentials for old format
await WorkflowHelpers.replaceInvalidCredentials(workflow);

2
packages/cli/test/integration/workflows.controller.ee.test.ts
View file

@ -730,7 +730,7 @@ describe('PATCH /workflows/:id - validate credential permissions to user', () =>
});
});
describe.skip('PATCH /workflows/:id - validate interim updates', () => {
describe('PATCH /workflows/:id - validate interim updates', () => {
it('should block owner updating workflow nodes on interim update by member', async () => {
const owner = await testDb.createUser({ globalRole: globalOwnerRole });
const member = await testDb.createUser({ globalRole: globalMemberRole });