mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Add paginations and refactor all getAll methods

Browse source
This commit is contained in:
trojanh 2020-01-29 13:27:54 +05:30
parent a852af6530
commit e9d8031a68
2 changed files with 54 additions and 147 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
packages/nodes-base/nodes/Harvest/GenericFunctions.ts
View file

@ -11,7 +11,7 @@ export async function harvestApiRequest(
this: IHookFunctions | IExecuteFunctions | IExecuteSingleFunctions | ILoadOptionsFunctions,
method: string,
qs: IDataObject = {},
uri?: string,
uri: string,
body: IDataObject = {},
option: IDataObject = {},
): Promise<any> { // tslint:disable-line:no-any
@ -45,7 +45,6 @@ export async function harvestApiRequest(
"User-Agent": "Harvest API"
}
};
console.log({options})
options = Object.assign({}, options, option);
if (Object.keys(options.body).length === 0) {
@ -53,7 +52,7 @@ export async function harvestApiRequest(
}
try {
const result = await this.helpers.request!(options);
console.log(result);
return result;
} catch (error) {
if (error.statusCode === 401) {
@ -79,7 +78,8 @@ export async function harvestApiRequestAllItems(
this: IHookFunctions | IExecuteFunctions | IExecuteSingleFunctions | ILoadOptionsFunctions,
method: string,
qs: IDataObject = {},
uri?: string,
uri: string,
resource: string,
body: IDataObject = {},
option: IDataObject = {},
): Promise<any> { // tslint:disable-line:no-any
@ -91,12 +91,9 @@ export async function harvestApiRequestAllItems(
try {
do {
responseData = await harvestApiRequest.call(this, method, qs, uri, body, option);
qs.cursor = responseData.cursor.id;
returnData.push.apply(returnData, responseData.response);
} while (
responseData.cursor.more === true &&
responseData.cursor.hasNext === true
);
qs.page = responseData.next_page;
returnData.push.apply(returnData, responseData[resource]);
} while (responseData.next_page);
return returnData;
} catch(error) {
throw error;

184
packages/nodes-base/nodes/Harvest/Harvest.node.ts
View file

@ -8,7 +8,7 @@ import {
INodeType,
} from 'n8n-workflow';
import { harvestApiRequest } from './GenericFunctions';
import { harvestApiRequest, harvestApiRequestAllItems } from './GenericFunctions';
import { timeEntryOperations, timeEntryFields } from './TimeEntryDescription';
import { clientOperations, clientFields } from './ClientDescription';
import { companyOperations } from './CompanyDescription';
@ -20,6 +20,34 @@ import { taskOperations, taskFields } from './TaskDescription';
import { userOperations, userFields } from './UserDescription';
import { estimateOperations, estimateFields } from './EstimateDescription';
/**
* fetch All resource using paginated calls
*/
async function getAllResource(this: IExecuteFunctions, resource: string, i: number) {
const endpoint = resource;
let qs: IDataObject = {};
const requestMethod: string = "GET";
qs.per_page = 100;
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const returnAll = this.getNodeParameter('returnAll', i) as boolean;
Object.assign(qs, additionalFields);
try {
let responseData: IDataObject = {};
if(returnAll) {
responseData[resource] = await harvestApiRequestAllItems.call(this, requestMethod, qs, endpoint, resource);
} else {
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
}
return responseData[resource] as IDataObject[];
} catch (error) {
throw error;
}
}
export class Harvest implements INodeType {
description: INodeTypeDescription = {
@ -158,22 +186,8 @@ export class Harvest implements INodeType {
// ----------------------------------
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'time_entries';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.time_entries as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'time_entries', i);
returnData.push.apply(returnData, responseData);
} else if (operation === 'createByStartEnd') {
// ----------------------------------
@ -322,21 +336,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'clients';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.clients as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'clients', i);
returnData.push.apply(returnData, responseData);
} else {
throw new Error(`The resource "${resource}" is not known!`);
@ -364,21 +365,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'projects';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.projects as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'projects', i);
returnData.push.apply(returnData, responseData);
} else {
throw new Error(`The resource "${resource}" is not known!`);
@ -406,21 +394,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'users';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.users as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'users', i);
returnData.push.apply(returnData, responseData);
} else if (operation === 'me') {
// ----------------------------------
@ -464,21 +439,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'contacts';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.contacts as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'contacts', i);
returnData.push.apply(returnData, responseData);
} else {
throw new Error(`The resource "${resource}" is not known!`);
@ -525,21 +487,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'tasks';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.companies as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'tasks', i);
returnData.push.apply(returnData, responseData);
} else {
throw new Error(`The resource "${resource}" is not known!`);
@ -567,21 +516,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'invoices';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.invoices as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'invoices', i);
returnData.push.apply(returnData, responseData);
} else {
throw new Error(`The resource "${resource}" is not known!`);
@ -609,21 +545,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'expenses';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.expenses as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'expenses', i);
returnData.push.apply(returnData, responseData);
} else {
throw new Error(`The resource "${resource}" is not known!`);
@ -651,21 +574,8 @@ export class Harvest implements INodeType {
// getAll
// ----------------------------------
requestMethod = 'GET';
endpoint = 'estimates';
const additionalFields = this.getNodeParameter('filters', i) as IDataObject;
const limit = this.getNodeParameter('limit', i) as string;
qs.per_page = limit;
Object.assign(qs, additionalFields);
try {
let responseData = await harvestApiRequest.call(this, requestMethod, qs, endpoint);
returnData.push.apply(returnData, responseData.estimates as IDataObject[]);
} catch (error) {
throw error;
}
const responseData: IDataObject[] = await getAllResource.call(this, 'estimates', i);
returnData.push.apply(returnData, responseData);
} else {
throw new Error(`The resource "${resource}" is not known!`);