mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(core): Add executionData to expressions in pagination code (#10926)

Browse source
This commit is contained in:
Elias Meire 2024-09-23 15:14:53 +02:00 committed by GitHub
parent 5c171c4bf0
commit eac103e367
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 1911 additions and 1964 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/core/src/NodeExecuteFunctions.ts
View file

@ -2995,6 +2995,8 @@ const getRequestHelperFunctions = (
workflow: Workflow, workflow: Workflow,
node: INode, node: INode,
additionalData: IWorkflowExecuteAdditionalData, additionalData: IWorkflowExecuteAdditionalData,
runExecutionData: IRunExecutionData | null = null,
connectionInputData: INodeExecutionData[] = [],
): RequestHelperFunctions => { ): RequestHelperFunctions => {
const getResolvedValue = ( const getResolvedValue = (
parameterValue: NodeParameterValueType, parameterValue: NodeParameterValueType,
@ -3004,8 +3006,6 @@ const getRequestHelperFunctions = (
additionalKeys?: IWorkflowDataProxyAdditionalKeys, additionalKeys?: IWorkflowDataProxyAdditionalKeys,
returnObjectAsString = false, returnObjectAsString = false,
): NodeParameterValueType => { ): NodeParameterValueType => {
const runExecutionData: IRunExecutionData | null = null;
const connectionInputData: INodeExecutionData[] = [];
const mode: WorkflowExecuteMode = 'internal'; const mode: WorkflowExecuteMode = 'internal';
if ( if (
@ -3874,7 +3874,13 @@ export function getExecuteFunctions(
helpers: { helpers: {
createDeferredPromise, createDeferredPromise,
copyInputItems, copyInputItems,
...getRequestHelperFunctions(workflow, node, additionalData), ...getRequestHelperFunctions(
workflow,
node,
additionalData,
runExecutionData,
connectionInputData,
),
...getSSHTunnelFunctions(), ...getSSHTunnelFunctions(),
...getFileSystemHelperFunctions(node), ...getFileSystemHelperFunctions(node),
...getBinaryHelperFunctions(additionalData, workflow.id), ...getBinaryHelperFunctions(additionalData, workflow.id),
@ -4031,7 +4037,13 @@ export function getExecuteSingleFunctions(
}, },
helpers: { helpers: {
createDeferredPromise, createDeferredPromise,
...getRequestHelperFunctions(workflow, node, additionalData), ...getRequestHelperFunctions(
workflow,
node,
additionalData,
runExecutionData,
connectionInputData,
),
...getBinaryHelperFunctions(additionalData, workflow.id), ...getBinaryHelperFunctions(additionalData, workflow.id),
assertBinaryData: (propertyName, inputIndex = 0) => assertBinaryData: (propertyName, inputIndex = 0) =>

3855
packages/nodes-base/nodes/HttpRequest/test/node/workflow.pagination.json
View file

File diff suppressed because it is too large Load diff