From ebb3aaf61ea5cbc66d0270d59d019026fe97ed2f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Tue, 16 May 2023 09:43:46 +0000 Subject: [PATCH] refactor(editor): Drop vue-typed-mixins (no-changelog) (#6257) --- packages/@n8n_io/eslint-config/frontend.js | 6 ++++ packages/design-system/package.json | 2 -- packages/editor-ui/package.json | 1 - packages/editor-ui/src/App.vue | 5 +-- .../src/components/BinaryDataDisplay.vue | 7 ++-- .../src/components/BinaryDataDisplayEmbed.vue | 6 ++-- .../src/components/BreakpointsObserver.vue | 5 +-- .../src/components/ChangePasswordModal.vue | 2 +- .../CodeNodeEditor/CodeNodeEditor.vue | 5 +-- .../components/CodeNodeEditor/completer.ts | 34 +++++++++---------- .../src/components/CollectionCard.vue | 5 +-- .../src/components/CollectionParameter.vue | 9 ++--- .../src/components/CollectionWorkflowCard.vue | 5 +-- .../src/components/CollectionsCarousel.vue | 5 +-- .../src/components/ContactPromptModal.vue | 10 +++--- .../editor-ui/src/components/CopyInput.vue | 5 +-- .../CredentialEdit/CredentialConfig.vue | 7 ++-- .../CredentialEdit/CredentialEdit.vue | 7 ++-- .../src/components/CredentialIcon.vue | 5 +-- .../src/components/CredentialsSelectModal.vue | 5 +-- .../src/components/DeleteUserModal.vue | 2 +- .../src/components/DraggableTarget.vue | 4 +-- .../components/DuplicateWorkflowDialog.vue | 10 +++--- .../src/components/Error/NodeErrorView.vue | 7 ++-- .../src/components/ExecutionTime.vue | 6 ++-- .../src/components/ExecutionsList.vue | 8 ++--- .../ExecutionsView/ExecutionCard.vue | 5 +-- .../ExecutionsView/ExecutionPreview.vue | 8 +++-- .../ExecutionsInfoAccordion.vue | 7 ++-- .../ExecutionsView/ExecutionsList.vue | 8 +++-- .../ExpandableInput/ExpandableInputEdit.vue | 2 +- .../ExpandableInputPreview.vue | 2 +- .../src/components/ExpressionEdit.vue | 7 ++-- .../ExpressionEditorModalInput.vue | 5 +-- .../src/components/FeatureComingSoon.vue | 4 +-- .../editor-ui/src/components/GoBackButton.vue | 2 +- .../src/components/HtmlEditor/HtmlEditor.vue | 5 +-- .../InlineExpressionEditorInput.vue | 5 +-- .../editor-ui/src/components/InputPanel.vue | 7 ++-- .../src/components/IntersectionObserved.vue | 5 +-- .../src/components/InviteUsersModal.vue | 10 +++--- packages/editor-ui/src/components/Logo.vue | 4 +-- .../src/components/MainHeader/MainHeader.vue | 6 ++-- .../components/MainHeader/WorkflowDetails.vue | 8 +++-- .../src/components/NDVDraggablePanels.vue | 7 ++-- packages/editor-ui/src/components/Node.vue | 18 +++------- .../src/components/NodeCredentials.vue | 8 ++--- .../editor-ui/src/components/NodeList.vue | 6 ++-- .../editor-ui/src/components/NodeSettings.vue | 8 ++--- .../src/components/NodeSettingsTabs.vue | 7 ++-- .../editor-ui/src/components/NodeWebhooks.vue | 6 ++-- .../components/OnboardingCallSignupModal.vue | 2 +- .../editor-ui/src/components/OutputPanel.vue | 5 +-- .../src/components/ParameterInput.vue | 7 ++-- .../src/components/ParameterInputFull.vue | 13 +++---- .../src/components/ParameterInputHint.vue | 2 +- .../src/components/ParameterInputList.vue | 10 +++--- .../src/components/ParameterInputWrapper.vue | 7 ++-- .../src/components/PersonalizationModal.vue | 9 ++--- .../src/components/PushConnectionTracker.vue | 4 +-- .../ResourceLocator/ResourceLocator.vue | 8 ++--- packages/editor-ui/src/components/RunData.vue | 7 ++-- .../editor-ui/src/components/RunDataJson.vue | 5 +-- .../src/components/RunDataJsonActions.vue | 8 +++-- .../editor-ui/src/components/RunDataTable.vue | 9 ++--- packages/editor-ui/src/components/RunInfo.vue | 2 +- .../editor-ui/src/components/ScopesNotice.vue | 4 +-- .../src/components/SettingsSidebar.vue | 7 ++-- packages/editor-ui/src/components/Sticky.vue | 9 ++--- .../src/components/TagsContainer.vue | 2 +- .../TagsManager/TagsView/TagsTableHeader.vue | 2 +- .../TagsManager/TagsView/TagsView.vue | 2 +- .../editor-ui/src/components/Telemetry.vue | 7 ++-- .../editor-ui/src/components/TemplateCard.vue | 5 +-- .../src/components/TemplateFilters.vue | 5 +-- .../editor-ui/src/components/TemplateList.vue | 5 +-- .../editor-ui/src/components/TriggerPanel.vue | 7 ++-- .../editor-ui/src/components/ValueSurvey.vue | 7 ++-- .../src/components/VariableSelector.vue | 7 ++-- .../src/components/VariableSelectorItem.vue | 5 +-- .../editor-ui/src/components/VersionCard.vue | 2 +- .../src/components/WorkflowSettings.vue | 8 ++--- .../src/components/layouts/PageViewLayout.vue | 4 +-- .../layouts/ResourcesListLayout.vue | 11 +++--- .../editor-ui/src/mixins/completionManager.ts | 5 +-- .../editor-ui/src/mixins/executionsHelpers.ts | 7 ++-- .../editor-ui/src/mixins/expressionManager.ts | 10 +++--- .../editor-ui/src/mixins/moveNodeWorkflow.ts | 8 +++-- packages/editor-ui/src/mixins/nodeBase.ts | 8 +++-- .../editor-ui/src/mixins/workflowActivate.ts | 5 +-- .../editor-ui/src/mixins/workflowHelpers.ts | 4 +-- packages/editor-ui/src/mixins/workflowRun.ts | 4 +-- .../src/views/SettingsLogStreamingView.vue | 6 ++-- .../editor-ui/src/views/SettingsUsersView.vue | 7 ++-- .../src/views/TemplatesCollectionView.vue | 8 +++-- .../src/views/TemplatesSearchView.vue | 7 ++-- .../src/views/TemplatesWorkflowView.vue | 8 +++-- pnpm-lock.yaml | 10 ------ 98 files changed, 340 insertions(+), 287 deletions(-) diff --git a/packages/@n8n_io/eslint-config/frontend.js b/packages/@n8n_io/eslint-config/frontend.js index 804f1949b0..c2ad35031a 100644 --- a/packages/@n8n_io/eslint-config/frontend.js +++ b/packages/@n8n_io/eslint-config/frontend.js @@ -25,5 +25,11 @@ module.exports = { 'vue/no-deprecated-slot-scope-attribute': 'error', 'vue/no-multiple-template-root': 'error', 'vue/v-slot-style': 'error', + + // TODO: remove these + 'vue/no-unused-components': 'warn', + 'vue/return-in-computed-property': 'warn', + 'vue/no-mutating-props': 'warn', + '@typescript-eslint/no-floating-promises': 'warn', }, }; diff --git a/packages/design-system/package.json b/packages/design-system/package.json index 093fe2f94b..7ccbc291a5 100644 --- a/packages/design-system/package.json +++ b/packages/design-system/package.json @@ -35,7 +35,6 @@ "markdown-it-link-attributes": "^4.0.0", "markdown-it-task-lists": "^2.1.1", "vue": "^2.7.14", - "vue-typed-mixins": "^0.2.0", "xss": "^1.0.14" }, "devDependencies": { @@ -71,7 +70,6 @@ "markdown-it-task-lists": "^2.1.1", "sanitize-html": "2.10.0", "vue": "^2.7.14", - "vue-typed-mixins": "^0.2.0", "vue2-boring-avatars": "^0.3.8", "xss": "^1.0.14" } diff --git a/packages/editor-ui/package.json b/packages/editor-ui/package.json index 9a0fe5f96c..7cd8aa07f0 100644 --- a/packages/editor-ui/package.json +++ b/packages/editor-ui/package.json @@ -76,7 +76,6 @@ "vue-infinite-loading": "^2.4.5", "vue-json-pretty": "1.9.3", "vue-router": "^3.6.5", - "vue-typed-mixins": "^0.2.0", "vue2-teleport": "^1.0.1", "vue2-touch-events": "^3.2.1", "xss": "^1.0.14" diff --git a/packages/editor-ui/src/App.vue b/packages/editor-ui/src/App.vue index 8639f830ec..d347b11b67 100644 --- a/packages/editor-ui/src/App.vue +++ b/packages/editor-ui/src/App.vue @@ -27,6 +27,9 @@ diff --git a/packages/editor-ui/src/components/ExpressionEdit.vue b/packages/editor-ui/src/components/ExpressionEdit.vue index db23d82aa3..51d17d6690 100644 --- a/packages/editor-ui/src/components/ExpressionEdit.vue +++ b/packages/editor-ui/src/components/ExpressionEdit.vue @@ -74,6 +74,8 @@