mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Notion Node): Rename Notion API Key to Internal Integration Token (#7176)

Browse source 
Github issue / Community forum post (link here to close automatically):
This commit is contained in:
Elias Meire 2023-09-29 09:21:29 +02:00 committed by GitHub
parent cf5a0ca456
commit ec2aa3819c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cypress/e2e/17-sharing.cy.ts
View file

@ -39,7 +39,7 @@ describe('Sharing', { disableAutoLogin: true }, () => {
credentialsPage.getters.emptyListCreateCredentialButton().click(); credentialsPage.getters.emptyListCreateCredentialButton().click();
credentialsModal.getters.newCredentialTypeOption('Notion API').click(); credentialsModal.getters.newCredentialTypeOption('Notion API').click();
credentialsModal.getters.newCredentialTypeButton().click(); credentialsModal.getters.newCredentialTypeButton().click();
credentialsModal.getters.connectionParameter('API Key').type('1234567890'); credentialsModal.getters.connectionParameter('Internal Integration Secret').type('1234567890');
credentialsModal.actions.setName('Credential C1'); credentialsModal.actions.setName('Credential C1');
credentialsModal.actions.save(); credentialsModal.actions.save();
credentialsModal.actions.close(); credentialsModal.actions.close();

14
cypress/e2e/2-credentials.cy.ts
View file

@ -1,16 +1,16 @@
import { import {
GMAIL_NODE_NAME,
HTTP_REQUEST_NODE_NAME,
NEW_GOOGLE_ACCOUNT_NAME,
NEW_NOTION_ACCOUNT_NAME, NEW_NOTION_ACCOUNT_NAME,
NEW_QUERY_AUTH_ACCOUNT_NAME,
NEW_TRELLO_ACCOUNT_NAME,
NOTION_NODE_NAME, NOTION_NODE_NAME,
PIPEDRIVE_NODE_NAME, PIPEDRIVE_NODE_NAME,
HTTP_REQUEST_NODE_NAME,
NEW_QUERY_AUTH_ACCOUNT_NAME,
GMAIL_NODE_NAME,
NEW_GOOGLE_ACCOUNT_NAME,
NEW_TRELLO_ACCOUNT_NAME,
SCHEDULE_TRIGGER_NODE_NAME, SCHEDULE_TRIGGER_NODE_NAME,
TRELLO_NODE_NAME, TRELLO_NODE_NAME,
} from '../constants'; } from '../constants';
import { CredentialsPage, CredentialsModal, WorkflowPage, NDV } from '../pages'; import { CredentialsModal, CredentialsPage, NDV, WorkflowPage } from '../pages';
import { getVisibleSelect } from '../utils'; import { getVisibleSelect } from '../utils';
const credentialsPage = new CredentialsPage(); const credentialsPage = new CredentialsPage();
@ -33,7 +33,7 @@ describe('Credentials', () => {
credentialsModal.getters.newCredentialTypeOption('Notion API').click(); credentialsModal.getters.newCredentialTypeOption('Notion API').click();
credentialsModal.getters.newCredentialTypeButton().click(); credentialsModal.getters.newCredentialTypeButton().click();
credentialsModal.getters.connectionParameter('API Key').type('1234567890'); credentialsModal.getters.connectionParameter('Internal Integration Secret').type('1234567890');
credentialsModal.actions.setName('My awesome Notion account'); credentialsModal.actions.setName('My awesome Notion account');
credentialsModal.actions.save(); credentialsModal.actions.save();

2
packages/nodes-base/credentials/NotionApi.credentials.ts
View file

@ -15,7 +15,7 @@ export class NotionApi implements ICredentialType {
properties: INodeProperties[] = [ properties: INodeProperties[] = [
{ {
displayName: 'API Key', displayName: 'Internal Integration Secret',
name: 'apiKey', name: 'apiKey',
type: 'string', type: 'string',
typeOptions: { password: true }, typeOptions: { password: true },