mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡ Minor improvements to ActiveCampaign-Node

Browse source
This commit is contained in:
Jan Oberhauser 2020-09-18 09:42:46 +02:00
parent a552febab4
commit ed0f701c6a
3 changed files with 22 additions and 24 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/nodes-base/nodes/ActiveCampaign/ActiveCampaign.node.ts
View file

@ -474,7 +474,7 @@ export class ActiveCampaign implements INodeType {
} else {
throw new Error(`The operation "${operation}" is not known`);
}
} else if (resource === 'accountContact') {
} else if (resource === 'accountContact') {
if (operation === 'create') {
// ----------------------------------
// account:create

2
packages/nodes-base/nodes/ActiveCampaign/ActiveCampaignTrigger.node.ts
View file

@ -142,7 +142,7 @@ export class ActiveCampaignTrigger implements INodeType {
const webhookData = this.getWorkflowStaticData('node');
try {
await activeCampaignApiRequest.call(this, 'DELETE', `/api/3/webhooks/${webhookData.webhookId}`, {});
} catch(error) {
} catch (error) {
return false;
}
delete webhookData.webhookId;

42
packages/nodes-base/nodes/ActiveCampaign/GenericFunctions.ts
View file

@ -49,8 +49,6 @@ export async function activeCampaignApiRequest(this: IHookFunctions | IExecuteFu
options.body = body;
}
console.log(options);
try {
const responseData = await this.helpers.request!(options);
@ -127,11 +125,11 @@ export async function activeCampaignApiRequestAllItems(this: IHookFunctions | IE
return returnData;
}
export function activeCampaignDefaultGetAllProperties (resource: string, operation: string): INodeProperties [] {
export function activeCampaignDefaultGetAllProperties(resource: string, operation: string): INodeProperties[] {
return [
{
displayName: 'Return All',
name: 'returnAll',
name: 'returnAll',
type: 'boolean',
displayOptions: {
show: {
@ -148,26 +146,26 @@ export function activeCampaignDefaultGetAllProperties (resource: string, operati
},
{
displayName: 'Limit',
name: 'limit',
name: 'limit',
type: 'number',
displayOptions: {
show: {
operation: [
operation,
],
resource: [
resource,
],
returnAll: [
false,
],
show: {
operation: [
operation,
],
resource: [
resource,
],
returnAll: [
false,
],
},
},
},
typeOptions: {
minValue: 1,
maxValue: 500,
},
default: 100,
typeOptions: {
minValue: 1,
maxValue: 500,
},
default: 100,
description: 'How many results to return.',
},
{
@ -185,7 +183,7 @@ export function activeCampaignDefaultGetAllProperties (resource: string, operati
},
},
default: true,
description: 'When set to true a simplify version of the response will be used else the raw data will be used',
description: 'When set to true a simplify version of the response will be used else the raw data.',
},
];
}