mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-10 06:34:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Fix credential display bug (#3372)

Browse source 
* ⚡ Filter credentials by version

* ⚡ Reuse helper
This commit is contained in:
Iván Ovejero 2022-05-27 17:07:14 +02:00 committed by GitHub
parent 96a109a57c
commit ed69c3cc18
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
packages/editor-ui/src/components/mixins/workflowHelpers.ts
View file

@ -330,24 +330,25 @@ export const workflowHelpers = mixins(
if (node.credentials !== undefined && nodeType.credentials !== undefined) {
const saveCredenetials: INodeCredentials = {};
for (const nodeCredentialTypeName of Object.keys(node.credentials)) {
// todo revert to only set actually used credentials on workflow
// if (this.hasProxyAuth(node) || Object.keys(node.parameters).includes('genericAuthType')) {
// saveCredenetials[nodeCredentialTypeName] = node.credentials[nodeCredentialTypeName];
// continue;
// }
if (this.hasProxyAuth(node) || Object.keys(node.parameters).includes('genericAuthType')) {
saveCredenetials[nodeCredentialTypeName] = node.credentials[nodeCredentialTypeName];
continue;
}
// const credentialTypeDescription = nodeType.credentials
// .find((credentialTypeDescription) => credentialTypeDescription.name === nodeCredentialTypeName);
const credentialTypeDescription = nodeType.credentials
// filter out credentials with same name in different node versions
.filter((c) => this.displayParameter(node.parameters, c, '', node))
.find((c) => c.name === nodeCredentialTypeName);
// if (credentialTypeDescription === undefined) {
// // Credential type is not know so do not save
// continue;
// }
if (credentialTypeDescription === undefined) {
// Credential type is not know so do not save
continue;
}
// if (this.displayParameter(node.parameters, credentialTypeDescription, '', node) === false) {
// // Credential should not be displayed so do also not save
// continue;
// }
if (this.displayParameter(node.parameters, credentialTypeDescription, '', node) === false) {
// Credential should not be displayed so do also not save
continue;
}
saveCredenetials[nodeCredentialTypeName] = node.credentials[nodeCredentialTypeName];
}