mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(If Node): Update copy for type conversion parameter (#10769)

Browse source
This commit is contained in:
Elias Meire 2024-09-11 14:12:33 +02:00 committed by GitHub
parent 6fa1919ca8
commit ee5fbc543c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 15 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
packages/design-system/src/components/N8nInputLabel/InputLabel.vue
View file

@ -185,10 +185,19 @@ const addTargetBlank = (html: string) =>
} }
:root .tooltipPopper { :root .tooltipPopper {
line-height: var(--font-line-height-compact);
max-width: 400px; max-width: 400px;
li { li {
margin-left: var(--spacing-s); margin-left: var(--spacing-s);
} }
code {
color: var(--color-text-dark);
font-size: var(--font-size-3xs);
background: var(--color-background-medium);
padding: var(--spacing-5xs);
border-radius: var(--border-radius-base);
}
} }
</style> </style>

2
packages/nodes-base/utils/constants.ts
View file

@ -4,4 +4,4 @@ export const NODE_RAN_MULTIPLE_TIMES_WARNING =
export const LOCALHOST = '127.0.0.1'; export const LOCALHOST = '127.0.0.1';
export const ENABLE_LESS_STRICT_TYPE_VALIDATION = export const ENABLE_LESS_STRICT_TYPE_VALIDATION =
"Try changing the type of comparison. Alternatively you can enable 'Convert Value Types'."; "Try changing the type of comparison. Alternatively you can enable 'Convert types where required'.";

5
packages/nodes-base/utils/descriptions.ts
View file

@ -34,8 +34,9 @@ export const returnAllOrLimit: INodeProperties[] = [
]; ];
export const looseTypeValidationProperty: INodeProperties = { export const looseTypeValidationProperty: INodeProperties = {
displayName: 'Convert Value Types', displayName: 'Convert types where required',
description: 'Whether to try casting value types based on the selected operator', description:
'If the type of an expression doesn\'t match the type of the comparison, n8n will try to cast the expression to the required type. E.g. for booleans <code>"false"</code> or <code>0</code> will be cast to <code>false</code>',
name: 'looseTypeValidation', name: 'looseTypeValidation',
type: 'boolean', type: 'boolean',
default: true, default: true,

4
packages/workflow/src/NodeParameters/FilterParameter.ts
View file

@ -109,7 +109,7 @@ function parseFilterConditionValues(
const getTypeDescription = (isStrict: boolean) => { const getTypeDescription = (isStrict: boolean) => {
if (isStrict) if (isStrict)
return "Try changing the type of comparison. Alternatively you can enable 'Convert Value Types'."; return "Try changing the type of comparison. Alternatively you can enable 'Convert types where required'.";
return 'Try changing the type of the comparison.'; return 'Try changing the type of the comparison.';
}; };
@ -135,7 +135,7 @@ function parseFilterConditionValues(
return ` return `
<p>Try either:</p> <p>Try either:</p>
<ol> <ol>
<li>Enabling 'Convert Value Types'</li> <li>Enabling 'Convert types where required'</li>
<li>Converting the ${valuePosition} field to ${expectedType}${suggestFunction}</li> <li>Converting the ${valuePosition} field to ${expectedType}${suggestFunction}</li>
</ol> </ol>
`; `;