mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-12 21:37:32 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: wrap external hooks calls in a try catch (#4208)

Browse source
This commit is contained in:
Omar Ajoue 2022-09-27 11:43:56 +02:00 committed by GitHub
parent 80e2d65933
commit ef378f2cf2
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
packages/cli/src/ExternalHooks.ts
View file

@ -2,6 +2,7 @@
/* eslint-disable import/no-dynamic-require */
/* eslint-disable no-restricted-syntax */
// eslint-disable-next-line import/no-cycle
import { LoggerProxy } from 'n8n-workflow';
import { Db, IExternalHooksClass, IExternalHooksFileData, IExternalHooksFunctions } from '.';
import config from '../config';
@ -87,8 +88,13 @@ class ExternalHooksClass implements IExternalHooksClass {
}
for (const externalHookFunction of this.externalHooks[hookName]) {
// eslint-disable-next-line no-await-in-loop
await externalHookFunction.apply(externalHookFunctions, hookParameters);
try {
// eslint-disable-next-line no-await-in-loop
await externalHookFunction.apply(externalHookFunctions, hookParameters);
} catch (error) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/restrict-template-expressions
LoggerProxy.info(`Error in external hook "${hookName}": ${error.message}`);
}
}
}