mirror of
https://github.com/n8n-io/n8n.git
synced 2024-09-20 23:07:32 -07:00
⚡ Small improvements to Asana Node
This commit is contained in:
parent
c6ef0ea079
commit
ef53eddb6c
|
@ -20,7 +20,7 @@ import {
|
||||||
|
|
||||||
import * as moment from 'moment-timezone';
|
import * as moment from 'moment-timezone';
|
||||||
|
|
||||||
import {
|
import {
|
||||||
snakeCase,
|
snakeCase,
|
||||||
} from 'change-case';
|
} from 'change-case';
|
||||||
|
|
||||||
|
@ -1709,7 +1709,7 @@ export class Asana implements INodeType {
|
||||||
endpoint = `/tasks/${taskId}/subtasks`;
|
endpoint = `/tasks/${taskId}/subtasks`;
|
||||||
|
|
||||||
Object.assign(qs, options);
|
Object.assign(qs, options);
|
||||||
|
|
||||||
if (qs.opt_fields) {
|
if (qs.opt_fields) {
|
||||||
const fields = qs.opt_fields as string[];
|
const fields = qs.opt_fields as string[];
|
||||||
if (fields.includes('*')) {
|
if (fields.includes('*')) {
|
||||||
|
@ -1774,48 +1774,48 @@ export class Asana implements INodeType {
|
||||||
responseData = await asanaApiRequest.call(this, requestMethod, endpoint, body, qs);
|
responseData = await asanaApiRequest.call(this, requestMethod, endpoint, body, qs);
|
||||||
|
|
||||||
responseData = responseData.data;
|
responseData = responseData.data;
|
||||||
|
|
||||||
} else if (operation === 'getAll') {
|
} else if (operation === 'getAll') {
|
||||||
// ----------------------------------
|
// ----------------------------------
|
||||||
// task:getAll
|
// task:getAll
|
||||||
// ----------------------------------
|
// ----------------------------------
|
||||||
|
|
||||||
const filters = this.getNodeParameter('filters', i) as IDataObject;
|
const filters = this.getNodeParameter('filters', i) as IDataObject;
|
||||||
const returnAll = this.getNodeParameter('returnAll', i) as boolean;
|
const returnAll = this.getNodeParameter('returnAll', i) as boolean;
|
||||||
|
|
||||||
requestMethod = 'GET';
|
|
||||||
endpoint = `/tasks`;
|
|
||||||
|
|
||||||
Object.assign(qs, filters);
|
requestMethod = 'GET';
|
||||||
|
endpoint = `/tasks`;
|
||||||
|
|
||||||
if (qs.opt_fields) {
|
Object.assign(qs, filters);
|
||||||
const fields = qs.opt_fields as string[];
|
|
||||||
if (fields.includes('*')) {
|
|
||||||
qs.opt_fields = getTaskFields().map((e) => snakeCase(e)).join(',');
|
|
||||||
} else {
|
|
||||||
qs.opt_fields = (qs.opt_fields as string[]).join(',');
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
if (qs.modified_since) {
|
if (qs.opt_fields) {
|
||||||
qs.modified_since = moment.tz(qs.modified_since as string, timezone).format();
|
const fields = qs.opt_fields as string[];
|
||||||
}
|
if (fields.includes('*')) {
|
||||||
|
qs.opt_fields = getTaskFields().map((e) => snakeCase(e)).join(',');
|
||||||
if (qs.completed_since) {
|
|
||||||
qs.completed_since = moment.tz(qs.completed_since as string, timezone).format();
|
|
||||||
}
|
|
||||||
|
|
||||||
if (returnAll) {
|
|
||||||
responseData = await asanaApiRequestAllItems.call(this, requestMethod, endpoint, body, qs);
|
|
||||||
|
|
||||||
} else {
|
} else {
|
||||||
qs.limit = this.getNodeParameter('limit', i) as boolean;
|
qs.opt_fields = (qs.opt_fields as string[]).join(',');
|
||||||
|
|
||||||
responseData = await asanaApiRequest.call(this, requestMethod, endpoint, body, qs);
|
|
||||||
|
|
||||||
responseData = responseData.data;
|
|
||||||
}
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if (qs.modified_since) {
|
||||||
|
qs.modified_since = moment.tz(qs.modified_since as string, timezone).format();
|
||||||
|
}
|
||||||
|
|
||||||
|
if (qs.completed_since) {
|
||||||
|
qs.completed_since = moment.tz(qs.completed_since as string, timezone).format();
|
||||||
|
}
|
||||||
|
|
||||||
|
if (returnAll) {
|
||||||
|
responseData = await asanaApiRequestAllItems.call(this, requestMethod, endpoint, body, qs);
|
||||||
|
|
||||||
|
} else {
|
||||||
|
qs.limit = this.getNodeParameter('limit', i) as boolean;
|
||||||
|
|
||||||
|
responseData = await asanaApiRequest.call(this, requestMethod, endpoint, body, qs);
|
||||||
|
|
||||||
|
responseData = responseData.data;
|
||||||
|
}
|
||||||
|
|
||||||
} else if (operation === 'move') {
|
} else if (operation === 'move') {
|
||||||
// ----------------------------------
|
// ----------------------------------
|
||||||
// task:move
|
// task:move
|
||||||
|
|
Loading…
Reference in a new issue