mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

chore: Clean up some code (#12287)

Browse source
This commit is contained in:
Tomi Turtiainen 2024-12-30 16:32:09 +02:00 committed by GitHub
parent 67145b98e2
commit f08db47077
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 16 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
packages/@n8n/task-runner/src/js-task-runner/__tests__/js-task-runner.test.ts
View file

@ -633,6 +633,7 @@ describe('JsTaskRunner', () => {
), ),
}); });
// Assert
expect(rpcCallSpy).toHaveBeenCalledWith('1', group.method, group.expectedParams); expect(rpcCallSpy).toHaveBeenCalledWith('1', group.method, group.expectedParams);
}); });
@ -661,26 +662,22 @@ describe('JsTaskRunner', () => {
describe('unsupported methods', () => { describe('unsupported methods', () => {
for (const unsupportedFunction of UNSUPPORTED_HELPER_FUNCTIONS) { for (const unsupportedFunction of UNSUPPORTED_HELPER_FUNCTIONS) {
it(`should throw an error if ${unsupportedFunction} is used in runOnceForAllItems`, async () => { it(`should throw an error if ${unsupportedFunction} is used in runOnceForAllItems`, async () => {
// Act // Act & Assert
await expect( await expect(
async () => executeForAllItems({
await executeForAllItems({ code: `${unsupportedFunction}()`,
code: `${unsupportedFunction}()`, inputItems,
inputItems, }),
}),
).rejects.toThrow(UnsupportedFunctionError); ).rejects.toThrow(UnsupportedFunctionError);
}); });
it(`should throw an error if ${unsupportedFunction} is used in runOnceForEachItem`, async () => { it(`should throw an error if ${unsupportedFunction} is used in runOnceForEachItem`, async () => {
// Act // Act & Assert
await expect( await expect(
async () => executeForEachItem({
await executeForEachItem({ code: `${unsupportedFunction}()`,
code: `${unsupportedFunction}()`, inputItems,
inputItems, }),
}),
).rejects.toThrow(UnsupportedFunctionError); ).rejects.toThrow(UnsupportedFunctionError);
}); });
} }

6
packages/@n8n/task-runner/src/js-task-runner/js-task-runner.ts
View file

@ -42,8 +42,8 @@ import { createRequireResolver } from './require-resolver';
import { validateRunForAllItemsOutput, validateRunForEachItemOutput } from './result-validation'; import { validateRunForAllItemsOutput, validateRunForEachItemOutput } from './result-validation';
import { DataRequestResponseReconstruct } from '../data-request/data-request-response-reconstruct'; import { DataRequestResponseReconstruct } from '../data-request/data-request-response-reconstruct';
export interface RPCCallObject { export interface RpcCallObject {
[name: string]: ((...args: unknown[]) => Promise<unknown>) | RPCCallObject; [name: string]: ((...args: unknown[]) => Promise<unknown>) | RpcCallObject;
} }
export interface JSExecSettings { export interface JSExecSettings {
@ -449,7 +449,7 @@ export class JsTaskRunner extends TaskRunner {
} }
private buildRpcCallObject(taskId: string) { private buildRpcCallObject(taskId: string) {
const rpcObject: RPCCallObject = {}; const rpcObject: RpcCallObject = {};
for (const rpcMethod of EXPOSED_RPC_METHODS) { for (const rpcMethod of EXPOSED_RPC_METHODS) {
set( set(

4
packages/core/test/SerializedBuffer.test.ts
View file

@ -7,7 +7,7 @@ const validSerializedBuffer: SerializedBuffer = {
data: [65, 66, 67], // Corresponds to 'ABC' in ASCII data: [65, 66, 67], // Corresponds to 'ABC' in ASCII
}; };
describe('serializedBufferToBuffer', () => { describe('toBuffer', () => {
it('should convert a SerializedBuffer to a Buffer', () => { it('should convert a SerializedBuffer to a Buffer', () => {
const buffer = toBuffer(validSerializedBuffer); const buffer = toBuffer(validSerializedBuffer);
expect(buffer).toBeInstanceOf(Buffer); expect(buffer).toBeInstanceOf(Buffer);
@ -43,7 +43,7 @@ describe('isSerializedBuffer', () => {
}); });
}); });
describe('Integration: serializedBufferToBuffer and isSerializedBuffer', () => { describe('Integration: toBuffer and isSerializedBuffer', () => {
it('should correctly validate and convert a SerializedBuffer', () => { it('should correctly validate and convert a SerializedBuffer', () => {
if (isSerializedBuffer(validSerializedBuffer)) { if (isSerializedBuffer(validSerializedBuffer)) {
const buffer = toBuffer(validSerializedBuffer); const buffer = toBuffer(validSerializedBuffer);