mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: Fix problem saving workflow when tags disabled (#3792)

Browse source 
* ⚡ Add @AfterLoad nullCheck for WorkflowEntity tags

* ⚡ Make tags optional in Entity

* Fix workflows api typing issue

Co-authored-by: Omar Ajoue <krynble@gmail.com>
This commit is contained in:
brianinoa 2022-08-02 17:18:57 +02:00 committed by GitHub
parent 2cab8e7779
commit f0dddaa2a5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
packages/cli/src/Interfaces.ts
View file

@ -144,7 +144,7 @@ export interface IWorkflowBase extends IWorkflowBaseWorkflow {
// Almost identical to editor-ui.Interfaces.ts
export interface IWorkflowDb extends IWorkflowBase {
id: number | string;
tags: ITagDb[];
tags?: ITagDb[];
}
export interface IWorkflowToImport extends IWorkflowBase {

2
packages/cli/src/Server.ts
View file

@ -993,7 +993,7 @@ class App {
);
}
if (updatedWorkflow.tags.length && tags?.length) {
if (updatedWorkflow.tags?.length && tags?.length) {
updatedWorkflow.tags = TagHelpers.sortByRequestOrder(updatedWorkflow.tags, {
requestOrder: tags,
});

2
packages/cli/src/api/workflows.api.ts
View file

@ -69,7 +69,7 @@ workflowsController.post(
throw new ResponseHelper.ResponseError('Failed to save workflow');
}
if (tagIds && !config.getEnv('workflowTagsDisabled')) {
if (tagIds && !config.getEnv('workflowTagsDisabled') && savedWorkflow.tags) {
savedWorkflow.tags = TagHelpers.sortByRequestOrder(savedWorkflow.tags, {
requestOrder: tagIds,
});

2
packages/cli/src/databases/entities/WorkflowEntity.ts
View file

@ -112,7 +112,7 @@ export class WorkflowEntity implements IWorkflowDb {
referencedColumnName: 'id',
},
})
tags: TagEntity[];
tags?: TagEntity[];
@OneToMany(() => SharedWorkflow, (sharedWorkflow) => sharedWorkflow.workflow)
shared: SharedWorkflow[];