mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(Google Sheets Node): Fix exception when no Values to Send are set

Browse source
This commit is contained in:
Michael Kret 2023-01-04 15:54:24 +02:00 committed by GitHub
parent 9615253155
commit f1184ccab5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 16 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/appendOrUpdate.operation.ts
View file

@ -253,9 +253,14 @@ export async function execute(
} else { } else {
const valueToMatchOn = this.getNodeParameter('valueToMatchOn', i) as string; const valueToMatchOn = this.getNodeParameter('valueToMatchOn', i) as string;
const fields = ( const valuesToSend = this.getNodeParameter('fieldsUi.values', i, []) as IDataObject[];
(this.getNodeParameter('fieldsUi.values', i, {}) as IDataObject[]) || [] if (!valuesToSend?.length) {
).reduce((acc, entry) => { throw new NodeOperationError(
this.getNode(),
"At least one value has to be added under 'Values to Send'",
);
}
const fields = valuesToSend.reduce((acc, entry) => {
if (entry.column === 'newColumn') { if (entry.column === 'newColumn') {
const columnName = entry.columnName as string; const columnName = entry.columnName as string;

11
packages/nodes-base/nodes/Google/Sheet/v2/actions/sheet/update.operation.ts
View file

@ -251,9 +251,14 @@ export async function execute(
} else { } else {
const valueToMatchOn = this.getNodeParameter('valueToMatchOn', i) as string; const valueToMatchOn = this.getNodeParameter('valueToMatchOn', i) as string;
const fields = ( const valuesToSend = this.getNodeParameter('fieldsUi.values', i, []) as IDataObject[];
(this.getNodeParameter('fieldsUi.values', i, {}) as IDataObject[]) || [] if (!valuesToSend?.length) {
).reduce((acc, entry) => { throw new NodeOperationError(
this.getNode(),
"At least one value has to be added under 'Values to Send'",
);
}
const fields = valuesToSend.reduce((acc, entry) => {
if (entry.column === 'newColumn') { if (entry.column === 'newColumn') {
const columnName = entry.columnName as string; const columnName = entry.columnName as string;