mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-24 20:24:05 -08:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(editor): Fix frontend project roles (#9901)

Browse source
This commit is contained in:
Csaba Tuncsik 2024-07-02 14:17:09 +02:00 committed by GitHub
parent af69c80bf5
commit f229577209
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 110 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

108
packages/editor-ui/src/stores/roles.store.test.ts Normal file
View file

@ -0,0 +1,108 @@
import { useRolesStore } from '@/stores/roles.store';
import * as rolesApi from '@/api/roles.api';
import { createPinia, setActivePinia } from 'pinia';
let rolesStore: ReturnType<typeof useRolesStore>;
describe('roles store', () => {
beforeEach(() => {
setActivePinia(createPinia());
rolesStore = useRolesStore();
});
it('should use project roles defined in the frontend in correct order', async () => {
vi.spyOn(rolesApi, 'getRoles').mockResolvedValue({
global: [],
credential: [],
workflow: [],
project: [
{
name: 'Project Admin',
role: 'project:admin',
scopes: [
'workflow:create',
'workflow:read',
'workflow:update',
'workflow:delete',
'workflow:list',
'workflow:execute',
'workflow:move',
'credential:create',
'credential:read',
'credential:update',
'credential:delete',
'credential:list',
'credential:move',
'project:list',
'project:read',
'project:update',
'project:delete',
],
licensed: true,
},
{
name: 'Project Owner',
role: 'project:personalOwner',
scopes: [
'workflow:create',
'workflow:read',
'workflow:update',
'workflow:delete',
'workflow:list',
'workflow:execute',
'workflow:share',
'workflow:move',
'credential:create',
'credential:read',
'credential:update',
'credential:delete',
'credential:list',
'credential:share',
'credential:move',
'project:list',
'project:read',
],
licensed: true,
},
{
name: 'Project Editor',
role: 'project:editor',
scopes: [
'workflow:create',
'workflow:read',
'workflow:update',
'workflow:delete',
'workflow:list',
'workflow:execute',
'credential:create',
'credential:read',
'credential:update',
'credential:delete',
'credential:list',
'project:list',
'project:read',
],
licensed: true,
},
{
name: 'Project Viewer',
role: 'project:viewer',
scopes: [
'credential:list',
'credential:read',
'project:list',
'project:read',
'workflow:list',
'workflow:read',
],
licensed: true,
},
],
});
await rolesStore.fetchRoles();
expect(rolesStore.processedProjectRoles.map(({ role }) => role)).toEqual([
'project:editor',
'project:admin',
]);
});
});

4
packages/editor-ui/src/stores/roles.store.ts
View file

@ -20,12 +20,12 @@ export const useRolesStore = defineStore('roles', () => {
const processedProjectRoles = computed<RoleMap['project']>(() =>
roles.value.project
.filter((role) => projectRoleOrderMap.value.has(role.role))
.sort(
(a, b) =>
(projectRoleOrderMap.value.get(a.role) ?? 0) -
(projectRoleOrderMap.value.get(b.role) ?? 0),
)
.filter((role) => role.role !== 'project:personalOwner'),
),
);
const processedCredentialRoles = computed<RoleMap['credential']>(() =>