mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 21:07:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

test(Redis Node): Continue on Fail for Redis (no-changelog) (#12190)
Some checks are pending
Test Master / install-and-build (push) Waiting to run
Details
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Details
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Details
Test Master / Lint (push) Blocked by required conditions
Details
Test Master / Notify Slack on failure (push) Blocked by required conditions
Details

Browse source
This commit is contained in:
Dana 2024-12-16 18:39:38 +01:00 committed by GitHub
parent b8eae5f28a
commit f44e4904c8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 122 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

132
packages/nodes-base/nodes/Redis/test/Redis.node.test.ts
View file

@ -1,6 +1,6 @@
import { mock } from 'jest-mock-extended';
import type { RedisClientType } from '@redis/client';
import type { IExecuteFunctions } from 'n8n-workflow';
import { mock } from 'jest-mock-extended';
import { NodeOperationError, type IExecuteFunctions } from 'n8n-workflow';
const mockClient = mock<RedisClientType>();
const createClient = jest.fn().mockReturnValue(mockClient);
@ -12,7 +12,11 @@ import { setupRedisClient } from '../utils';
describe('Redis Node', () => {
const node = new Redis();
beforeEach(() => jest.clearAllMocks());
beforeEach(() => {
createClient.mockReturnValue(mockClient);
});
afterEach(() => jest.resetAllMocks());
describe('setupRedisClient', () => {
it('should not configure TLS by default', () => {
@ -54,14 +58,23 @@ describe('Redis Node', () => {
describe('operations', () => {
const thisArg = mock<IExecuteFunctions>({});
const mockCredential = {
host: 'redis',
port: 1234,
database: 0,
password: 'random',
};
beforeEach(() => {
setupRedisClient({
host: 'redis.domain',
port: 1234,
database: 0,
ssl: true,
});
thisArg.getCredentials.calledWith('redis').mockResolvedValue(mockCredential);
const mockCredential = {
host: 'redis',
port: 1234,
database: 0,
password: 'random',
};
thisArg.getCredentials.calledWith('redis').mockResolvedValue(mockCredential);
});
afterEach(() => {
expect(createClient).toHaveBeenCalled();
@ -119,6 +132,28 @@ master_failover_state:no-failover
master_failover_state: 'no-failover',
});
});
it('should continue and return an error when continue on fail is enabled and an error is thrown', async () => {
thisArg.getNodeParameter.calledWith('operation', 0).mockReturnValue('info');
thisArg.continueOnFail.mockReturnValue(true);
mockClient.info.mockRejectedValue(new Error('Redis error'));
const output = await node.execute.call(thisArg);
expect(mockClient.info).toHaveBeenCalled();
expect(output[0][0].json).toEqual({ error: 'Redis error' });
});
it('should throw an error when continue on fail is disabled and an error is thrown', async () => {
thisArg.getNodeParameter.calledWith('operation', 0).mockReturnValue('info');
thisArg.continueOnFail.mockReturnValue(false);
mockClient.info.mockRejectedValue(new Error('Redis error'));
await expect(node.execute.call(thisArg)).rejects.toThrow(NodeOperationError);
expect(mockClient.info).toHaveBeenCalled();
expect(mockClient.quit).toHaveBeenCalled();
});
});
describe('delete operation', () => {
@ -132,6 +167,33 @@ master_failover_state:no-failover
expect(mockClient.del).toHaveBeenCalledWith('key1');
expect(output[0][0].json).toEqual({ x: 1 });
});
it('should continue and return an error when continue on fail is enabled and an error is thrown', async () => {
thisArg.getInputData.mockReturnValue([{ json: { x: 1 } }]);
thisArg.getNodeParameter.calledWith('operation', 0).mockReturnValue('delete');
thisArg.getNodeParameter.calledWith('key', 0).mockReturnValue('key1');
thisArg.continueOnFail.mockReturnValue(true);
mockClient.del.mockRejectedValue(new Error('Redis error'));
const output = await node.execute.call(thisArg);
expect(mockClient.del).toHaveBeenCalled();
expect(output[0][0].json).toEqual({ error: 'Redis error' });
});
it('should throw an error when continue on fail is disabled and an error is thrown', async () => {
thisArg.getInputData.mockReturnValue([{ json: { x: 1 } }]);
thisArg.getNodeParameter.calledWith('operation', 0).mockReturnValue('delete');
thisArg.getNodeParameter.calledWith('key', 0).mockReturnValue('key1');
mockClient.del.mockRejectedValue(new Error('Redis error'));
await expect(node.execute.call(thisArg)).rejects.toThrow(NodeOperationError);
expect(mockClient.del).toHaveBeenCalled();
expect(mockClient.quit).toHaveBeenCalled();
});
});
describe('get operation', () => {
@ -172,6 +234,31 @@ master_failover_state:no-failover
},
});
});
it('should continue and return an error when continue on fail is enabled and an error is thrown', async () => {
thisArg.getNodeParameter.calledWith('keyType', 0).mockReturnValue('automatic');
thisArg.continueOnFail.mockReturnValue(true);
mockClient.type.calledWith('key1').mockResolvedValue('string');
mockClient.get.mockRejectedValue(new Error('Redis error'));
const output = await node.execute.call(thisArg);
expect(mockClient.get).toHaveBeenCalled();
expect(output[0][0].json).toEqual({ error: 'Redis error' });
});
it('should throw an error when continue on fail is disabled and an error is thrown', async () => {
thisArg.getNodeParameter.calledWith('keyType', 0).mockReturnValue('automatic');
mockClient.type.calledWith('key1').mockResolvedValue('string');
mockClient.get.mockRejectedValue(new Error('Redis error'));
await expect(node.execute.call(thisArg)).rejects.toThrow(NodeOperationError);
expect(mockClient.get).toHaveBeenCalled();
expect(mockClient.quit).toHaveBeenCalled();
});
});
describe('keys operation', () => {
@ -200,6 +287,31 @@ master_failover_state:no-failover
expect(mockClient.keys).toHaveBeenCalledWith('key*');
expect(output[0][0].json).toEqual({ key1: 'value1', key2: 'value2' });
});
it('should continue and return an error when continue on fail is enabled and an error is thrown', async () => {
thisArg.continueOnFail.mockReturnValue(true);
thisArg.getNodeParameter.calledWith('getValues', 0).mockReturnValue(true);
mockClient.type.mockResolvedValue('string');
mockClient.get.mockRejectedValue(new Error('Redis error'));
const output = await node.execute.call(thisArg);
expect(mockClient.get).toHaveBeenCalled();
expect(output[0][0].json).toEqual({ error: 'Redis error' });
});
it('should throw an error when continue on fail is disabled and an error is thrown', async () => {
thisArg.getNodeParameter.calledWith('getValues', 0).mockReturnValue(true);
mockClient.type.mockResolvedValue('string');
mockClient.get.mockRejectedValue(new Error('Redis error'));
await expect(node.execute.call(thisArg)).rejects.toThrow(NodeOperationError);
expect(mockClient.get).toHaveBeenCalled();
expect(mockClient.quit).toHaveBeenCalled();
});
});
});
});