mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-01-11 21:07:28 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

🐛 Remove Test-Webhook also if checkExists fails

Browse source
This commit is contained in:
Jan Oberhauser 2020-08-27 13:37:17 +02:00
parent 685aa2cf82
commit f56960f0cc
1 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
packages/core/src/ActiveWebhooks.ts
View file

@ -50,11 +50,13 @@ export class ActiveWebhooks {
// it gets called // it gets called
this.webhookUrls[webhookKey] = webhookData; this.webhookUrls[webhookKey] = webhookData;
try {
const webhookExists = await workflow.runWebhookMethod('checkExists', webhookData, NodeExecuteFunctions, mode, this.testWebhooks); const webhookExists = await workflow.runWebhookMethod('checkExists', webhookData, NodeExecuteFunctions, mode, this.testWebhooks);
if (webhookExists === false) { if (webhookExists === false) {
// If webhook does not exist yet create it // If webhook does not exist yet create it
try {
await workflow.runWebhookMethod('create', webhookData, NodeExecuteFunctions, mode, this.testWebhooks); await workflow.runWebhookMethod('create', webhookData, NodeExecuteFunctions, mode, this.testWebhooks);
}
} catch (error) { } catch (error) {
// If there was a problem unregister the webhook again // If there was a problem unregister the webhook again
delete this.webhookUrls[webhookKey]; delete this.webhookUrls[webhookKey];
@ -62,8 +64,6 @@ export class ActiveWebhooks {
throw error; throw error;
} }
}
this.workflowWebhooks[webhookData.workflowId].push(webhookData); this.workflowWebhooks[webhookData.workflowId].push(webhookData);
} }