mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡ Prevent request on empty update

Browse source
This commit is contained in:
Iván Ovejero 2021-05-11 10:12:43 +02:00
parent 939f9cf5d8
commit f5ff3d212b
2 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
packages/nodes-base/nodes/Zoho/GenericFunctions.ts
View file

@ -11,6 +11,7 @@ import {
IDataObject,
ILoadOptionsFunctions,
NodeApiError,
NodeOperationError,
} from 'n8n-workflow';
import {
@ -118,6 +119,13 @@ export async function handleListing(
return responseData.slice(0, limit);
}
export function throwOnEmptyUpdate(this: IExecuteFunctions, resource: string) {
throw new NodeOperationError(
this.getNode(),
`Please enter at least one field to update for the ${resource}.`,
);
}
// ----------------------------------------
// required field adjusters
// ----------------------------------------

21
packages/nodes-base/nodes/Zoho/ZohoCrm.node.ts
View file

@ -22,6 +22,7 @@ import {
adjustSalesOrderPayload,
adjustVendorPayload,
handleListing,
throwOnEmptyUpdate,
toLoadOptions,
zohoApiRequest,
zohoApiRequestAllItems,
@ -267,6 +268,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustAccountPayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const accountId = this.getNodeParameter('accountId', i);
@ -343,6 +346,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustContactPayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const contactId = this.getNodeParameter('contactId', i);
@ -418,6 +423,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustDealPayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const dealId = this.getNodeParameter('dealId', i);
@ -496,6 +503,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustInvoicePayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const invoiceId = this.getNodeParameter('invoiceId', i);
@ -571,6 +580,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustLeadPayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const leadId = this.getNodeParameter('leadId', i);
@ -646,6 +657,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, updateFields);
} else {
throwOnEmptyUpdate.call(this, resource);
}
const productId = this.getNodeParameter('productId', i);
@ -726,6 +739,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustPurchaseOrderPayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const purchaseOrderId = this.getNodeParameter('purchaseOrderId', i);
@ -803,6 +818,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustQuotePayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const quoteId = this.getNodeParameter('quoteId', i);
@ -882,6 +899,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustSalesOrderPayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const salesOrderId = this.getNodeParameter('salesOrderId', i);
@ -958,6 +977,8 @@ export class ZohoCrm implements INodeType {
if (Object.keys(updateFields).length) {
Object.assign(body, adjustVendorPayload(updateFields));
} else {
throwOnEmptyUpdate.call(this, resource);
}
const vendorId = this.getNodeParameter('vendorId', i);