mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-11-09 22:24:05 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(editor): Make sticky node content parameter non require to support empty stickies (#9192)

Browse source
This commit is contained in:
Ricardo Espinoza 2024-04-23 21:56:33 -04:00 committed by GitHub
parent 93f23ea4b2
commit f6142ff275
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 17 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
cypress/e2e/25-stickies.cy.ts
View file

@ -243,6 +243,20 @@ describe('Canvas Actions', () => {
expect($el).to.have.css('z-index', '-158');
});
});
it('Empty sticky should not error when activating workflow', () => {
workflowPage.actions.addSticky();
workflowPage.getters.stickies().should('have.length', 1);
workflowPage.getters.stickies().dblclick();
workflowPage.actions.clearSticky();
workflowPage.actions.addNodeToCanvas('Schedule Trigger');
workflowPage.actions.activateWorkflow();
});
});
type Position = {

3
cypress/pages/workflow.ts
View file

@ -419,6 +419,9 @@ export class WorkflowPage extends BasePage {
editSticky: (content: string) => {
this.getters.stickies().dblclick().find('textarea').clear().type(content).type('{esc}');
},
clearSticky: () => {
this.getters.stickies().dblclick().find('textarea').clear().type('{esc}');
},
shouldHaveWorkflowName: (name: string) => {
this.getters.workflowNameInputContainer().invoke('attr', 'title').should('include', name);
},

1
packages/nodes-base/nodes/StickyNote/StickyNote.node.ts
View file

@ -26,7 +26,6 @@ export class StickyNote implements INodeType {
displayName: 'Content',
name: 'content',
type: 'string',
required: true,
default:
"## I'm a note \n**Double click** to edit me. [Guide](https://docs.n8n.io/workflows/sticky-notes/)",
},