From f744d7c100be68669d9a3efd0033dd371a3cfaf7 Mon Sep 17 00:00:00 2001 From: Ria Scholz <123465523+mariaremote@users.noreply.github.com> Date: Wed, 7 Aug 2024 12:48:14 +0200 Subject: [PATCH] feat(MySQL Node): Return decimal types as numbers (#10313) --- .../nodes/MySql/v2/actions/common.descriptions.ts | 10 ++++++++++ packages/nodes-base/nodes/MySql/v2/transport/index.ts | 5 +++++ 2 files changed, 15 insertions(+) diff --git a/packages/nodes-base/nodes/MySql/v2/actions/common.descriptions.ts b/packages/nodes-base/nodes/MySql/v2/actions/common.descriptions.ts index 67a1eda87e..12f8ffd242 100644 --- a/packages/nodes-base/nodes/MySql/v2/actions/common.descriptions.ts +++ b/packages/nodes-base/nodes/MySql/v2/actions/common.descriptions.ts @@ -134,6 +134,16 @@ export const optionsCollection: INodeProperties = { show: { '/operation': ['select', 'executeQuery'] }, }, }, + { + displayName: 'Output Decimals as Numbers', + name: 'decimalNumbers', + type: 'boolean', + default: false, + description: 'Whether to output DECIMAL types as numbers instead of strings', + displayOptions: { + show: { '/operation': ['select', 'executeQuery'] }, + }, + }, { displayName: 'Priority', name: 'priority', diff --git a/packages/nodes-base/nodes/MySql/v2/transport/index.ts b/packages/nodes-base/nodes/MySql/v2/transport/index.ts index cbb373a524..f9e50fcb8f 100644 --- a/packages/nodes-base/nodes/MySql/v2/transport/index.ts +++ b/packages/nodes-base/nodes/MySql/v2/transport/index.ts @@ -24,6 +24,7 @@ export async function createPool( password: credentials.password, multipleStatements: true, supportBigNumbers: true, + decimalNumbers: false, }; if (credentials.ssl) { @@ -55,6 +56,10 @@ export async function createPool( connectionOptions.bigNumberStrings = true; } + if (options?.decimalNumbers === true) { + connectionOptions.decimalNumbers = true; + } + if (!credentials.sshTunnel) { return mysql2.createPool(connectionOptions); } else {