address design feedback

This commit is contained in:
Mutasem Aldmour 2024-11-12 17:24:04 +01:00
parent 9e70cb1b05
commit f746da04ac
No known key found for this signature in database
GPG key ID: 3DFA8122BB7FD6B8
4 changed files with 27 additions and 15 deletions

View file

@ -1225,6 +1225,19 @@ function onSearchClear() {
document.dispatchEvent(new KeyboardEvent('keyup', { key: '/' })); document.dispatchEvent(new KeyboardEvent('keyup', { key: '/' }));
} }
function getExecutionLinkLabel(task: ITaskMetadata) {
if (task.parentExecution) {
return i18n.baseText('runData.openParentExecution', {
interpolate: { id: task.parentExecution.executionId },
});
}
if (task.subExecution) {
return i18n.baseText('runData.openSubExecution', {
interpolate: { id: task.subExecution.executionId },
});
}
}
defineExpose({ enterEditMode }); defineExpose({ enterEditMode });
</script> </script>
@ -1398,11 +1411,7 @@ defineExpose({ enterEditMode });
@click.stop="openRelatedExecution(activeTaskMetadata, displayMode)" @click.stop="openRelatedExecution(activeTaskMetadata, displayMode)"
> >
<N8nIcon icon="external-link-alt" size="xsmall" /> <N8nIcon icon="external-link-alt" size="xsmall" />
{{ {{ getExecutionLinkLabel(activeTaskMetadata) }}
activeTaskMetadata.parentExecution
? $locale.baseText('runData.openParentExecution')
: $locale.baseText('runData.openSubExecution')
}}
</a> </a>
</div> </div>
@ -1483,11 +1492,7 @@ defineExpose({ enterEditMode });
@click.stop="openRelatedExecution(activeTaskMetadata, displayMode)" @click.stop="openRelatedExecution(activeTaskMetadata, displayMode)"
> >
<N8nIcon icon="external-link-alt" size="xsmall" /> <N8nIcon icon="external-link-alt" size="xsmall" />
{{ {{ getExecutionLinkLabel(activeTaskMetadata) }}
activeTaskMetadata.parentExecution
? $locale.baseText('runData.openParentExecution')
: $locale.baseText('runData.openSubExecution')
}}
</a> </a>
</div> </div>

View file

@ -142,7 +142,13 @@ const outputError = computed(() => {
<li v-if="runMeta?.subExecution"> <li v-if="runMeta?.subExecution">
<a @click.stop="openRelatedExecution(runMeta, 'ai')"> <a @click.stop="openRelatedExecution(runMeta, 'ai')">
<N8nIcon icon="external-link-alt" size="xsmall" /> <N8nIcon icon="external-link-alt" size="xsmall" />
{{ $locale.baseText('runData.openSubExecution') }} {{
$locale.baseText('runData.openSubExecution', {
interpolate: {
id: runMeta.subExecution?.executionId,
},
})
}}
</a> </a>
</li> </li>
<li v-if="(consumedTokensSum?.totalTokens ?? 0) > 0" :class="$style.tokensUsage"> <li v-if="(consumedTokensSum?.totalTokens ?? 0) > 0" :class="$style.tokensUsage">

View file

@ -551,6 +551,7 @@ watch(focusedMappableInput, (curr) => {
}, },
}) })
" "
placement="left"
:hide-after="0" :hide-after="0"
> >
<N8nIconButton <N8nIconButton

View file

@ -959,7 +959,7 @@
"ndv.output.branch": "Branch", "ndv.output.branch": "Branch",
"ndv.output.executing": "Executing node...", "ndv.output.executing": "Executing node...",
"ndv.output.items": "{count} item | {count} items", "ndv.output.items": "{count} item | {count} items",
"ndv.output.andSubExecutions": ", {count} sub execution | , {count} sub executions", "ndv.output.andSubExecutions": ", {count} sub-execution | , {count} sub-executions",
"ndv.output.noOutputData.message": "n8n stops executing the workflow when a node has no output data. You can change this default behaviour via", "ndv.output.noOutputData.message": "n8n stops executing the workflow when a node has no output data. You can change this default behaviour via",
"ndv.output.noOutputData.message.settings": "Settings", "ndv.output.noOutputData.message.settings": "Settings",
"ndv.output.noOutputData.message.settingsOption": "> \"Always Output Data\".", "ndv.output.noOutputData.message.settingsOption": "> \"Always Output Data\".",
@ -1558,8 +1558,8 @@
"resourceMapper.addAllFields": "Add All {fieldWord}", "resourceMapper.addAllFields": "Add All {fieldWord}",
"resourceMapper.removeAllFields": "Remove All {fieldWord}", "resourceMapper.removeAllFields": "Remove All {fieldWord}",
"resourceMapper.refreshFieldList": "Refresh {fieldWord} List", "resourceMapper.refreshFieldList": "Refresh {fieldWord} List",
"runData.openSubExecution": "Open Sub Execution", "runData.openSubExecution": "Inspect Sub-Execution {id}",
"runData.openParentExecution": "Open Parent Execution", "runData.openParentExecution": "Inspect Parent Execution {id}",
"runData.emptyItemHint": "This is an item, but it's empty.", "runData.emptyItemHint": "This is an item, but it's empty.",
"runData.emptyArray": "[empty array]", "runData.emptyArray": "[empty array]",
"runData.emptyString": "[empty]", "runData.emptyString": "[empty]",
@ -1607,7 +1607,7 @@
"runData.showBinaryData": "View", "runData.showBinaryData": "View",
"runData.startTime": "Start Time", "runData.startTime": "Start Time",
"runData.table": "Table", "runData.table": "Table",
"runData.table.inspectSubExecution": "Inspect sub execution {id}", "runData.table.inspectSubExecution": "Inspect sub-execution {id}",
"runData.pindata.learnMore": "Learn more", "runData.pindata.learnMore": "Learn more",
"runData.pindata.thisDataIsPinned": "This data is pinned.", "runData.pindata.thisDataIsPinned": "This data is pinned.",
"runData.pindata.unpin": "Unpin", "runData.pindata.unpin": "Unpin",