mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-12-25 04:34:06 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Notion Node): Handle empty values correctly for Notion selects + multi selects (#7383)

Browse source 
Github issue / Community forum post (link here to close automatically):
This commit is contained in:
Elias Meire 2023-10-09 18:04:41 +02:00 committed by GitHub
parent 8187be1b7d
commit fbcd1d40ed
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
packages/nodes-base/nodes/Notion/GenericFunctions.ts
View file

@ -320,6 +320,10 @@ function getDateFormat(includeTime: boolean) {
return '';
}
function isEmpty(value: unknown): boolean {
return value === undefined || value === null || value === '';
}
function getPropertyKeyValue(
this: IExecuteFunctions,
value: any,
@ -368,7 +372,16 @@ function getPropertyKeyValue(
};
break;
case 'multi_select':
if (isEmpty(value.multiSelectValue)) {
result = {
type: 'multi_select',
multi_select: [],
};
break;
}
const multiSelectValue = value.multiSelectValue;
result = {
type: 'multi_select',
multi_select: (Array.isArray(multiSelectValue)
@ -403,6 +416,14 @@ function getPropertyKeyValue(
};
break;
case 'select':
if (isEmpty(value.selectValue)) {
result = {
type: 'select',
select: null,
};
break;
}
result = {
type: 'select',
select: version === 1 ? { id: value.selectValue } : { name: value.selectValue },