mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-03-05 20:50:17 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(Webhook Node): Fix handling of form-data files (#8256)

Browse source
This commit is contained in:
कारतोफ्फेलस्क्रिप्ट™ 2024-01-08 14:33:14 +01:00 committed by GitHub
parent b6c42cc084
commit fc2903096e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 39 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
packages/nodes-base/nodes/Webhook/Webhook.node.ts
View file

@ -99,7 +99,7 @@ export class Webhook extends Node {
const options = context.getNodeParameter('options', {}) as {
binaryData: boolean;
ignoreBots: boolean;
rawBody: Buffer;
rawBody: boolean;
responseData?: string;
};
const req = context.getRequestObject();
@ -225,7 +225,7 @@ export class Webhook extends Node {
},
};
if (files?.length) {
if (files && Object.keys(files).length) {
returnItem.binary = {};
}

38
packages/nodes-base/nodes/Webhook/test/Webhook.test.ts
View file

@ -1,4 +1,40 @@
import type { Request } from 'express';
import type { IWebhookFunctions } from 'n8n-workflow';
import { mock } from 'jest-mock-extended';
import { Webhook } from '../Webhook.node';
import { testWorkflows, getWorkflowFilenames } from '@test/nodes/Helpers';
const workflows = getWorkflowFilenames(__dirname);
describe('Test Webhook Node', () => testWorkflows(workflows));
describe('Test Webhook Node', () => {
testWorkflows(workflows);
describe('handleFormData', () => {
const node = new Webhook();
const context = mock<IWebhookFunctions>({
nodeHelpers: mock(),
});
context.getNodeParameter.calledWith('options').mockReturnValue({});
const req = mock<Request>();
req.contentType = 'multipart/form-data';
context.getRequestObject.mockReturnValue(req);
it('should handle when no files are present', async () => {
req.body = {
files: {},
};
const returnData = await node.webhook(context);
expect(returnData.workflowData?.[0][0].binary).toBeUndefined();
expect(context.nodeHelpers.copyBinaryFile).not.toHaveBeenCalled();
});
it('should handle when files are present', async () => {
req.body = {
files: { file1: {} },
};
const returnData = await node.webhook(context);
expect(returnData.workflowData?.[0][0].binary).not.toBeUndefined();
expect(context.nodeHelpers.copyBinaryFile).toHaveBeenCalled();
});
});
});