refactor(core): Fix push message type inference (#12331)

packages/cli/src/collaboration/collaboration.service.ts

@@ -99,6 +99,6 @@ export class CollaborationService {
 			collaborators: activeCollaborators,
 		};
 
-		this.push.sendToUsers('collaboratorsChanged', msgData, userIds);
+		this.push.sendToUsers({ type: 'collaboratorsChanged', data: msgData }, userIds);
 	}
 }

packages/cli/src/controllers/community-packages.controller.ts

@@ -115,9 +115,12 @@ export class CommunityPackagesController {
 
 		// broadcast to connected frontends that node list has been updated
 		installedPackage.installedNodes.forEach((node) => {
-			this.push.broadcast('reloadNodeType', {
+			this.push.broadcast({
-				name: node.type,
+				type: 'reloadNodeType',
-				version: node.latestVersion,
+				data: {
+					name: node.type,
+					version: node.latestVersion,
+				},
 			});
 		});
 
@@ -206,9 +209,12 @@ export class CommunityPackagesController {
 
 		// broadcast to connected frontends that node list has been updated
 		installedPackage.installedNodes.forEach((node) => {
-			this.push.broadcast('removeNodeType', {
+			this.push.broadcast({
-				name: node.type,
+				type: 'removeNodeType',
-				version: node.latestVersion,
+				data: {
+					name: node.type,
+					version: node.latestVersion,
+				},
 			});
 		});
 
@@ -246,16 +252,22 @@ export class CommunityPackagesController {
 
 			// broadcast to connected frontends that node list has been updated
 			previouslyInstalledPackage.installedNodes.forEach((node) => {
-				this.push.broadcast('removeNodeType', {
+				this.push.broadcast({
-					name: node.type,
+					type: 'removeNodeType',
-					version: node.latestVersion,
+					data: {
+						name: node.type,
+						version: node.latestVersion,
+					},
 				});
 			});
 
 			newInstalledPackage.installedNodes.forEach((node) => {
-				this.push.broadcast('reloadNodeType', {
+				this.push.broadcast({
-					name: node.name,
+					type: 'reloadNodeType',
-					version: node.latestVersion,
+					data: {
+						name: node.name,
+						version: node.latestVersion,
+					},
 				});
 			});
 
@@ -272,9 +284,12 @@ export class CommunityPackagesController {
 			return newInstalledPackage;
 		} catch (error) {
 			previouslyInstalledPackage.installedNodes.forEach((node) => {
-				this.push.broadcast('removeNodeType', {
+				this.push.broadcast({
-					name: node.type,
+					type: 'removeNodeType',
-					version: node.latestVersion,
+					data: {
+						name: node.type,
+						version: node.latestVersion,
+					},
 				});
 			});
 

packages/cli/src/controllers/e2e.controller.ts

@@ -1,4 +1,4 @@
-import type { PushPayload, PushType } from '@n8n/api-types';
+import type { PushMessage } from '@n8n/api-types';
 import { Request } from 'express';
 import Container from 'typedi';
 import { v4 as uuid } from 'uuid';
@@ -58,14 +58,12 @@ type ResetRequest = Request<
 	}
 >;
 
-type PushRequest<T extends PushType> = Request<
+type PushRequest = Request<
 	{},
 	{},
 	{
-		type: T;
 		pushRef: string;
-		data: PushPayload<T>;
+	} & PushMessage
-	}
 >;
 
 @RestController('/e2e')
@@ -144,8 +142,9 @@ export class E2EController {
 	}
 
 	@Post('/push', { skipAuth: true })
-	async pushSend(req: PushRequest<any>) {
+	async pushSend(req: PushRequest) {
-		this.push.broadcast(req.body.type, req.body.data);
+		const { pushRef: _, ...pushMsg } = req.body;
+		this.push.broadcast(pushMsg);
 	}
 
 	@Patch('/feature', { skipAuth: true })

packages/cli/src/events/maps/pub-sub.event-map.ts

@@ -1,4 +1,4 @@
-import type { PushType, WorkerStatus } from '@n8n/api-types';
+import type { PushMessage, WorkerStatus } from '@n8n/api-types';
 
 import type { IWorkflowDb } from '@/interfaces';
 
@@ -64,9 +64,7 @@ export type PubSubCommandMap = {
 		errorMessage: string;
 	};
 
-	'relay-execution-lifecycle-event': {
+	'relay-execution-lifecycle-event': PushMessage & {
-		type: PushType;
-		args: Record<string, unknown>;
 		pushRef: string;
 	};
 

packages/cli/src/executions/execution-recovery.service.ts

@@ -49,7 +49,7 @@ export class ExecutionRecoveryService {
 
 		this.push.once('editorUiConnected', async () => {
 			await sleep(1000);
-			this.push.broadcast('executionRecovered', { executionId });
+			this.push.broadcast({ type: 'executionRecovered', data: { executionId } });
 		});
 
 		return amendedExecution;

packages/cli/src/load-nodes-and-credentials.ts

@@ -520,7 +520,7 @@ export class LoadNodesAndCredentials {
 				loader.reset();
 				await loader.loadAll();
 				await this.postProcessLoaders();
-				push.broadcast('nodeDescriptionUpdated', {});
+				push.broadcast({ type: 'nodeDescriptionUpdated', data: {} });
 			}, 100);
 
 			const toWatch = loader.isLazyLoaded

packages/cli/src/push/__tests__/websocket.push.test.ts

@@ -73,7 +73,7 @@ describe('WebSocketPush', () => {
 	it('sends data to one connection', () => {
 		webSocketPush.add(pushRef1, userId, mockWebSocket1);
 		webSocketPush.add(pushRef2, userId, mockWebSocket2);
-		webSocketPush.sendToOne(pushMessage.type, pushMessage.data, pushRef1);
+		webSocketPush.sendToOne(pushMessage, pushRef1);
 
 		expect(mockWebSocket1.send).toHaveBeenCalledWith(expectedMsg);
 		expect(mockWebSocket2.send).not.toHaveBeenCalled();
@@ -82,7 +82,7 @@ describe('WebSocketPush', () => {
 	it('sends data to all connections', () => {
 		webSocketPush.add(pushRef1, userId, mockWebSocket1);
 		webSocketPush.add(pushRef2, userId, mockWebSocket2);
-		webSocketPush.sendToAll(pushMessage.type, pushMessage.data);
+		webSocketPush.sendToAll(pushMessage);
 
 		expect(mockWebSocket1.send).toHaveBeenCalledWith(expectedMsg);
 		expect(mockWebSocket2.send).toHaveBeenCalledWith(expectedMsg);
@@ -101,7 +101,7 @@ describe('WebSocketPush', () => {
 	it('sends data to all users connections', () => {
 		webSocketPush.add(pushRef1, userId, mockWebSocket1);
 		webSocketPush.add(pushRef2, userId, mockWebSocket2);
-		webSocketPush.sendToUsers(pushMessage.type, pushMessage.data, [userId]);
+		webSocketPush.sendToUsers(pushMessage, [userId]);
 
 		expect(mockWebSocket1.send).toHaveBeenCalledWith(expectedMsg);
 		expect(mockWebSocket2.send).toHaveBeenCalledWith(expectedMsg);

packages/cli/src/push/abstract.push.ts

@@ -1,4 +1,4 @@
-import type { PushPayload, PushType } from '@n8n/api-types';
+import type { PushMessage } from '@n8n/api-types';
 import { ErrorReporter } from 'n8n-core';
 import { assert, jsonStringify } from 'n8n-workflow';
 import { Service } from 'typedi';
@@ -69,7 +69,7 @@ export abstract class AbstractPush<Connection> extends TypedEmitter<AbstractPush
 		delete this.userIdByPushRef[pushRef];
 	}
 
-	private sendTo<Type extends PushType>(type: Type, data: PushPayload<Type>, pushRefs: string[]) {
+	private sendTo({ type, data }: PushMessage, pushRefs: string[]) {
 		this.logger.debug(`Pushed to frontend: ${type}`, {
 			dataType: type,
 			pushRefs: pushRefs.join(', '),
@@ -90,30 +90,26 @@ export abstract class AbstractPush<Connection> extends TypedEmitter<AbstractPush
 		}
 	}
 
-	sendToAll<Type extends PushType>(type: Type, data: PushPayload<Type>) {
+	sendToAll(pushMsg: PushMessage) {
-		this.sendTo(type, data, Object.keys(this.connections));
+		this.sendTo(pushMsg, Object.keys(this.connections));
 	}
 
-	sendToOne<Type extends PushType>(type: Type, data: PushPayload<Type>, pushRef: string) {
+	sendToOne(pushMsg: PushMessage, pushRef: string) {
 		if (this.connections[pushRef] === undefined) {
 			this.logger.error(`The session "${pushRef}" is not registered.`, { pushRef });
 			return;
 		}
 
-		this.sendTo(type, data, [pushRef]);
+		this.sendTo(pushMsg, [pushRef]);
 	}
 
-	sendToUsers<Type extends PushType>(
+	sendToUsers(pushMsg: PushMessage, userIds: Array<User['id']>) {
-		type: Type,
-		data: PushPayload<Type>,
-		userIds: Array<User['id']>,
-	) {
 		const { connections } = this;
 		const userPushRefs = Object.keys(connections).filter((pushRef) =>
 			userIds.includes(this.userIdByPushRef[pushRef]),
 		);
 
-		this.sendTo(type, data, userPushRefs);
+		this.sendTo(pushMsg, userPushRefs);
 	}
 
 	closeAllConnections() {

packages/cli/src/push/index.ts

@@ -1,4 +1,4 @@
-import type { PushPayload, PushType } from '@n8n/api-types';
+import type { PushMessage } from '@n8n/api-types';
 import type { Application } from 'express';
 import { ServerResponse } from 'http';
 import type { Server } from 'http';
@@ -81,11 +81,11 @@ export class Push extends TypedEmitter<PushEvents> {
 		this.emit('editorUiConnected', pushRef);
 	}
 
-	broadcast<Type extends PushType>(type: Type, data: PushPayload<Type>) {
+	broadcast(pushMsg: PushMessage) {
-		this.backend.sendToAll(type, data);
+		this.backend.sendToAll(pushMsg);
 	}
 
-	send<Type extends PushType>(type: Type, data: PushPayload<Type>, pushRef: string) {
+	send(pushMsg: PushMessage, pushRef: string) {
 		/**
 		 * Multi-main setup: In a manual webhook execution, the main process that
 		 * handles a webhook might not be the same as the main process that created
@@ -95,20 +95,16 @@ export class Push extends TypedEmitter<PushEvents> {
 		if (this.instanceSettings.isMultiMain && !this.backend.hasPushRef(pushRef)) {
 			void this.publisher.publishCommand({
 				command: 'relay-execution-lifecycle-event',
-				payload: { type, args: data, pushRef },
+				payload: { ...pushMsg, pushRef },
 			});
 			return;
 		}
 
-		this.backend.sendToOne(type, data, pushRef);
+		this.backend.sendToOne(pushMsg, pushRef);
 	}
 
-	sendToUsers<Type extends PushType>(
+	sendToUsers(pushMsg: PushMessage, userIds: Array<User['id']>) {
-		type: Type,
+		this.backend.sendToUsers(pushMsg, userIds);
-		data: PushPayload<Type>,
-		userIds: Array<User['id']>,
-	) {
-		this.backend.sendToUsers(type, data, userIds);
 	}
 
 	@OnShutdown()

packages/cli/src/scaling/__tests__/pubsub-handler.test.ts

@@ -620,7 +620,10 @@ describe('PubSubHandler', () => {
 				expect(activeWorkflowManager.add).toHaveBeenCalledWith(workflowId, 'activate', undefined, {
 					shouldPublish: false,
 				});
-				expect(push.broadcast).toHaveBeenCalledWith('workflowActivated', { workflowId });
+				expect(push.broadcast).toHaveBeenCalledWith({
+					type: 'workflowActivated',
+					data: { workflowId },
+				});
 				expect(publisher.publishCommand).toHaveBeenCalledWith({
 					command: 'display-workflow-activation',
 					payload: { workflowId },
@@ -680,7 +683,10 @@ describe('PubSubHandler', () => {
 				expect(activeWorkflowManager.removeWorkflowTriggersAndPollers).toHaveBeenCalledWith(
 					workflowId,
 				);
-				expect(push.broadcast).toHaveBeenCalledWith('workflowDeactivated', { workflowId });
+				expect(push.broadcast).toHaveBeenCalledWith({
+					type: 'workflowDeactivated',
+					data: { workflowId },
+				});
 				expect(publisher.publishCommand).toHaveBeenCalledWith({
 					command: 'display-workflow-deactivation',
 					payload: { workflowId },
@@ -735,7 +741,10 @@ describe('PubSubHandler', () => {
 
 				eventService.emit('display-workflow-activation', { workflowId });
 
-				expect(push.broadcast).toHaveBeenCalledWith('workflowActivated', { workflowId });
+				expect(push.broadcast).toHaveBeenCalledWith({
+					type: 'workflowActivated',
+					data: { workflowId },
+				});
 			});
 
 			it('should handle `display-workflow-deactivation` event', () => {
@@ -758,7 +767,10 @@ describe('PubSubHandler', () => {
 
 				eventService.emit('display-workflow-deactivation', { workflowId });
 
-				expect(push.broadcast).toHaveBeenCalledWith('workflowDeactivated', { workflowId });
+				expect(push.broadcast).toHaveBeenCalledWith({
+					type: 'workflowDeactivated',
+					data: { workflowId },
+				});
 			});
 
 			it('should handle `display-workflow-activation-error` event', () => {
@@ -782,9 +794,12 @@ describe('PubSubHandler', () => {
 
 				eventService.emit('display-workflow-activation-error', { workflowId, errorMessage });
 
-				expect(push.broadcast).toHaveBeenCalledWith('workflowFailedToActivate', {
+				expect(push.broadcast).toHaveBeenCalledWith({
-					workflowId,
+					type: 'workflowFailedToActivate',
-					errorMessage,
+					data: {
+						workflowId,
+						errorMessage,
+					},
 				});
 			});
 
@@ -806,15 +821,21 @@ describe('PubSubHandler', () => {
 
 				const pushRef = 'test-push-ref';
 				const type = 'executionStarted';
-				const args = { testArg: 'value' };
+				const data = {
+					executionId: '123',
+					mode: 'webhook' as const,
+					startedAt: new Date(),
+					workflowId: '456',
+					flattedRunData: '[]',
+				};
 
 				push.getBackend.mockReturnValue(
 					mock<WebSocketPush>({ hasPushRef: jest.fn().mockReturnValue(true) }),
 				);
 
-				eventService.emit('relay-execution-lifecycle-event', { type, args, pushRef });
+				eventService.emit('relay-execution-lifecycle-event', { type, data, pushRef });
 
-				expect(push.send).toHaveBeenCalledWith(type, args, pushRef);
+				expect(push.send).toHaveBeenCalledWith({ type, data }, pushRef);
 			});
 
 			it('should handle `clear-test-webhooks` event', () => {
@@ -868,9 +889,12 @@ describe('PubSubHandler', () => {
 
 				eventService.emit('response-to-get-worker-status', workerStatus);
 
-				expect(push.broadcast).toHaveBeenCalledWith('sendWorkerStatusMessage', {
+				expect(push.broadcast).toHaveBeenCalledWith({
-					workerId: workerStatus.senderId,
+					type: 'sendWorkerStatusMessage',
-					status: workerStatus,
+					data: {
+						workerId: workerStatus.senderId,
+						status: workerStatus,
+					},
 				});
 			});
 		});

packages/cli/src/scaling/pubsub/publisher.service.ts

@@ -65,10 +65,10 @@ export class Publisher {
 		const metadata: LogMetadata = { msg: msg.command, channel: 'n8n.commands' };
 
 		if (msg.command === 'relay-execution-lifecycle-event') {
-			const { args, type } = msg.payload;
+			const { data, type } = msg.payload;
 			msgName += ` (${type})`;
 			metadata.type = type;
-			metadata.executionId = args.executionId;
+			if ('executionId' in data) metadata.executionId = data.executionId;
 		}
 
 		this.logger.debug(`Published pubsub msg: ${msgName}`, metadata);

packages/cli/src/scaling/pubsub/pubsub-handler.ts

@@ -59,9 +59,12 @@ export class PubSubHandler {
 					...this.commonHandlers,
 					...this.multiMainHandlers,
 					'response-to-get-worker-status': async (payload) =>
-						this.push.broadcast('sendWorkerStatusMessage', {
+						this.push.broadcast({
-							workerId: payload.senderId,
+							type: 'sendWorkerStatusMessage',
-							status: payload,
+							data: {
+								workerId: payload.senderId,
+								status: payload,
+							},
 						}),
 				});
 
@@ -113,7 +116,7 @@ export class PubSubHandler {
 					shouldPublish: false, // prevent leader from re-publishing message
 				});
 
-				this.push.broadcast('workflowActivated', { workflowId });
+				this.push.broadcast({ type: 'workflowActivated', data: { workflowId } });
 
 				await this.publisher.publishCommand({
 					command: 'display-workflow-activation',
@@ -125,7 +128,10 @@ export class PubSubHandler {
 
 				await this.workflowRepository.update(workflowId, { active: false });
 
-				this.push.broadcast('workflowFailedToActivate', { workflowId, errorMessage: message });
+				this.push.broadcast({
+					type: 'workflowFailedToActivate',
+					data: { workflowId, errorMessage: message },
+				});
 
 				await this.publisher.publishCommand({
 					command: 'display-workflow-activation-error',
@@ -139,7 +145,7 @@ export class PubSubHandler {
 			await this.activeWorkflowManager.removeActivationError(workflowId);
 			await this.activeWorkflowManager.removeWorkflowTriggersAndPollers(workflowId);
 
-			this.push.broadcast('workflowDeactivated', { workflowId });
+			this.push.broadcast({ type: 'workflowDeactivated', data: { workflowId } });
 
 			// instruct followers to show workflow deactivation in UI
 			await this.publisher.publishCommand({
@@ -148,15 +154,15 @@ export class PubSubHandler {
 			});
 		},
 		'display-workflow-activation': async ({ workflowId }) =>
-			this.push.broadcast('workflowActivated', { workflowId }),
+			this.push.broadcast({ type: 'workflowActivated', data: { workflowId } }),
 		'display-workflow-deactivation': async ({ workflowId }) =>
-			this.push.broadcast('workflowDeactivated', { workflowId }),
+			this.push.broadcast({ type: 'workflowDeactivated', data: { workflowId } }),
 		'display-workflow-activation-error': async ({ workflowId, errorMessage }) =>
-			this.push.broadcast('workflowFailedToActivate', { workflowId, errorMessage }),
+			this.push.broadcast({ type: 'workflowFailedToActivate', data: { workflowId, errorMessage } }),
-		'relay-execution-lifecycle-event': async ({ type, args, pushRef }) => {
+		'relay-execution-lifecycle-event': async ({ pushRef, ...pushMsg }) => {
 			if (!this.push.getBackend().hasPushRef(pushRef)) return;
 
-			this.push.send(type, args, pushRef);
+			this.push.send(pushMsg, pushRef);
 		},
 		'clear-test-webhooks': async ({ webhookKey, workflowEntity, pushRef }) => {
 			if (!this.push.getBackend().hasPushRef(pushRef)) return;

packages/cli/src/scaling/pubsub/subscriber.service.ts

@@ -95,10 +95,10 @@ export class Subscriber {
 		const metadata: LogMetadata = { msg: msgName, channel };
 
 		if ('command' in msg && msg.command === 'relay-execution-lifecycle-event') {
-			const { args, type } = msg.payload;
+			const { data, type } = msg.payload;
 			msgName += ` (${type})`;
 			metadata.type = type;
-			metadata.executionId = args.executionId;
+			if ('executionId' in data) metadata.executionId = data.executionId;
 		}
 
 		this.logger.debug(`Received pubsub msg: ${msgName}`, metadata);

packages/cli/src/webhooks/test-webhooks.ts

@@ -142,8 +142,7 @@ export class TestWebhooks implements IWebhookManager {
 				// Inform editor-ui that webhook got received
 				if (pushRef !== undefined) {
 					this.push.send(
-						'testWebhookReceived',
+						{ type: 'testWebhookReceived', data: { workflowId: webhook?.workflowId, executionId } },
-						{ workflowId: webhook?.workflowId, executionId },
 						pushRef,
 					);
 				}
@@ -354,7 +353,7 @@ export class TestWebhooks implements IWebhookManager {
 
 			if (pushRef !== undefined) {
 				try {
-					this.push.send('testWebhookDeleted', { workflowId }, pushRef);
+					this.push.send({ type: 'testWebhookDeleted', data: { workflowId } }, pushRef);
 				} catch {
 					// Could not inform editor, probably is not connected anymore. So simply go on.
 				}

packages/cli/src/workflow-execute-additional-data.ts

@@ -2,7 +2,7 @@
 /* eslint-disable @typescript-eslint/no-use-before-define */
 /* eslint-disable @typescript-eslint/no-unsafe-member-access */
 /* eslint-disable @typescript-eslint/no-unsafe-assignment */
-import type { PushType } from '@n8n/api-types';
+import type { PushMessage, PushType } from '@n8n/api-types';
 import { GlobalConfig } from '@n8n/config';
 import { stringify } from 'flatted';
 import { ErrorReporter, WorkflowExecute, isObjectLiteral } from 'n8n-core';
@@ -262,7 +262,7 @@ function hookFunctionsPush(): IWorkflowExecuteHooks {
 					workflowId: this.workflowData.id,
 				});
 
-				pushInstance.send('nodeExecuteBefore', { executionId, nodeName }, pushRef);
+				pushInstance.send({ type: 'nodeExecuteBefore', data: { executionId, nodeName } }, pushRef);
 			},
 		],
 		nodeExecuteAfter: [
@@ -279,7 +279,10 @@ function hookFunctionsPush(): IWorkflowExecuteHooks {
 					workflowId: this.workflowData.id,
 				});
 
-				pushInstance.send('nodeExecuteAfter', { executionId, nodeName, data }, pushRef);
+				pushInstance.send(
+					{ type: 'nodeExecuteAfter', data: { executionId, nodeName, data } },
+					pushRef,
+				);
 			},
 		],
 		workflowExecuteBefore: [
@@ -296,17 +299,19 @@ function hookFunctionsPush(): IWorkflowExecuteHooks {
 					return;
 				}
 				pushInstance.send(
-					'executionStarted',
 					{
-						executionId,
+						type: 'executionStarted',
-						mode: this.mode,
+						data: {
-						startedAt: new Date(),
+							executionId,
-						retryOf: this.retryOf,
+							mode: this.mode,
-						workflowId,
+							startedAt: new Date(),
-						workflowName,
+							retryOf: this.retryOf,
-						flattedRunData: data?.resultData.runData
+							workflowId,
-							? stringify(data.resultData.runData)
+							workflowName,
-							: stringify({}),
+							flattedRunData: data?.resultData.runData
+								? stringify(data.resultData.runData)
+								: stringify({}),
+						},
 					},
 					pushRef,
 				);
@@ -326,12 +331,11 @@ function hookFunctionsPush(): IWorkflowExecuteHooks {
 
 				const { status } = fullRunData;
 				if (status === 'waiting') {
-					pushInstance.send('executionWaiting', { executionId }, pushRef);
+					pushInstance.send({ type: 'executionWaiting', data: { executionId } }, pushRef);
 				} else {
 					const rawData = stringify(fullRunData.data);
 					pushInstance.send(
-						'executionFinished',
+						{ type: 'executionFinished', data: { executionId, workflowId, status, rawData } },
-						{ executionId, workflowId, status, rawData },
 						pushRef,
 					);
 				}
@@ -974,7 +978,7 @@ export function sendDataToUI(type: PushType, data: IDataObject | IDataObject[])
 	// Push data to session which started workflow
 	try {
 		const pushInstance = Container.get(Push);
-		pushInstance.send(type, data, pushRef);
+		pushInstance.send({ type, data } as PushMessage, pushRef);
 	} catch (error) {
 		const logger = Container.get(Logger);
 		logger.warn(`There was a problem sending message to UI: ${error.message}`);

packages/cli/test/integration/collaboration/collaboration.service.test.ts

@@ -78,37 +78,41 @@ describe('CollaborationService', () => {
 			// Assert
 			expect(sendToUsersSpy).toHaveBeenNthCalledWith(
 				1,
-				'collaboratorsChanged',
 				{
-					collaborators: [
+					type: 'collaboratorsChanged',
-						{
+					data: {
-							lastSeen: expect.any(String),
+						collaborators: [
-							user: owner.toIUser(),
+							{
-						},
+								lastSeen: expect.any(String),
-					],
+								user: owner.toIUser(),
-					workflowId: workflow.id,
+							},
+						],
+						workflowId: workflow.id,
+					},
 				},
 				[owner.id],
 			);
 			expect(sendToUsersSpy).toHaveBeenNthCalledWith(
 				2,
-				'collaboratorsChanged',
 				{
-					collaborators: expect.arrayContaining([
+					type: 'collaboratorsChanged',
-						expect.objectContaining({
+					data: {
-							lastSeen: expect.any(String),
+						collaborators: expect.arrayContaining([
-							user: expect.objectContaining({
+							expect.objectContaining({
-								id: owner.id,
+								lastSeen: expect.any(String),
+								user: expect.objectContaining({
+									id: owner.id,
+								}),
 							}),
-						}),
+							expect.objectContaining({
-						expect.objectContaining({
+								lastSeen: expect.any(String),
-							lastSeen: expect.any(String),
+								user: expect.objectContaining({
-							user: expect.objectContaining({
+									id: memberWithAccess.id,
-								id: memberWithAccess.id,
+								}),
 							}),
-						}),
+						]),
-					]),
+						workflowId: workflow.id,
-					workflowId: workflow.id,
+					},
 				},
 				[owner.id, memberWithAccess.id],
 			);
@@ -151,17 +155,19 @@ describe('CollaborationService', () => {
 
 			// Assert
 			expect(sendToUsersSpy).toHaveBeenCalledWith(
-				'collaboratorsChanged',
 				{
-					collaborators: expect.arrayContaining([
+					type: 'collaboratorsChanged',
-						expect.objectContaining({
+					data: {
-							lastSeen: expect.any(String),
+						collaborators: expect.arrayContaining([
-							user: expect.objectContaining({
+							expect.objectContaining({
-								id: memberWithAccess.id,
+								lastSeen: expect.any(String),
+								user: expect.objectContaining({
+									id: memberWithAccess.id,
+								}),
 							}),
-						}),
+						]),
-					]),
+						workflowId: workflow.id,
-					workflowId: workflow.id,
+					},
 				},
 				[memberWithAccess.id],
 			);