mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-02-21 02:56:40 -08:00
Code Issues Actions Packages Projects Releases Wiki Activity

⚡ Minor WooCommerceTrigger-Node improvements

Browse source
This commit is contained in:
Jan Oberhauser 2020-01-29 20:06:47 -08:00
parent cf1978aafa
commit fe9170e62f
2 changed files with 17 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
packages/nodes-base/nodes/WooCommerce/GenericFunctions.ts
View file

@ -14,10 +14,10 @@ export async function woocommerceApiRequest(this: IHookFunctions | IExecuteFunct
if (credentials === undefined) {
throw new Error('No credentials got returned!');
}
const base64credentials = Buffer.from(`${credentials.consumerKey}:${credentials.consumerSecret}`).toString('base64');
let options: OptionsWithUri = {
headers: {
Authorization: `Basic ${base64credentials}`,
auth: {
user: credentials.consumerKey as string,
password: credentials.consumerSecret as string,
},
method,
qs,
@ -32,7 +32,18 @@ export async function woocommerceApiRequest(this: IHookFunctions | IExecuteFunct
try {
return await this.helpers.request!(options);
} catch (error) {
throw new Error('WooCommerce Error: ' + error);
if (error.statusCode === 401) {
// Return a clear error
throw new Error('The WooCommerce credentials are not valid!');
}
if (error.response.body && error.response.body.message) {
// Try to return the error prettier
throw new Error(`WooCommerce Error [${error.statusCode}]: ${error.response.body.message}`);
}
// If that data does not exist for some reason return the actual error
throw new Error('WooCommerce Error: ' + error.message);
}
}
@ -45,5 +56,5 @@ export async function woocommerceApiRequest(this: IHookFunctions | IExecuteFunct
*/
export function getAutomaticSecret(credentials: ICredentialDataDecryptedObject) {
const data = `${credentials.consumerKey},${credentials.consumerSecret}`;
return createHash('md5').update(data).digest("hex");
return createHash('md5').update(data).digest('hex');
}

2
packages/nodes-base/nodes/WooCommerce/WooCommerceTrigger.node.ts
View file

@ -176,6 +176,6 @@ export class WooCommerceTrigger implements INodeType {
workflowData: [
this.helpers.returnJsonArray(req.body),
],
}
};
}
}