mudhorn/n8n
1
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2024-09-19 22:37:31 -07:00
Code Issues Actions 2 Packages Projects Releases Wiki Activity
9871 commits 917 branches 1568 tags 341 MiB
Commit graph

9871 commits

This branch
This branch
All branches
Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™ dbfd617ace
ci: Dry-run publishing to avoid partial publishing (no-changelog) (#7859) 2023-11-29 12:03:19 +01:00
Milorad FIlipović 8b99384367
fix(editor): Fix cloud plan data loading on instance (#7841) 
Moving cloud hooks and store initialization logic after users are
authenticated. This will ensure user local account is available when
their cloud plan data is being fetched.
This PR also adds the following error handling improvements:
- Added error handling to the same initialization logic
- Fixed empty `catch` clauses inside the cloud store which caused it to
silently fail and complicated debugging of this bug
 2023-11-29 10:51:15 +01:00
Jon 90bb6ba417
feat(Slack Node): Add support for getting the profile of a user (#7829) 
Github issue / Community forum post (link here to close automatically):
https://github.com/n8n-io/n8n/issues/7825

This adds support for getting a users profile which returns different
data to the existing user info (Get) operation we have.

Test Workflow
```
{
  "meta": {
    "instanceId": "8c8c5237b8e37b006a7adce87f4369350c58e41f3ca9de16196d3197f69eabcd"
  },
  "nodes": [
    {
      "parameters": {},
      "id": "69f437fb-9962-4d51-91bb-0ef4b3827e49",
      "name": "When clicking \"Execute Workflow\"",
      "type": "n8n-nodes-base.manualTrigger",
      "typeVersion": 1,
      "position": [
        880,
        380
      ]
    },
    {
      "parameters": {
        "resource": "user",
        "user": {
          "__rl": true,
          "value": "U035F563JSW",
          "mode": "list",
          "cachedResultName": "jonathan"
        }
      },
      "id": "826828db-598b-40c7-b085-5b01f2c10d73",
      "name": "Get Info",
      "type": "n8n-nodes-base.slack",
      "typeVersion": 2.1,
      "position": [
        1120,
        260
      ],
      "credentials": {
        "slackApi": {
          "id": "E4DnXIyNuRxi5GSz",
          "name": "Slack account"
        }
      }
    },
    {
      "parameters": {
        "resource": "user",
        "operation": "getProfile",
        "user": {
          "__rl": true,
          "value": "U035F563JSW",
          "mode": "list",
          "cachedResultName": "jonathan"
        }
      },
      "id": "9de02c3f-e17c-4a32-a64e-11aaa0b36120",
      "name": "Get Profile",
      "type": "n8n-nodes-base.slack",
      "typeVersion": 2.1,
      "position": [
        1120,
        440
      ],
      "credentials": {
        "slackApi": {
          "id": "E4DnXIyNuRxi5GSz",
          "name": "Slack account"
        }
      }
    }
  ],
  "connections": {
    "When clicking \"Execute Workflow\"": {
      "main": [
        [
          {
            "node": "Get Info",
            "type": "main",
            "index": 0
          },
          {
            "node": "Get Profile",
            "type": "main",
            "index": 0
          }
        ]
      ]
    }
  },
  "pinData": {}
}
```
 2023-11-29 08:37:18 +00:00
Alex Grozav 72852a60eb
feat(editor): Replace middleware for Role checks with Scope checks (#7847) 2023-11-29 10:35:40 +02:00
Csaba Tuncsik d4970410e1
fix(editor): Add telemetry to workflow history (#7811) 2023-11-29 09:09:21 +01:00
Milorad FIlipović c0633987bf
fix(editor): Fix mouse position in workflow previews (#7853) 
This PR fixes mouse position detection in workflow previews (executions
preview and workflow history view):


https://github.com/n8n-io/n8n/assets/2598782/83237b76-b099-4560-9c47-a963f0848297

**Cause**:
We were setting `isDemo` state in canvas store only when the `NodeView`
component is activated, which never happens for `NodeView` instances
that are kept alive (above mentioned workflow previews)

**Fix**:
This workflow updates store state also when the `NodeView` component is
mounted.
 2023-11-28 19:02:19 +01:00
Tomi Turtiainen 28ac5a750e
fix(editor): Fix icon for unknown node type (#7842) 2023-11-28 19:16:51 +02:00
कारतोफ्फेलस्क्रिप्ट™ 2f8cb419df
ci: Fix editor tests when coverage is enabled (no-changelog) (#7827) 
[Test run
](https://github.com/n8n-io/n8n/actions/runs/7021272455/job/19103012704)
 2023-11-28 18:04:30 +01:00
Csaba Tuncsik 685ffd7413
fix(editor): Suppress dev server websocket messages in workflow view (#7808) 2023-11-28 17:30:44 +01:00
कारतोफ्फेलस्क्रिप्ट™ 117962d473
feat(core): Update LLM applications building support (no-changelog) (#7710) 
extracted out of #7336

---------

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Alex Grozav <alex@grozav.com>
 2023-11-28 16:47:28 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4a89504d54
fix(editor): Fix push connection on WorkerList and CommunityNodes pages (no-changelog) (#7851) 2023-11-28 16:45:50 +01:00
Csaba Tuncsik e87e928144
fix(editor): Remove ability for users to select admin role in the UI (no-changelog) (#7850) 2023-11-28 15:11:02 +01:00
Iván Ovejero 2356fb0f0c
feat(core): Set up endpoint for all existing roles with license flag (#7834) 
https://linear.app/n8n/issue/PAY-1034/create-endpoint-to-list-all-existing-roles
 2023-11-28 14:16:47 +01:00
Tomi Turtiainen 4074107511
fix(editor): Fix credential icon for old node type version (#7843) 
If a credential was for a node's older version, its icon was not shown.
 2023-11-28 15:14:22 +02:00
Val a37f1cb0ba
feat: Add initial scope checks via decorators (#7737) 2023-11-28 11:41:34 +00:00
कारतोफ्फेलस्क्रिप्ट™ 753cbc1e96
refactor(editor): Delete some barrel files and reduce circular dependencies (no-changelog) (#7838) 2023-11-28 12:15:08 +01:00
Csaba Tuncsik 3ab3ec9da8
fix(editor): Allow owners and admins to share workflows and credentials they don't own (#7833) 2023-11-28 11:44:55 +01:00
Iván Ovejero 1c6178759c
refactor(core): Reorganize error hierarchy in cli package (no-changelog) (#7839) 
Ensure all errors in `cli` inherit from `ApplicationError` to continue
normalizing all the errors we report to Sentry

Follow-up to: https://github.com/n8n-io/n8n/pull/7820
 2023-11-28 10:19:27 +01:00
Jon 38f24a6184
fix(Google Calendar Trigger Node): Fix issue preventing birthday and holiday calendars from working (#7832) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-with-some-google-calendars/33411

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
 2023-11-28 09:11:05 +00:00
Michael Kret d5488725a8
fix(Google Sheets Node): Read operation execute for each item (#7800) 
Github issue / Community forum post (link here to close automatically):
 2023-11-28 11:02:11 +02:00
Michael Kret df691fba0c
fix(core): Node version in the user added node to workflow canvas event (no-changelog) (#7814) 
Github issue / Community forum post (link here to close automatically):
 2023-11-27 19:50:20 +02:00
Iván Ovejero 9b87a596ca
fix(core): Ensure member and admin cannot be promoted to owner (#7830) 
https://linear.app/n8n/issue/PAY-985/add-user-role-modification-endpoint#comment-62355f6b
 2023-11-27 17:35:58 +01:00
Tomi Turtiainen ac744d6702
test: Ado 1296 add e2e tests (#7792) 
Adds e2e tests for the template credential setup.
 2023-11-27 17:18:10 +02:00
Omar Ajoue 847f6ac771
fix(core): Prevent error messages due to statistics about data loading (#7824) 
Statistics collection about the first time a workflow loads data simply
attempts an insert to db, and if it fails, we just ignore.

This was causing this query to fire against production workflows
multiple times, and since we want to insert only and detect whether the
insertion failed, performing a select first provides gains both in terms
of performance, as it's usually faster than trying an insertion as well
as preventing unnecessary noise in logs.

Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/duplicate-key-value-violates-unique-constraint-workflow-statistics-pkey-still-happening/29283
https://github.com/n8n-io/n8n/issues/7256
https://community.n8n.io/t/error-log-arriving-in-postgres/30191
https://github.com/n8n-io/n8n/issues/7256

https://community.n8n.io/t/cant-launch-webhooks-unable-to-find-data-of-execution/31867

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-11-27 15:43:48 +01:00
Michael Kret 73ec7533ce
fix(Microsoft SQL Node): Prevent double escaping table name (#7801) 
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/issue-my-mssql-update-in-latest-version/32966
 2023-11-27 16:41:35 +02:00
Iván Ovejero dff8456382
refactor(core): Reorganize error hierarchy in core and workflow packages (no-changelog) (#7820) 
Ensure all errors in `core` and `workflow` inherit from
`ApplicationError` so that we start normalizing all the errors we report
to Sentry

Follow-up to:
https://github.com/n8n-io/n8n/pull/7757#discussion_r1404338844

### `core` package

`ApplicationError`
- `FileSystemError` (abstract)
	- `FileNotFoundError`
	- `DisallowedFilepathError`
- `BinaryDataError` (abstract)
	- `InvalidModeError`
	- `InvalidManagerError`
- `InvalidExecutionMetadataError`

### `workflow` package

`ApplicationError`
- `ExecutionBaseError` (abstract)
	- `WorkflowActivationError`
		- `WorkflowDeactivationError`
		- `WebhookTakenError`
	- `WorkflowOperationError`
		- `SubworkflowOperationError`
			- `CliWorkflowOperationError`
	- `ExpressionError`
		- `ExpressionExtensionError`
	- `NodeError` (abstract)
		- `NodeOperationError`
		- `NodeApiError`
	- `NodeSSLError`

Up next:
- Reorganize errors in `cli`
- Flatten the hierarchy in `workflow` (do we really need
`ExecutionBaseError`?)
- Remove `ExecutionError` type
- Stop throwing plain `Error`s
- Replace `severity` with `level`
- Add node and credential types as `tags`
- Add workflow IDs and execution IDs as `extras`
 2023-11-27 15:33:21 +01:00
Tomi Turtiainen aae45b043b
feat: Ado 1296 spike credential setup in templates (#7786) 
- Add a 'Setup template credentials' view to setup the credentials of a
template before it is created
 2023-11-27 16:30:28 +02:00
Val 27e048c201
feat: Add Licensed decorator (no-changelog) (#7828) 
Github issue / Community forum post (link here to close automatically):
 2023-11-27 13:46:18 +00:00
Michael Kret d667bca658
feat(Notion Node): Option to simplify output in getChildBlocks operation (#7791) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Marcus <marcus@n8n.io>
 2023-11-27 15:02:57 +02:00
Csaba Tuncsik 137e23853f
feat: Add user role select to users list settings page (#7796) 
![CleanShot 2023-11-27 at 07 20
58](https://github.com/n8n-io/n8n/assets/5410822/40be0505-32ee-48a7-923e-ba6b4dbce670)
 2023-11-27 13:38:03 +01:00
Val 5acb7b94c0
refactor: Refactor variables controller into a RestController (no-changelog) (#7822) 
Github issue / Community forum post (link here to close automatically):
 2023-11-27 12:17:09 +00:00
Iván Ovejero 7b8532d3a3
refactor(core): Move execution progress saving to standalone utility (no-changelog) (#7770) 
This PR continues the effort of moving logic inside execution lifecycle
hooks into standalone testable functions, as a stepping stone to
refactoring the hooks themselves.
 2023-11-27 13:10:43 +01:00
कारतोफ्फेलस्क्रिप्ट™ 2807ddcd0d
fix(editor): Setup push connection in NodeView (no-changelog) (#7821) 2023-11-27 12:48:48 +01:00
Iván Ovejero 75a5807c72
perf(core): Make user controller tests faster (no-changelog) (#7819) 
Before: `17.949 s`
After: `3.886 s`

Followup to:
https://github.com/n8n-io/n8n/pull/7797#discussion_r1404148034
 2023-11-27 11:56:06 +01:00
Csaba Tuncsik 83086af247
build: Fix vite config (switch to module type) (#7818) 2023-11-27 10:56:57 +01:00
Alex Grozav 7cc7f226e5
fix(editor): Fix broken element-plus loading spinner (no-changelog) (#7817) 
<img width="976" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/aea8a4c8-277e-4527-b6e9-a5c3427097b6">
<img width="117" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/14c8876c-5e26-4154-9fdf-8b1fe9e5f806">
 2023-11-27 10:50:50 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1b60cfb8f1
ci: Fix new user patching endpoint tests (no-changelog) (#7816) 
user ids are uuids, and in the future we should add proper input
validation to prevent invalid user ids reaching the DB like this.
 2023-11-27 09:35:09 +01:00
Csaba Tuncsik 152883eed1
build: Upgrade lint related packages (#7790) 2023-11-27 09:11:52 +01:00
कारतोफ्फेलस्क्रिप्ट™ d2c18c5727
fix(core): Use AbortController to notify nodes to abort execution (#6141) 
and add support for cancelling ongoing operations inside a node.

---------
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
 2023-11-24 18:17:06 +01:00
Milorad FIlipović 0ec67dabf7
fix(editor): Fix UserStack vertical centering (no-changelog) (#7806) 
Dropdown items in `UserStack`component are not properly vertically
aligned. That's particularly noticeable when the items are hovered:

![image](https://github.com/n8n-io/n8n/assets/2598782/c994be3d-45e9-4b89-9973-deee5a8735ba)
 2023-11-24 16:38:11 +01:00
Iván Ovejero eec2ec1ff8
refactor(core): Consolidate path-related errors in Sentry (no-changelog) (#7757) 
Keep reporting [path-related
errors](https://n8nio.sentry.io/issues/4649493725) in Sentry but
consolidate them in a single error group.

Also, add `options.extra` as `meta` so they remain visible in debug
logs:

```
2023-11-24T11:50:54.852Z | error    | ReportableError: Something went wrong "{ test: 123, file: 'LoggerProxy.js', function: 'exports.error' }"
```

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
 2023-11-24 14:42:46 +01:00
Tomi Turtiainen 5914e97e9a
docs: Document how to run e2e tests (no-changelog) (#7802) 2023-11-24 13:21:42 +02:00
Iván Ovejero 7a86d36068
feat(core): Allow user role modification (#7797) 
https://linear.app/n8n/issue/PAY-985

```
PATCH /users/:id/role
  unauthenticated user
    ✓ should receive 401 (349 ms)
  member
    ✓ should fail to demote owner to member (349 ms)
    ✓ should fail to demote owner to admin (359 ms)
    ✓ should fail to demote admin to member (381 ms)
    ✓ should fail to promote other member to owner (353 ms)
    ✓ should fail to promote other member to admin (377 ms)
    ✓ should fail to promote self to admin (354 ms)
    ✓ should fail to promote self to owner (371 ms)
  admin
    ✓ should receive 400 on invalid payload (351 ms)
    ✓ should receive 404 on unknown target user (351 ms)
    ✓ should fail to demote owner to admin (349 ms)
    ✓ should fail to demote owner to member (347 ms)
    ✓ should fail to promote member to owner (384 ms)
    ✓ should fail to promote admin to owner (350 ms)
    ✓ should be able to demote admin to member (354 ms)
    ✓ should be able to demote self to member (350 ms)
    ✓ should be able to promote member to admin (349 ms)
  owner
    ✓ should be able to promote member to admin (349 ms)
    ✓ should be able to demote admin to member (349 ms)
    ✓ should fail to demote self to admin (348 ms)
    ✓ should fail to demote self to member (354 ms)
```
 2023-11-24 11:40:08 +01:00
Tomi Turtiainen 87fa3c2985
test: Remove obsolete snapshot (#7803) 
Fixes

```
  Snapshots  1 obsolete
             ↳ src/components/banners/__tests__/V1Banner.spec.ts
               · V1 Banner > should render banner if user is not woner 1
```
 2023-11-24 11:53:28 +02:00
Elias Meire da851986f6
feat(editor): Add node name and version to NDV node settings (#7731) 
<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/85ac1c6e-9116-436a-a2ed-8d0ac162a287">

<img width="580" alt="image"
src="https://github.com/n8n-io/n8n/assets/8850410/08b37377-cef5-4f80-80c0-addfdd37f728">

---------

Co-authored-by: Giulio Andreini <andreini@netseven.it>
 2023-11-23 18:28:07 +01:00
Elias Meire 902beffce5
fix(editor): Disable context menu actions in read-only mode (#7789) 
Github issue / Community forum post (link here to close automatically):
 2023-11-23 17:10:45 +01:00
Val 865192adf0
feat: Add global admin role (no-changelog) (#7781) 
Github issue / Community forum post (link here to close automatically):
 2023-11-23 13:38:11 +00:00
Michael Auerswald 5835e055d3
fix(editor): Show nice error when environment is not set up (#7778) 
Adds a nicer error message with a link for owners who press Push to Git
without having a repository connected yet.
 2023-11-23 13:50:03 +01:00
Alex Grozav 67a88914f2
feat(editor): Add routing middleware, permission checks, RBAC store, RBAC component (#7702) 
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
 2023-11-23 13:22:47 +02:00
Iván Ovejero fdb2c18ecc
fix(core): Tighten checks for multi-main setup usage (#7788) 
https://n8nio.slack.com/archives/C05HRPLSGTT/p1700731476321999?thread_ts=1700729359.746899&cid=C05HRPLSGTT
 2023-11-23 12:18:39 +01:00