Iván Ovejero
233683ce1a
refactor(core): Remove webhook deregistration on shutdown flag ( #7543 )
...
Removal missing from [original
PR](https://github.com/n8n-io/n8n/pull/7515 ) after initial revert.
2023-10-27 18:48:21 +02:00
Iván Ovejero
18dcea8c19
refactor(Slack Node): Stop reporting to Sentry errors from missing scopes (no-changelog) ( #7542 )
...
https://n8nio.sentry.io/issues/4570238312
2023-10-27 16:46:05 +02:00
Iván Ovejero
6796ba75a1
refactor(core): Stop reporting to Sentry stopping execution with wrong status (no-changelog) ( #7541 )
...
https://n8nio.sentry.io/issues/4257040218/
2023-10-27 16:14:01 +02:00
कारतोफ्फेलस्क्रिप्ट™
c05bc6728d
fix(editor): Handle localStorage
being blocked/unavailable ( #7348 )
2023-10-27 15:51:20 +02:00
Iván Ovejero
739a4d4ecf
refactor: Add lintfix
run to ignore revs (no-changelog) ( #7540 )
...
Ref: https://github.com/n8n-io/n8n/pull/7537
2023-10-27 14:58:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) ( #7221 )
2023-10-27 14:17:52 +02:00
Iván Ovejero
62c096710f
refactor: Run lintfix
(no-changelog) ( #7537 )
...
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Alex Grozav
1c4ac02db5
fix(editor): Fix executions sidebar height (no-changelog) ( #6909 )
...
<img width="1397" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/cb142085-3b21-4e18-9f0d-92c5c4018578 ">
2023-10-27 14:32:23 +03:00
Iván Ovejero
07857e78a9
refactor(core): Stop reporting to Sentry non-execution of workflow with issues ( #7533 )
...
https://n8nio.sentry.io/issues/4578929841/
2023-10-27 10:09:23 +02:00
Iván Ovejero
9762705833
fix(Jira Software Node): Handle missing issue types in issue types loader ( #7534 )
...
https://n8nio.sentry.io/issues/4576849854
2023-10-27 10:09:14 +02:00
Omar Ajoue
87996a1fcf
refactor(core): Stop reporting non-error to sentry (issue 4229454473) (no-changelog) ( #7525 )
...
This PR aims to stop reporting issues such as [this
one](https://n8nio.sentry.io/issues/4229454473/events/42b96bfd6a334c15a84499e981cf90eb/?project=4503924908883968 ).
Github issue / Community forum post (link here to close automatically):
2023-10-27 09:25:07 +02:00
Csaba Tuncsik
12a89e6d14
fix(editor): Fix route component caching, incorrect use of array reduce method and enable WF history feature ( #7434 )
...
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-10-26 20:47:42 +02:00
Iván Ovejero
ae616f146b
fix(editor): Do not truncate form inputs ( #7528 )
2023-10-26 17:54:51 +02:00
Omar Ajoue
3d95b243e9
feat(core): Make queue mode settings configurable ( #7526 )
...
This PR allows users to configure the settings to Bull, possibly
reducing the errors with `maxStalledCount` and other issues, that
usually happen either when a worker crashes or when the event loop is
super busy. Increasing the lease time and the `maxStalledCount` settings
might improve UX.
Github issue / Community forum post (link here to close automatically):
2023-10-26 17:30:16 +02:00
Iván Ovejero
ae8c7a635e
refactor(core)!: Remove webhook deregistration at startup and shutdown ( #7515 )
...
https://linear.app/n8n/issue/PAY-932/deprecate-flag-to-skip-webhook-deregistration-on-shutdown
2023-10-26 14:37:54 +02:00
Iván Ovejero
5477e3fb45
refactor(core): Move execution save settings into lifecycle function (no-changelog) ( #7370 )
...
Move the handling of execution save settings into a tested lifecycle
function as discussed with Omar
2023-10-26 14:35:38 +02:00
कारतोफ्फेलस्क्रिप्ट™
1055bd3762
fix(core): Handle missing resultData in runData ( #7523 )
2023-10-26 13:15:19 +02:00
Iván Ovejero
d8ec6eac40
refactor(FileMaker Node): Prevent reporting to Sentry attempted loadOptions
calls without credentials (no-changelog) ( #7520 )
...
Severity is lost when wrapping the error, but there is no need to change
the error type here.
https://n8nio.slack.com/archives/C03MZF137FV/p1698308092989739
2023-10-26 12:02:35 +02:00
Iván Ovejero
a277807404
refactor(Airtable Node): Prevent reporting to Sentry failure to find table (no-changelog) ( #7521 )
...
https://n8nio.sentry.io/issues/4356342982/?project=4503924908883968&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=8
2023-10-26 12:02:23 +02:00
Iván Ovejero
d885daa6a1
refactor(Google Sheets Node): Prevent reporting to Sentry failure to find spreadsheet (no-changelog) ( #7518 )
...
To silence this very frequently reported error:
https://n8nio.sentry.io/issues/3823103947/?project=4503924908883968&query=&referrer=issue-stream&statsPeriod=90d&stream_index=0
2023-10-26 11:33:11 +02:00
कारतोफ्फेलस्क्रिप्ट™
65e5593233
fix(core): Upgrade crypto-js to address CVE-2023-46233 ( #7519 )
...
[GH Advisory](https://github.com/advisories/GHSA-xwcq-pm8m-c4vf )
2023-10-26 11:21:53 +02:00
Jan Oberhauser
df89685e15
fix(editor): Fixes the issue that Switch Node can not be created ( #7516 )
...
Fixes the issue that currently no Switch-Node can be created by for
example pressing + on the parent node or via tab when another node is
already selected.
Github issue / Community forum post (link here to close automatically):
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-26 09:46:26 +02:00
Iván Ovejero
742c8a8534
fix(core): Ensure execution deletion in worker lifecycle hook ( #7481 )
...
Reported by customer
[here](https://n8nio.slack.com/archives/C05PUALKZHD/p1697446945481249?thread_ts=1697196557.638169&cid=C05PUALKZHD ),
apparently a very old long-standing bug for queue mode. Please review
closely as I am not familiar with queue mode.
2023-10-25 19:13:06 +02:00
कारतोफ्फेलस्क्रिप्ट™
05586a900d
refactor(core): Make Logger a service (no-changelog) ( #7494 )
2023-10-25 16:35:22 +02:00
github-actions[bot]
db4e61ba24
🚀 Release 1.14.0 ( #7514 )
...
# [1.14.0](https://github.com/n8n-io/n8n/compare/n8n@1.13.0...n8n@1.14.0 )
(2023-10-25)
### Features
* **Switch Node:** Add support for infinite Switch outputs
([#7499 ](https://github.com/n8n-io/n8n/issues/7499 ))
([2febc61
](2febc61ec9
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-25 15:34:57 +02:00
कारतोफ्फेलस्क्रिप्ट™
0643487403
ci: Fix oclif manifest generation
2023-10-25 14:51:10 +02:00
कारतोफ्फेलस्क्रिप्ट™
28aabb845a
Merge remote-tracking branch 'origin/release/1.13.0'
2023-10-25 14:50:48 +02:00
OlegIvaniv
2febc61ec9
feat(Switch Node): Add support for infinite Switch outputs ( #7499 )
...
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-more-outputs-to-switch-node/3864
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-25 14:34:47 +02:00
github-actions[bot]
2987587e34
🚀 Release 1.13.0 ( #7512 )
...
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0 )
(2023-10-25)
### Bug Fixes
* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465 ](https://github.com/n8n-io/n8n/issues/7465 ))
([55c6a1b
](55c6a1b0d3
))
* **core:** Ensure nodes post-processors run in the correct order
([#7500 ](https://github.com/n8n-io/n8n/issues/7500 ))
([6f45298
](6f45298d3d
))
* **core:** Fix `frontend.settings` external hook execution
([#7496 ](https://github.com/n8n-io/n8n/issues/7496 ))
([774fe20
](774fe202bf
))
* **core:** Handle gzip and deflate compressed request payloads
([#7461 ](https://github.com/n8n-io/n8n/issues/7461 ))
([83762e0
](83762e051d
))
* **core:** Reduce logging overhead for levels that do not output
([#7479 ](https://github.com/n8n-io/n8n/issues/7479 ))
([76c0481
](76c04815f7
))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485 ](https://github.com/n8n-io/n8n/issues/7485 ))
([519680c
](519680c2cf
))
* **editor:** Allow importing the same workflow multiple times
([#7458 ](https://github.com/n8n-io/n8n/issues/7458 ))
([3c0a166
](3c0a166f7f
))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466 ](https://github.com/n8n-io/n8n/issues/7466 ))
([bc47365
](bc473655fb
))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483 ](https://github.com/n8n-io/n8n/issues/7483 ))
([450e0cc
](450e0cc66a
))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463 ](https://github.com/n8n-io/n8n/issues/7463 ))
([ab6a9bb
](ab6a9bbac2
))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467 ](https://github.com/n8n-io/n8n/issues/7467 ))
([a739245
](a739245332
))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498 ](https://github.com/n8n-io/n8n/issues/7498 ))
([baecb93
](baecb93bef
))
* **MySQL Node:** Resolve expressions in v1
([#7464 ](https://github.com/n8n-io/n8n/issues/7464 ))
([5c46bb0
](5c46bb09c1
))
* **Redis Node:** Fix adding sets data types
([#7444 ](https://github.com/n8n-io/n8n/issues/7444 ))
([4e66023
](4e66023cd4
))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505 ](https://github.com/n8n-io/n8n/issues/7505 ))
([05e6f2a
](05e6f2a6ac
))
### Features
* **core:** Add support for oauth based service accounts with UM SMTP
([#7311 ](https://github.com/n8n-io/n8n/issues/7311 ))
([647372b
](647372be27
))
* **editor:** Add PH tracking to event
([#7511 ](https://github.com/n8n-io/n8n/issues/7511 ))
([c47d27d
](c47d27dd6d
))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113 ](https://github.com/n8n-io/n8n/issues/7113 ))
([ac814a9
](ac814a9c61
))
* **Ghost Node:** Add support for lexical format
([#7488 ](https://github.com/n8n-io/n8n/issues/7488 ))
([7b1973c
](7b1973c058
))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386 ](https://github.com/n8n-io/n8n/issues/7386 ))
([689360e
](689360ee06
))
Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-25 14:29:28 +02:00
कारतोफ्फेलस्क्रिप्ट™
6f45298d3d
fix(core): Ensure nodes post-processors run in the correct order ( #7500 )
...
Fixes #7497
2023-10-25 13:59:38 +02:00
Mutasem Aldmour
c47d27dd6d
feat(editor): Add PH tracking to event ( #7511 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-25 12:18:19 +02:00
Val
93cfabbeac
fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) ( #7508 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-25 11:07:11 +01:00
Iván Ovejero
671c95760b
refactor(core): Make executions pruning more resilient ( #7480 )
...
This PR converts the hard-deletion interval to a timeout:
- to prevent the interval from not being restored when hard deletion
throws, and
- to prevent a long-running hard deletion from leading to duplicate
deletions.
2023-10-24 16:16:45 +02:00
Jon
05e6f2a6ac
fix(Spreadsheet File Node): Fix include empty cells not working with v2 ( #7505 )
...
Github issue / Community forum post (link here to close automatically):
Ticket#763644
2023-10-24 14:22:45 +01:00
कारतोफ्फेलस्क्रिप्ट™
8ff9f97493
fix(core): Create instance settings directory recursively (no-changelog) ( #7506 )
2023-10-24 15:10:22 +02:00
Michael Kret
a739245332
fix(Microsoft SQL Node): Prevent SQL injection ( #7467 )
...
Github issue / Community forum post (link here to close automatically):
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-24 12:36:44 +03:00
Iván Ovejero
78243edd18
refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory ( #7482 )
...
Since we do not store which executions produced binary data, for pruning
on S3 we need to query for binary data items for each execution in order
to delete them. To minimize requests to S3, allow the user to skip
pruning requests when setting TTL at bucket level.
2023-10-24 10:37:02 +02:00
कारतोफ्फेलस्क्रिप्ट™
a9fdd018f4
fix(core): Always derive instanceId
from the encryption key (no-changlog) ( #7501 )
...
This was the expected behavior, until I changed it in
https://github.com/n8n-io/n8n/pull/7471
2023-10-24 09:55:57 +02:00
Val
baecb93bef
fix(MQTT Trigger Node): Fix node causing a start up hang when active ( #7498 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-24 09:37:49 +02:00
Cornelius Suermann
3ef771ea38
feat: Collect usage metrics on license renewal (no-changelog) ( #7486 )
2023-10-23 21:39:29 +02:00
Ricardo Espinoza
774fe202bf
fix(core): Fix frontend.settings
external hook execution ( #7496 )
2023-10-23 11:46:13 -04:00
Burak Akgün
4e66023cd4
fix(Redis Node): Fix adding sets data types ( #7444 )
...
Fixes #6339
2023-10-23 16:33:44 +01:00
Val
41236b7e08
fix: Save new version of the workflow instead of the previous (no-changelog) ( #7428 )
...
Github issue / Community forum post (link here to close automatically):
2023-10-23 16:30:36 +02:00
कारतोफ्फेलस्क्रिप्ट™
b6de910cbe
refactor(core): Abstract away InstanceSettings and encryptionKey
into injectable services (no-changelog) ( #7471 )
...
This change ensures that things like `encryptionKey` and `instanceId`
are always available directly where they are needed, instead of passing
them around throughout the code.
2023-10-23 13:39:35 +02:00
Léo Martinez
519680c2cf
fix(Customer.io Node): Fix api endpoint when using EU region ( #7485 )
...
Fixes #7484
2023-10-23 10:01:48 +01:00
MC Naveen
7b1973c058
feat(Ghost Node): Add support for lexical format ( #7488 )
2023-10-23 10:00:38 +01:00
OlegIvaniv
450e0cc66a
fix(editor): Fix connections disappearing after reactivating canvas and renaming a node ( #7483 )
...
Github issue / Community forum post (link here to close automatically):
-
https://community.n8n.io/t/1-11-1-possible-bug-all-nodes-randomly-losing-their-connectors/31856
- https://community.n8n.io/t/lines-between-nodes-have-disappeared/31846
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-23 10:07:33 +02:00
कारतोफ्फेलस्क्रिप्ट™
76c04815f7
fix(core): Reduce logging overhead for levels that do not output ( #7479 )
...
all current logging calls execute `callsites()` to figure out what code
tried to log. This happens even for logging methods that aren't supposed
to create any output. Under moderate load, this can take up quite a lot
of resources. This PR changes the logger to make all ignorable logging
methods a No-Op.
In a small benchmark with a simple webhook, with log-level set to
`warn`, and using `ab -c 50 -n 500
http://localhost:5678/webhook/testing `, these were the response times:
### Before
![Before](https://github.com/n8n-io/n8n/assets/196144/01680fd9-3d2a-4f7f-bb1c-5b03bd7d5bc3 )
### After
![After](https://github.com/n8n-io/n8n/assets/196144/ccacb20a-48ca-455a-a8cb-098c9c0e352e )
2023-10-20 18:26:33 +02:00
Iván Ovejero
0b42d1aa71
refactor(core): Limit soft-deletions to pruning only ( #7469 )
...
Based on customer feedback, we should limit soft deletions to pruning
only, to prevent executions from piling up in very high volume cases.
2023-10-20 15:02:47 +02:00
कारतोफ्फेलस्क्रिप्ट™
3c0a166f7f
fix(editor): Allow importing the same workflow multiple times ( #7458 )
...
Fixes #7457
2023-10-20 13:58:30 +02:00