Commit graph

284 commits

Author SHA1 Message Date
Omar Ajoue 66a345ea94
🐛 Fix issue with auto refresh on execution list (#1475)
* Fix issue with auto refresh on execution list

When auto refresh is on, we used to get executions from backend using
the firstId field to filter recent executions.

This is a problem when you have executions that do not finish in order,
leaving gaps behind. This PR fixes this problem by refreshing the latest
30 executions and correctly adding them to the list.

* Fixed an issues with auto refresh on executions ExecutionsList

Fixed two bugs, one in frontend which was ignoring the first returned
row from the backend and an issue with backend that was not using
the overriden version of `executeWorkflow` function for sub sub
workflows.

* Fixed the display of manual executions when running with queues and improved display of subworkflows

* Changing workflow ids array from variable to constant

* Added unknown status to workflow execution and changed its color to orange
2021-03-03 08:31:55 +01:00
Jan Oberhauser 9b23611a8d Rename "Results" to "Items" 2021-03-01 14:05:19 +01:00
Jon Bake 54f949a972
🐛 Fixes #1364 - Incorrect mouse selection when zoomed in or out (#1498)
Prior to this change, the mouse selection box had a fixed position on the page. Nodes have absolute
position within NodeView. This inconsistency in positioning caused issues when calculating
if a node was positioned within the mouse selection. This solution makes both nodes
and mouse selection have consistent positioning, along with correctly calculating the
mouse click position within NodeView when making a selection.
2021-02-28 18:08:14 +01:00
Omar Ajoue 91b715025d
🐛 Fix auto refresh on executions list (#1457) 2021-02-18 00:09:39 +01:00
lublak cb9f31c49d add dir to different positions 2021-02-15 13:25:30 +01:00
Jan Oberhauser deaa015e61 Do only send manual executions to starting session & cleanup 2021-02-13 20:40:27 +01:00
Omar Ajoue e53efdd337
Separate webhooks from core (#1408)
* Unify execution ID across executions

* Fix indentation and improved comments

* WIP: saving data after each node execution

* Added on/off to save data after each step, saving initial data and retries working

* Fixing lint issues

* Fixing more lint issues

*  Add bull to execute workflows

* 👕 Fix lint issue

*  Add graceful shutdown to worker

*  Add loading staticData to worker

* 👕 Fix lint issue

*  Fix import

* Changed tables metadata to add nullable to stoppedAt

* Reload database on migration run

* Fixed reloading database schema for sqlite by reconnecting and fixing postgres migration

* Added checks to Redis and exiting process if connection is unavailable

* Fixing error with new installations

* Fix issue with data not being sent back to browser on manual executions with defined destination

* Merging bull and unify execution id branch fixes

* Main process will now get execution success from database instead of redis

* Omit execution duration if execution did not stop

* Fix issue with execution list displaying inconsistant information information while a workflow is running

* Remove unused hooks to clarify for developers that these wont run in queue mode

* Added active pooling to help recover from Redis crashes

* Lint issues

* Changing default polling interval to 60 seconds

* Removed unnecessary attributes from bull job

* Added webhooks service and setting to disable webhooks from main process

* Fixed executions list when running with queues. Now we get the list of actively running workflows from bull.

* Add option to disable deregistration of webhooks on shutdown

* Rename WEBHOOK_TUNNEL_URL to WEBHOOK_URL keeping backwards compat.

* Added auto refresh to executions list

* Improvements to workflow stop process when running with queues

* Refactor queue system to use a singleton and avoid code duplication

* Improve comments and remove unnecessary commits

* Remove console.log from vue file

* Blocking webhook process to run without queues

* Handling execution stop graciously when possible

* Removing initialization of all workflows from webhook process

* Refactoring code to remove code duplication for job stop

* Improved execution list to be more fluid and less intrusive

* Fixing workflow name for current executions when auto updating

*  Right align autorefresh checkbox

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-02-09 23:32:40 +01:00
Omar Ajoue 7a3aaf8a24
Unify execution id + Queue system (#1340)
* Unify execution ID across executions

* Fix indentation and improved comments

* WIP: saving data after each node execution

* Added on/off to save data after each step, saving initial data and retries working

* Fixing lint issues

* Fixing more lint issues

*  Add bull to execute workflows

* 👕 Fix lint issue

*  Add graceful shutdown to worker

*  Add loading staticData to worker

* 👕 Fix lint issue

*  Fix import

* Changed tables metadata to add nullable to stoppedAt

* Reload database on migration run

* Fixed reloading database schema for sqlite by reconnecting and fixing postgres migration

* Added checks to Redis and exiting process if connection is unavailable

* Fixing error with new installations

* Fix issue with data not being sent back to browser on manual executions with defined destination

* Merging bull and unify execution id branch fixes

* Main process will now get execution success from database instead of redis

* Omit execution duration if execution did not stop

* Fix issue with execution list displaying inconsistant information information while a workflow is running

* Remove unused hooks to clarify for developers that these wont run in queue mode

* Added active pooling to help recover from Redis crashes

* Lint issues

* Changing default polling interval to 60 seconds

* Removed unnecessary attributes from bull job

*  Improved output on worker job start

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-02-09 08:59:32 +01:00
Jan Oberhauser 80f7ee1f7b Small design tweak 2021-02-01 23:57:00 +01:00
Jan Oberhauser 5398a06ff2 Add variable $mode 2021-01-29 09:31:40 +01:00
Jan Oberhauser 1dedb3f4b8 Add expression support to credentials 2021-01-24 13:33:57 +01:00
Ahsan Virani 4d446229c3
Introduce FE external hooks (#1332)
*  Introduce FE external hooks

*  update hooks

*  add data from frontend settings to hooks

* re-organize and update

* cleanup

* 👌

*  cleanup workflowSave mixin, add events

* avoid alert on new workflow save as

*  update workflow active events

* rename externalhooks method

*  Rename frontend hooks

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-01-19 23:48:30 +01:00
Jan Oberhauser 18a7c325dc Improve CodeEdit dialog close behaviour #1353 2021-01-19 08:55:39 +01:00
Jan Oberhauser 4077cabb52 Fix issue that tab-title did not get reset on new workflow 2021-01-17 14:07:07 +01:00
Iván Ovejero 6759e2e72a
Add data-node-name to node item (#1329)
* Add data-node-name to node item

* Restore n8n-nodes-base prefix for consistency
2021-01-13 09:02:10 +01:00
Jan Oberhauser 04b16c5ab8 👕 Fix lint issue 2020-12-27 00:28:51 +01:00
Jan Oberhauser 95315cec60 Add optional sort option if "multipleValues" is set 2020-12-27 00:15:33 +01:00
Jan Oberhauser aaae7964d6 Keep binary data visible on re-execution 2020-12-26 23:11:25 +01:00
Jan Oberhauser 065937a39c 🐛 Fix bug that HTML did get rendered in JSON view 2020-12-24 22:09:07 +01:00
Jan Oberhauser 75cca869b4 Fix issue that source node was also selected after duplicate 2020-12-24 08:37:13 +01:00
Jan bfb344a23c
Add functionality to easily copy data and path of output data (#1260)
*  Add functionality to easily copy data and path of output data

*  Fix issues with copied path

* 👕 Fix lint issue

* ;bug: Fix issue that some paths were wrong

*  Final improvements
2020-12-18 18:55:53 +01:00
Jan Oberhauser 8fee799d3d Add Google icon for OAuth to meet their branding guidelines 2020-12-03 12:36:34 +01:00
Tristian Flanagan 137c334389
Add horizontal scroll (#1172) 2020-11-18 23:29:12 +01:00
Jan Oberhauser c6f21804d7 👕 Fix lint issue 2020-11-09 12:35:44 +01:00
Jan Oberhauser 639bdd2ceb Allow custom documentation URLs on credentials & nodes 2020-11-09 12:23:53 +01:00
Jan Oberhauser 9fee42b2a8 Add shear option, resize with alpha color and fix bug 2020-11-09 11:26:46 +01:00
Jan Oberhauser 9465653fab Improve editor-UI dirty checking 2020-11-04 13:04:40 +01:00
Jan Oberhauser 66bfcca63f 🐛 Fix issue with IF&Switch node for undefined expressions #1099 2020-10-26 09:43:01 +01:00
Jan Oberhauser c339d76456 Minior improvements 2020-10-25 12:58:02 +01:00
Jan 72ac20b070
Improvements on #911 to display unsaved changes. Now works with back button. (#1098)
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2020-10-25 12:47:49 +01:00
Jan dc93694a1a
Merge branch 'master' into save-changes-warning 2020-10-25 11:47:47 +01:00
Jan Oberhauser 4a10cf246b Further improve support for touch-devices 2020-10-24 20:01:13 +02:00
Jan Oberhauser 044c986f30 👕 Fix lint issue 2020-10-23 19:13:25 +02:00
Jan Oberhauser d90a5e5dc6 Improve wheel-scrolling in Firefox 2020-10-23 18:43:30 +02:00
Jan Oberhauser c40601eecb Fix issues with support for touch-devices 2020-10-23 18:16:00 +02:00
Jan Oberhauser 4df74771e3 Improve support for touch-devices #1070 2020-10-23 13:51:39 +02:00
Omar Ajoue 37f787d7b2
Load node properties on demand (#1089)
*  Changed rest api endpoint to omit node properties by default.
 Created another endpoint to return all node information based on a list of names

* refactor: changed endpoint to POST instead of GET

* Changed properties to be optional for node description

* Removed eager loading for node properties.

All nodes will have their properties fetched when used in a workflow.
Works when opening an already saved workflow, creating a new one from
scratch or pasting JSON / URLs.

* Removing unnecessary dependency
2020-10-22 17:24:35 +02:00
Jan Oberhauser 40c2acd77b 👕 Fix lint issue 2020-10-22 15:46:03 +02:00
Jan Oberhauser 1a80a6afed Improve support for svg-icons 2020-10-03 14:10:08 +02:00
Jan Oberhauser f1680386ca Get OAuth-Callback URLs from backend 2020-09-30 15:57:40 +02:00
Rytis Ilciukas 3350723bf3
fix malformed html (#999) 2020-09-29 10:39:51 +02:00
Jan Oberhauser 9cb106c9b4 🐛 Fix issue that OAuth window did not close 2020-09-23 17:31:00 +02:00
Jan Oberhauser 5cb5020cf6 👕 Fix lint issue 2020-09-23 13:31:03 +02:00
Jan Oberhauser 2db6ae0f76 Simplify documentation help code and display only if URL is set 2020-09-23 11:10:23 +02:00
Jan Oberhauser 24c95c4f09 Use short variables for direct input data 2020-09-22 11:31:48 +02:00
Jan Oberhauser c8d009bced Add expression support to credentials 2020-09-12 12:16:07 +02:00
Rupenieks 33582655f2 Revert " Deconstructed store mutation data parameters for better readability"
This reverts commit 17ab16d248.
2020-09-09 14:28:13 +02:00
Rupenieks 17ab16d248 Deconstructed store mutation data parameters for better readability 2020-09-09 14:05:11 +02:00
Rupenieks d756bea1f4 Added asterisk to indicate if workflow is saved or not 2020-09-01 16:42:40 +02:00
Rupenieks 3e1ada7c1a 🚧 Added Vuex dirty state flag as central source of truth for if there are unsaved changes 2020-09-01 16:06:08 +02:00
rupenieks 66b76d16ee Merged contributor work 2020-08-31 13:08:27 +02:00
Jan Oberhauser df3e342d1e Minor improvements to display of help links 2020-08-27 10:48:57 +02:00
Jan Oberhauser 26a7acf5ed Minor improvements to display of help links 2020-08-27 09:57:34 +02:00
Jan Oberhauser d2110f677e 🔀 Merge branch 'master' into Doc-Link-to-Node-Credentials-Modal 2020-08-27 09:35:22 +02:00
Rupenieks 89499313b6 indentation 2020-08-27 09:23:23 +02:00
Rupenieks cf52ce3cfa Updated UTM link 2020-08-27 09:12:16 +02:00
maxtkacz 520933c7a4
Update CredentialsEdit.vue (#888)
Changed width of Credentials modal from 55% to 75%. Result is the "Nodes with Access" UI now only collapses in a UX-unfriendly manner on viewport widths under 1108px (previously was 1506px)
2020-08-26 21:31:08 +02:00
Jan Oberhauser 317949d765 Remove left behind debug code 2020-08-26 21:30:24 +02:00
maxtkacz f386d9e90a
Made "easy wins" copy-edit pass through vue components (#889)
Essentially scrubbed through .vue files in packages/editor-ui/src/components and copy edited labels/ tooltips etc.

Tried to prevent opinionated editing, simply rewriting existing meaning for clarity. I did however make an opinionated decision on changing a node's "Notes" to "Note" (only labels, nothing code related) because it feels more like a singluar note - especially when used as a subtitle in the workflow. Singular form also futureproofs functionality like showing a list of all node notes across a workflow (or versioning/ collaborative notes features).

So far, have gotten up to PageContentWrapper.vue (when sorted alphabetically). In a followup, will review ParameterInput.vue and onwards in /components folder
2020-08-26 21:25:59 +02:00
Jan Oberhauser b78145f2ec Fix issues with Dynamic title 2020-08-25 20:39:14 +02:00
Rupenieks 44f7b7a9c2
Dynamic title based on workflow execution (#865)
*  Added title changes based on workflow execution

*  Title changes on workflow open, reset on workflow delete, fixed not showing when page refreshed

*  Title icons
2020-08-25 20:37:24 +02:00
Rupenieks d8e8db39c4 Fixed new/open credentials from menu. UTM link adjusted for unknown nodes base. 2020-08-25 14:28:16 +02:00
Rupenieks d5dda2e35a Credential fallback added, fixed Gmail documentationUrl 2020-08-20 15:34:45 +02:00
Rupenieks 05258cc645 Credentials doc help link 2020-08-20 14:47:59 +02:00
Jan Oberhauser da0ef0d94c Add "Execute Once" node-setting 2020-08-08 21:11:12 +02:00
Jan Oberhauser e82f3f405e Fix link to documentation 2020-07-31 09:57:23 +02:00
Rupenieks 0f86df4c0f
Documentation Link in Node Display (#808)
*  Implemented Documentation link help box

*  Adjusted transition speed

*  Added UTM link, fixed Node Name issue
2020-07-31 09:56:39 +02:00
Jan Oberhauser c298fd325a 🐛 Fix bug which displayed selector for low number of items 2020-07-29 22:43:05 +02:00
Jan Oberhauser b488ae8d3a 👕 Fix lint issue 2020-07-29 14:20:31 +02:00
Ben Hesseldieck 051598d30e
Add max execution time for Workflows (#755)
* 🎉 basic setup and execution stopping

* 🚧 soft timeout for own process executions

* 🚧 add hard timeout for subprocesses

* 🚧 add soft timeout to main thread

* 🔧 set default timeout to 5 mins --> 500s

* 💡 adding documentation to configs

* 🚧 deactivate timeout by default

* 🚧 add logic of max execution timeout

*  adding timeout to settings in frontend and server

* 🎨 improve naming

* 💡 fix change in config docs

* ✔️ fixing compilation issue

* 🎨 add format for new config variables

* 👌 type cast before checking equality

*  Improve error message if NodeType is not known

* 🐳 Tag also rpi latest image

* 🐛 Fix Postgres issue with Node.js 14 #776

* 🚧 add toggle to activate workflow timeout

* 💄 improving UX of setting a timeout and its duration

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2020-07-29 14:12:54 +02:00
Erin 5f32341a9e Remove logs 2020-07-20 11:52:24 -04:00
Jan Oberhauser c1378c2f88 🐛 Fix Expression editor issue #719 2020-07-15 11:54:03 +02:00
Jan Oberhauser 25cc745894 🐛 Fix editor-ui build 2020-07-14 23:36:05 +02:00
Jan Oberhauser d17161cf40 🔀 Merge branch 'static-stateless-webhooks' 2020-07-14 12:34:34 +02:00
Jan Oberhauser 941ee06b14 Make n8n work in subfolder & Fix events in AffinityTrigger 2020-07-12 12:17:01 +02:00
Jan Oberhauser 305894d9b4 🐛 Fix item display issue 2020-07-10 10:12:30 +02:00
Erin ad1228e0ea Everything works except refresh 2020-07-09 16:54:50 -04:00
ricardo 494b1de93f Merge branch 'master' into static-stateless-webhooks 2020-06-22 16:16:50 -04:00
Jan Oberhauser 5ed86670a8 Make it use of full webhook path more generic 2020-06-10 15:39:15 +02:00
Jan Oberhauser 9cae58c787 🐛 Fix issue that nodes can not be opened in readOnly-Mode 2020-06-08 00:34:15 +02:00
Jan Oberhauser e3a6064196 Small changes to Twitter-Node 2020-06-03 15:06:13 +02:00
ricardo af3d799e5c Oauth1 support and Twitter node 2020-06-01 20:42:44 -04:00
Jan Oberhauser f1f09d4a03 🔀 Merge branch 'master' into oauth-support 2020-05-24 20:37:59 +02:00
Jan Oberhauser 5718330e29 🐛 Fix issues in read-only mode #39 2020-05-24 14:22:15 +02:00
Jan Oberhauser 2cdfb69e0c Improve data display for large amount of data 2020-05-24 00:57:40 +02:00
Jan Oberhauser c6281f2b0e Use only JSON-Data for display-size-calculation 2020-05-23 23:54:56 +02:00
Jan Oberhauser f004bc8aaf 🐛 Fix display issue on failed oauth connect #PROD-95 2020-05-18 14:54:03 +02:00
Jan Oberhauser 00935032e2 Improve OAuth connect flow 2020-05-18 11:58:37 +02:00
Jan Oberhauser 95097a8bd7 🐛 Fix issue with credentials which extend others 2020-05-16 19:22:06 +02:00
Jan Oberhauser cfe6e72440 Do not save credential default values to DB #PROD-52 2020-05-14 14:27:19 +02:00
Jan Oberhauser 4e4c1c8a9f Display OAuth callback URL in UI #PROD-23 2020-05-12 11:27:07 +02:00
Jan Oberhauser 147c50485c 🔀 Merge branch 'master' into oauth-support 2020-05-12 01:56:27 +02:00
Jan Oberhauser 3d330a94d3 Make it possible to display notes in flow 2020-05-05 17:34:12 +02:00
Boris Berenberg 4269e8b914 minor grammar fixes 2020-05-04 16:06:13 -04:00
Jan Oberhauser 384efade9f Small improvements to Mongo connection string support 2020-05-01 20:24:20 +02:00
Jan Oberhauser 1ed72af255 🐛 Fix issue with push messages that get received to fast 2020-05-01 10:45:28 +02:00
Jan Oberhauser 90fe5113a0 🔀 Merge branch 'master' into oauth-support 2020-04-14 20:54:19 +02:00
Jan Oberhauser c7024ca454 Add "alwaysOutputData" option to nodes 2020-04-12 19:58:30 +02:00
Jan Oberhauser f9dd92db97 🔀 Merge branch 'master' into oauth-support 2020-04-08 10:10:44 +02:00
Jan Oberhauser 931b73e1bd Display "options" parameter as "string" if options could not be loaded 2020-04-06 10:15:46 +02:00