Commit graph

38 commits

Author SHA1 Message Date
Mutasem Aldmour 276eaea4bf
Clean up node description (#1883)
Co-authored-by: Jan <janober@users.noreply.github.com>
2021-07-03 14:40:16 +02:00
Iván Ovejero f8fcf0c165
Add webhook node icon (#1910) 2021-06-18 23:48:38 +02:00
Iván Ovejero 1d27a9e87e
Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Jan Oberhauser 11fb97223c 👕 Fix lint issue 2021-03-23 17:42:38 +01:00
Ben Hesseldieck d395498882
Add support for webhook route parameters (#1343)
* 🚧 add webhookId to URL

* 🚧 add webhookId to webhook entity, 🔧 refactor migrations

* 🚧 🐘 postgres migration

* 🚧 add mySQL migration

* 🚧 refactor mongoDB

* 🚧 add webhookId to IWebhookDb

* 🚧 starting workflow with dynamic route works

*  production dynamic webhooks complete

* 🎨 fix lint issues

* 🔧 dynamic path for webhook-test complete

* 🎨 fix lint issues

* 🎨 fix typescript issue

*  add error message for dynamic webhook-test

* 🔨 improve handling of leading `/`

* 🚧 add webhookId to URL

* 🚧 add webhookId to webhook entity, 🔧 refactor migrations

* 🚧 🐘 postgres migration

* 🚧 add mySQL migration

* 🚧 refactor mongoDB

* 🚧 add webhookId to IWebhookDb

* 🚧 starting workflow with dynamic route works

*  production dynamic webhooks complete

* 🎨 fix lint issues

* 🔧 dynamic path for webhook-test complete

* 🎨 fix lint issues

* 🎨 fix typescript issue

*  add error message for dynamic webhook-test

* 🔨 improve handling of leading `/`

*  Fix issue that tab-title did not get reset on new workflow

* Revert " Fix issue that tab-title did not get reset on new workflow"

This reverts commit 699d0a8946.

* 🔧 reset params before extraction

* 🐘 removing unique constraint for webhookId

* 🚧 handle multiple webhooks per id

* 🔧 enable webhook-test for multiple WH with same id

* 🐘 add migration for postgres

*  add mysql migration

* 🎨 fix lint issue

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2021-01-23 20:00:32 +01:00
Jan Oberhauser 8ada4534ec Add support for HEAD to HTTP Request Node 2020-12-30 11:00:06 +01:00
Jan Oberhauser 914b90f4a9 👕 Fix lint issue 2020-12-29 12:22:40 +01:00
Jan Oberhauser f9911c65fe Make it possible that Webhook-Node can send custom response 2020-12-14 17:19:20 +01:00
Jan Oberhauser 40c2acd77b 👕 Fix lint issue 2020-10-22 15:46:03 +02:00
Jan Oberhauser fe802c8f76 👕 Fix built issue by fixing lint issues 2020-10-01 15:18:47 +02:00
Jan Oberhauser 5ed86670a8 Make it use of full webhook path more generic 2020-06-10 15:39:15 +02:00
Jan Oberhauser 1f4b8f8999 Small improvements 2020-05-31 21:13:45 +02:00
Jan Oberhauser b187aa49c4 💥 Fix some more node names 2020-05-12 15:45:41 +02:00
Jan Oberhauser 1f4cf08012 🐛 Fix Webhook multipart/form bug #522 2020-04-28 00:24:17 +02:00
Davide Cavestro db2329b26c Webhook: allow setting generic response-headers 2020-04-26 11:01:20 +02:00
Jan Oberhauser 554a32d64d 🐛 Fix issue with wrongly named binary data #423 2020-03-30 14:53:42 +02:00
Jan Oberhauser 8e57009b3b Remove no longer needed code 2020-03-30 13:37:04 +02:00
Jan Oberhauser 6785b1ed46 Add also json-data when Webhook receives binary data 2020-03-25 00:13:40 +01:00
Jan Oberhauser 1534335b58 Improve Webhook receive binary functionality 2020-03-21 23:39:40 +01:00
Jan Oberhauser 4d5a8234b5 🔀 Merge branch 'feature/webhook-binary-data' of https://github.com/RicardoE105/n8n into RicardoE105-feature/webhook-binary-data 2020-03-21 23:01:36 +01:00
ricardo b3fe74a655 added back rawBody field 2020-03-20 18:44:01 -04:00
Jan Oberhauser 122a0c79a3 Use constant for encoding 2020-03-20 22:47:47 +01:00
ricardo 32175a19ca Removed deprecation warning 2020-03-20 15:00:52 -04:00
ricardo 246213ba5d added support to binary data 2020-03-20 14:53:51 -04:00
ricardo ccb445a714 encode file to base64 2020-03-20 11:18:03 -04:00
Jan Oberhauser 6c5145cc6e 👕 Fix lint issue 2020-02-06 21:32:55 -08:00
Ricardo Espinoza c188d77d62 small fix 2020-02-06 11:24:15 -05:00
Ricardo Espinoza 96cc47f8e8 small fix 2020-02-06 11:23:45 -05:00
Ricardo Espinoza ec3421266f multipart data 2020-02-06 11:21:25 -05:00
Jan Oberhauser 2feed92a3f 📚 Improve description of Webhook-Path 2020-01-01 15:55:08 -06:00
Jan Oberhauser 9acb03435a Fix rawBody 2019-12-21 19:03:24 -06:00
Ricardo Espinoza f1bb1f10f3 changes 2019-12-21 15:36:08 -05:00
Ricardo Espinoza 700ca5c85a added rawBody 2019-12-21 12:19:15 -05:00
Jan Oberhauser ded2152d61 Make it possible to return custom content-type and data with
webhook
2019-10-16 14:01:39 +02:00
Jan Margeta 50a342b2fb 👕 Fix typo: IWebhookResonseData->IWebhookResponseData 2019-10-11 13:02:44 +02:00
Jan Oberhauser 4d6e25c28e 💥 Fix typo reponse => response 2019-08-28 17:16:09 +02:00
Jan Oberhauser 1ff456d77c Allow to set HTTP response code on Webhook-Node 2019-08-28 17:03:35 +02:00
Jan Oberhauser 9cb9804eee Initial commit to release 2019-06-23 12:35:23 +02:00