Commit graph

8157 commits

Author SHA1 Message Date
OlegIvaniv b57ec1d6ab fix(editor): Prevent creation of input connections for nodes without input slot (#5425)
* fix(editor): Prevent creation of input connections for nodes without input

* WIP: Workflow checks service and controller

* fix: Created SQLite migration to remove broken connections

* Cleanup & add mysql/posgres migrations

* Linter fixes

* Unify the migration scripts

* Escape migration workflow_entity

* Wrap the migration in try/catch and do not parse nodes and connection if mysql/postgres

* Do migration changes also fro mysql

* refactor: Wrap only the necessary call in try catch block

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-02-09 11:29:34 -06:00
Omar Ajoue 2eb72a6c9f
fix: MySQL migration parses database contents if necessary (fix for MariaDB) (#5441) 2023-02-09 18:15:20 +01:00
Jonathan Bennetts 57a2b9cceb
fix(Linear Node): Fix issue with Issue States not loading correctly (#5435) 2023-02-09 15:58:52 +00:00
Michael Kret 32de081b0c
test(Compression Node): Unit tests (no-changelog) 2023-02-09 17:13:39 +02:00
OlegIvaniv 018f8a3510
fix(editor): Prevent creation of input connections for nodes without input slot (#5425)
* fix(editor): Prevent creation of input connections for nodes without input

* WIP: Workflow checks service and controller

* fix: Created SQLite migration to remove broken connections

* Cleanup & add mysql/posgres migrations

* Linter fixes

* Unify the migration scripts

* Escape migration workflow_entity

* Wrap the migration in try/catch and do not parse nodes and connection if mysql/postgres

* Do migration changes also fro mysql

* refactor: Wrap only the necessary call in try catch block

---------

Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-02-09 16:04:26 +01:00
Milorad FIlipović d9a4c2c66d
test(editor): Add user management e2e tests (#5438)
*  Added initial UM test using new commands
*  Added rest of the UM tests
2023-02-09 16:00:55 +01:00
Mutasem Aldmour b8980f6118
test: Add more data mapping tests (#5389)
* test: Add more data mapping tests

* test: add tests for preview mapping

* test: update wording

* test: add more tests

* test: fix up prev node test

* test: stop popup

* test: add mapping test for paths

* test: revert back param changes

* test: fix mapping tests

* test: reset db

* test: fix up mapping tests

* test: fix up mapping tests

* test: update tests to be more stable

* chore: clean up unused command

* fix: fix up before unload bug

* fix: fix data transformation tests

* test: fix up flaky webhook tests

* test: fix up flaky webhook tests

* test: fix up flaky dt tests
2023-02-09 17:59:01 +03:00
कारतोफ्फेलस्क्रिप्ट™ 00befbc75a
ci(editor): Faster builds on the CI (no-changelog) (#5422) 2023-02-09 15:47:34 +01:00
Marcus e01192e7af
test(Read Binary File Node): Unit tests (no-changelog) (#5436)
 add Read Binary Data node unit test

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-09 15:31:10 +01:00
agobrech fdf47a96de
fix(core): Fix import command for workflows with old format(pre UM) (#5403)
* Replace invalid credentials when importing workflows

* Remove useless console.logs
2023-02-09 15:24:09 +01:00
Michael Kret 1ea1935b9a
test(RSS Read Node): Unit tests (no-changelog) 2023-02-09 16:13:23 +02:00
Valya c7b58e0ed1
fix(core): Expression extension failing with optional chaining (#5370)
* wip

* fix: working optional chaining polyfill

* fix: polyfill optional chaining on extended functions

* test: add optional chaining tests
2023-02-09 13:57:45 +00:00
agobrech 40f4ec75fa
test(Date & Time Node): Unit tests (no-changelog) (#5415)
*  Add tests to DateTime node

* Test different timezone

* Try new fix

* Fix workflow change time of workflow exec in UTC

* Check if UTC is correctly setup

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-02-09 14:54:24 +01:00
Marcus 3e2d76ec79
test(Code Node): Unit tests (no-changelog) (#5373)
*  test setup

* ️basic test with run once for all and each items

* 🎨 fix linting error

* ️update to new Helper.setup(tests)

*  migrate tests to pin data approach
2023-02-09 13:56:39 +01:00
कारतोफ्फेलस्क्रिप्ट™ 172472664d
ci: Upgrade dev tooling (no-changelog) (#5424)
* Typescript
* Jest
* Turborepo
* pnpm
2023-02-09 13:52:41 +01:00
agobrech d4d55b0684
test(Crypto Node): Unit tests (no-changelog) (#5433)
* Add test to Crypto Node

*  added test to generate random uuid

---------

Co-authored-by: Marcus <marcus@n8n.io>
2023-02-09 13:03:53 +01:00
agobrech 43abe225a0
test(Rename Keys Node): Unit tests (no-changelog) (#5428)
Add test for Rename Keys node
2023-02-09 12:26:51 +01:00
कारतोफ्फेलस्क्रिप्ट™ 0fb4d7fc19
fix(core): Stop creating icons directories (no-changelog) (#5431)
forgot to remove this in https://github.com/n8n-io/n8n/pull/5419
2023-02-09 11:45:32 +01:00
Michael Kret 9024e4dcc7
test(Stop and Error Node): Unit tests (no-changelog) 2023-02-09 12:29:02 +02:00
Michael Kret 2150ea0e79
test(HTTP Request Node): Unit tests (no-changelog) 2023-02-09 12:25:26 +02:00
Michael Kret b5948cbe13
test(XML Node): Unit tests (no-changelog) 2023-02-09 12:23:25 +02:00
कारतोफ्फेलस्क्रिप्ट™ 52cb185637
refactor(core): Upgrade typeorm (no-changelog) (#5423)
[Now we can use aggregate functions directly over the repository API](https://github.com/typeorm/typeorm/pull/9737)
2023-02-09 10:44:07 +01:00
Iván Ovejero e0c4c25227
test: Add e2e workflow tags (no-changelog) (#5411)
* 🧪 Add workflow tags tests

*  Create `openTagManagerModal`

*  Add wait to prevent detached DOM element

*  Add wait to mirror other tests
2023-02-09 10:04:12 +01:00
Iván Ovejero a07de049a2
feat(editor): Bring completions to HTML editor (#5382)
 Bring completions to HTML editor
2023-02-09 09:41:07 +01:00
Marcus 74fc1414d7
test(Spreadsheet File Node): Unit tests (no-changelog) (#5385)
* ️test setup

* ️fix  'testData' implicitly has an 'any' type.

*  test github action file binary data reading

*  checking for output binary equality

*  writing files to different formats

*  reading spreadsheet with different options

* ️improve workflow file path replacement

* 🐛 fixing string.at() not supported in node 14.

* 🐛 trying to fix github action test error

*  fix for empty binary

*  switch for binary test

* ️test helpers now return/compare json and binary (if not empty))

*  removed commented console log

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-09 09:00:29 +01:00
कारतोफ्फेलस्क्रिप्ट™ 94f2b2a26f
feat(Edit Image Node): Allow WebP as an image format (#5420) 2023-02-08 23:08:50 +01:00
Alex Grozav e059caf993
feat: Add e2e user invite test suite (no-changelog) (#5412) 2023-02-08 22:41:35 +02:00
Valya 9c1f827dad
feat(core): Live reload node/credential descriptions in development (no-changelog) (#4939) 2023-02-08 19:26:07 +01:00
कारतोफ्फेलस्क्रिप्ट™ f23fb92696
fix(core): Stop copying icons to cache (#5419)
Fixes 

- https://github.com/n8n-io/n8n/issues/4973
- https://github.com/n8n-io/n8n/issues/5274
- https://community.n8n.io/t/starting-n8n-fails-with-ebusy-error/21243
- https://community.n8n.io/t/problem-executing-workflow-ebusy-resource-busy-or-locked-copyfile/21280

Replaces

- https://github.com/n8n-io/n8n/pull/5052
- https://github.com/n8n-io/n8n/pull/5401
2023-02-08 18:57:43 +01:00
Marcus 1f924e3c3d
test(Set Node): Add tests for Set Node (no-changelog) (#5409)
* ️move test files

*  set node test workflow

---------

Co-authored-by: Michael Kret <michael.k@radency.com>
2023-02-08 18:04:11 +01:00
Marcus 269691aa1b
test(IF Node): Unit tests (no-changelog) (#5404)
* ️move test files

* ️IF boolean tests

* ️IF string tests

*  IF number tests

*  IF date-time tests

* 🎨 update Test name to make more sense
2023-02-08 15:20:17 +01:00
OlegIvaniv 14d1743595
test(editor): Add canvas dragging tests (no-changelog) (#5406)
* WIP

* Fix undo/redo tests and add canvas tests

* Cleanup

* Cleanup

* Use drag and draganddrop commands

* Fix hanging CI run

* Undo redo spec
2023-02-08 14:48:28 +01:00
Giulio Andreini 389e4af4d9
docs(Spreadsheet File Node): Update descriptions and Alias (no-changelog) (#5357) 2023-02-08 12:39:07 +00:00
Kirill 333a817a8e
fix(ActiveCampaign Node): Fix additional fields not being sent when updating account contacts (#5216) 2023-02-08 12:37:15 +00:00
Bram Kn aeaa663620
feat(HubSpot Trigger Node): Add conversation events (#5408) 2023-02-08 12:36:05 +00:00
Giulio Andreini b16d9d0f8c
docs(Google Sheets Node): Description updates for fields (no-changelog) (#5277) 2023-02-08 12:33:57 +00:00
Jonathan Bennetts ce732b42c8
test(Execute Command Node): Unit tests (no-changelog) (#5374) 2023-02-08 12:17:02 +00:00
Jonathan Bennetts e82bc50fd1
test(Switch Node): Add test for switch node (no-changelog) (#5378) 2023-02-08 12:16:17 +00:00
Jonathan Bennetts f44b4b1314
test(Split In Batches Node): Add test for Split in Batches node (no-changelog) (#5381) 2023-02-08 12:15:36 +00:00
Iván Ovejero d7b3923c2f
feat(editor): Add Object global completions (#5407)
* ✏️ Add i18n info

*  Mount i18n keys

* ✏️ Fix typos in tests

*  Add `Object` global completion

*  Add `Object` global options completions

* 🧪 Add tests
2023-02-08 12:41:33 +01:00
Cornelius Suermann d469a98073
feat: Add tracking code to hiring link (no-changelog) (#3530) 2023-02-08 11:48:38 +01:00
Omar Ajoue 5e3e70b83b
feat: Change desktop UM experience (#5312)
* refactor: Hide prompt for desktop

* feat: add email field to personalization modal

* fix: update survey interfaces

* chore: enable personalization survey email key display condition

* feat: add users page upsell for desktop client

* feat: disable UM on desktop where possible

* refactor: Have a single function to decide whether UM is enabled

* feat: update community nodes upsell link

---------

Co-authored-by: Alex Grozav <alex@grozav.com>
Co-authored-by: krynble <omar@n8n.io>
Co-authored-by: freyamade <freya@n8n.io>
2023-02-08 11:42:22 +02:00
Iván Ovejero d8865aa917
test: Add e2e for data transformation expressions (#5375)
* 🧪 Add e2e for data transormation expressions

* ♻️ Apply feedback
2023-02-08 10:41:36 +01:00
Michael Kret 4d87711ace
test(Merge Node): Unit tests (no-changelog) 2023-02-07 19:32:25 +02:00
Michael Auerswald 9fb1fa1d79
ci: Add E2E tests for Webhook node (#5402)
* scheduler e2e test and switch to main mode

* adjust e2e options

* rolling back config changes

* webhook e2e tests and disable cypress retries on openmode

* cleanup
2023-02-07 17:51:11 +01:00
Omar Ajoue c8245b9f87
fix: Error workflow now correctly checks for subworkflow permissions (#5390) 2023-02-07 17:40:36 +01:00
Milorad FIlipović d05203db30
test(editor): Enable adding nodes in between any two nodes on canvas in e2e tests (no-changelog) (#5393)
*  Adding source and target test data to connection HTML elements
*  Using new action to add node on the connection
* 🔥 Removing leftover log
* 🔥 Removing leftover test action
* 👌 Refactoring to address PR feedback
2023-02-07 16:34:08 +01:00
कारतोफ्फेलस्क्रिप्ट™ 7e2f2f7453
refactor(core): Add unit tests for all external auth middlewares (no-changelog) (#5386) 2023-02-07 15:49:35 +01:00
कारतोफ्फेलस्क्रिप्ट™ 3a435f7057
fix(core): Disable transactions on sqlite migrations that use PRAGMA foreign_keys (#5392)
`PRAGMA foreign_keys` is [a no-op within a sqlite transaction](https://www.sqlite.org/pragma.html#pragma_foreign_keys).
This causes cascade deletes to happen when we create a new user table, and drop the old user table.
2023-02-07 15:14:59 +01:00
Michael Auerswald dd652c0b0d
ci: Add E2E test for scheduled trigger (#5391)
* scheduler e2e test and switch to main mode

* adjust e2e options

* rolling back config changes
2023-02-07 12:41:44 +01:00