Commit graph

26 commits

Author SHA1 Message Date
Iván Ovejero 1d27a9e87e
Improve node error handling (#1309)
* Add path mapping and response error interfaces

* Add error handling and throwing functionality

* Refactor error handling into a single function

* Re-implement error handling in Hacker News node

* Fix linting details

* Re-implement error handling in Spotify node

* Re-implement error handling in G Suite Admin node

* 🚧 create basic setup NodeError

* 🚧 add httpCodes

* 🚧 add path priolist

* 🚧 handle statusCode in error, adjust interfaces

* 🚧 fixing type issues w/Ivan

* 🚧 add error exploration

* 👔 fix linter issues

* 🔧 improve object check

* 🚧 remove path passing from NodeApiError

* 🚧 add multi error + refactor findProperty method

* 👔 allow any

* 🔧 handle multi error message callback

*  change return type of callback

*  add customCallback to MultiError

* 🚧 refactor to use INode

* 🔨 handle arrays, continue search after first null property found

* 🚫 refactor method access

* 🚧 setup NodeErrorView

*  change timestamp to Date.now

* 📚 Add documentation for methods and constants

* 🚧 change message setting

* 🚚 move NodeErrors to workflow

*  add new ErrorView for Nodes

* 🎨 improve error notification

* 🎨 refactor interfaces

*  add WorkflowOperationError, refactor error throwing

* 👕 fix linter issues

* 🎨 rename param

* 🐛 fix handling normal errors

*  add usage of NodeApiError

* 🎨 fix throw new error instead of constructor

* 🎨 remove unnecessary code/comments

* 🎨 adjusted spacing + updated status messages

* 🎨 fix tab indentation

*  Replace current errors with custom errors (#1576)

*  Introduce NodeApiError in catch blocks

*  Introduce NodeOperationError in nodes

*  Add missing errors and remove incompatible

*  Fix NodeOperationError in incompatible nodes

* 🔧 Adjust error handling in missed nodes

PayPal, FileMaker, Reddit, Taiga and Facebook Graph API nodes

* 🔨 Adjust Strava Trigger node error handling

* 🔨 Adjust AWS nodes error handling

* 🔨 Remove duplicate instantiation of NodeApiError

* 🐛 fix strava trigger node error handling

* Add XML parsing to NodeApiError constructor (#1633)

* 🐛 Remove type annotation from catch variable

*  Add XML parsing to NodeApiError

*  Simplify error handling in Rekognition node

*  Pass in XML flag in generic functions

* 🔥 Remove try/catch wrappers at call sites

* 🔨 Refactor setting description from XML

* 🔨 Refactor let to const in resource loaders

*  Find property in parsed XML

*  Change let to const

* 🔥 Remove unneeded try/catch block

* 👕 Fix linting issues

* 🐛 Fix errors from merge conflict resolution

*  Add custom errors to latest contributions

* 👕 Fix linting issues

*  Refactor MongoDB helpers for custom errors

* 🐛 Correct custom error type

*  Apply feedback to A nodes

*  Apply feedback to missed A node

*  Apply feedback to B-D nodes

*  Apply feedback to E-F nodes

*  Apply feedback to G nodes

*  Apply feedback to H-L nodes

*  Apply feedback to M nodes

*  Apply feedback to P nodes

*  Apply feedback to R nodes

*  Apply feedback to S nodes

*  Apply feedback to T nodes

*  Apply feedback to V-Z nodes

*  Add HTTP code to iterable node error

* 🔨 Standardize e as error

* 🔨 Standardize err as error

*  Fix error handling for non-standard nodes

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>

Co-authored-by: Ben Hesseldieck <b.hesseldieck@gmail.com>
Co-authored-by: Ben Hesseldieck <1849459+BHesseldieck@users.noreply.github.com>
2021-04-16 18:33:36 +02:00
Ricardo Espinoza da450dcb41
Add label field to persons, organizations and deals (#1209)
*  Add label field to persons, organizations and deals

*  Add option no label to label field

*  Add organization:update operation

*  Fix removing label from Organization on Pipedrive-Node

Co-authored-by: Jan Oberhauser <jan.oberhauser@gmail.com>
2020-12-07 23:44:10 +01:00
Jan Oberhauser 40c2acd77b 👕 Fix lint issue 2020-10-22 15:46:03 +02:00
Jan Oberhauser 34503e1ce7 🔀 Merge branch 'master' of github.com:n8n-io/n8n 2020-10-13 23:16:39 +02:00
Jan Oberhauser 443cef4de3 Small improvements to Pipedrive-Node 2020-10-13 23:07:45 +02:00
Robarelli 75e4086f6b
Add additional parameters to Pipedrive getAll for Notes (#1027)
* Add additional parameters to Pipedrive notes getAll

* use existing addAdditionalFields for merging additional fields into the query string
2020-10-13 23:07:21 +02:00
Rob Cunning 62afc8a2fd use existing addAdditionalFields for merging additional fields into the query string 2020-10-08 14:55:51 -06:00
Rob Cunning 6f229f1f47 Add additional parameters to Pipedrive notes getAll 2020-10-08 00:25:57 -06:00
Jan Oberhauser fe802c8f76 👕 Fix built issue by fixing lint issues 2020-10-01 15:18:47 +02:00
smamudhan 725d2d16fc
Fixed typos and grammatical errors (#791)
* 🐛 Fixed typos and grammatical errors

* 🐛 Made changes based on Tanay's feedback
2020-07-24 12:56:41 +02:00
ricardo 28fcaf79ae 🐛 Fix merge issues 2020-07-23 17:10:26 -04:00
ricardo b187a8fd7d Merge branch 'Master' into 'Pipedrive-OAuth2-support' 2020-07-23 16:51:05 -04:00
Rupenieks c1b4c570fd re-added basicAuth for authentication 2020-06-24 16:02:44 +02:00
Rupenieks 48765b7db6 OAuth2 support 2020-06-09 15:48:40 +02:00
Jan Oberhauser d6134ec405 Add Deal.duplicate functionality to Pipedrive-Node 2019-11-02 21:41:13 +01:00
Jan Oberhauser 60165d5fe2 Allow to automatically encode custom values with Pipedrive update 2019-10-22 11:30:35 +02:00
Jan Oberhauser a24918021c Add resource "files" to Pipedrive-Node 2019-09-03 23:06:03 +02:00
Jan Oberhauser 83826000d3 Add resource "notes" to Pipedrive-Node 2019-09-02 22:26:42 +02:00
Jan Oberhauser be3177a101 Add option to resolve custom values and add getAll option for
activities and deals to Pipedrive-Node
2019-08-28 08:20:53 +02:00
Jan Oberhauser a0aea3000e 💄 Add subtitle to NextCloud and Pipedrive-Node 2019-07-14 18:55:04 +02:00
Jan Oberhauser 1217fcf5ff Update operation selection on Pipedrive-Node 2019-07-14 17:57:08 +02:00
Jan Oberhauser d80b703dfd Add more functionality to Pipedrive-Node 2019-07-10 10:16:48 +02:00
Jan Oberhauser 1cc00d9101 Add more functionality to Pipedrive-Node 2019-07-10 08:40:59 +02:00
Jan Oberhauser bcaddecdd6 💄 Add description to field on Pipedrive-Node 2019-07-07 19:01:05 +02:00
Jan Oberhauser 4e6d9caa71 Fix Pipedrive description 2019-06-24 07:24:47 +02:00
Jan Oberhauser f26199f690 Add first basic support for Pipedrive 2019-06-23 21:21:44 +02:00