Val
74fc3889b9
fix(core): Sanitise IdP provided information in SAML test pages ( #11171 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-10-23 13:22:15 +02:00
Iván Ovejero
3a9c65e1cb
refactor(core): Modernize logger service ( #11031 )
Test Master / install-and-build (push) Waiting to run
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Test Master / Lint (push) Blocked by required conditions
Test Master / Notify Slack on failure (push) Blocked by required conditions
Benchmark Docker Image CI / build (push) Waiting to run
2024-10-01 12:16:09 +02:00
Tomi Turtiainen
5156313074
refactor(core): Enable import/order eslint rule ( #10794 )
Test Master / install-and-build (push) Waiting to run
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Test Master / Lint (push) Blocked by required conditions
Test Master / Notify Slack on failure (push) Blocked by required conditions
Benchmark Docker Image CI / build (push) Waiting to run
2024-09-12 19:07:18 +03:00
Iván Ovejero
6485ca0a4b
refactor(core): Enforce filename casing in cli package (no-changelog) ( #10594 )
2024-08-28 17:57:46 +02:00
कारतोफ्फेलस्क्रिप्ट™
ab9835126e
refactor(core): Use @/databases/ instead of @db/ (no-changelog) ( #10573 )
Test Master / install-and-build (push) Waiting to run
Test Master / Unit tests (18.x) (push) Blocked by required conditions
Test Master / Unit tests (20.x) (push) Blocked by required conditions
Test Master / Unit tests (22.4) (push) Blocked by required conditions
Test Master / Lint (push) Blocked by required conditions
Test Master / Notify Slack on failure (push) Blocked by required conditions
Benchmark Docker Image CI / build (push) Waiting to run
2024-08-27 17:24:20 +02:00
Iván Ovejero
fd58a272e1
refactor(core): Standardize filename casing for controllers and databases (no-changelog) ( #10564 )
2024-08-27 16:44:32 +02:00
Iván Ovejero
f667b384c9
refactor(core): Standardize filenames in cli (no-changelog) ( #10484 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-08-22 11:10:37 +02:00
Tomi Turtiainen
afa43e75f6
test(core): Move unit tests closer to testable components (no-changelog) ( #10287 )
2024-08-05 12:12:25 +03:00
Iván Ovejero
aa0a470dce
refactor(core): Clean up event relays (no-changelog) ( #10284 )
2024-08-02 16:52:49 +02:00
Iván Ovejero
aba1c64500
refactor(core): Rename EventRelay to EventService (no-changelog) ( #10110 )
2024-07-19 12:55:38 +02:00
Iván Ovejero
44ea4c73eb
refactor: Remove unused lint directives (no-changelog) ( #9842 )
2024-06-24 12:13:18 +02:00
Iván Ovejero
199dff4fb3
refactor(core): Decouple event bus from internal hooks (no-changelog) ( #9724 )
2024-06-20 12:32:22 +02:00
कारतोफ्फेलस्क्रिप्ट™
65c5609ab5
feat(core): Use WebCrypto to generate all random numbers and strings ( #9786 )
2024-06-19 13:33:57 +02:00
Csaba Tuncsik
596c472ecc
feat: RBAC ( #8922 )
...
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Val <68596159+valya@users.noreply.github.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Valya Bullions <valya@n8n.io>
Co-authored-by: Danny Martini <danny@n8n.io>
Co-authored-by: Danny Martini <despair.blue@gmail.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
Co-authored-by: oleg <me@olegivaniv.com>
Co-authored-by: Michael Kret <michael.k@radency.com>
Co-authored-by: Michael Kret <88898367+michael-radency@users.noreply.github.com>
Co-authored-by: Elias Meire <elias@meire.dev>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
Co-authored-by: Giulio Andreini <g.andreini@gmail.com>
Co-authored-by: Ayato Hayashi <go12limchangyong@gmail.com>
2024-05-17 10:53:15 +02:00
Danny Martini
225fdbb379
fix(core): Report missing SAML attributes early with an actionable error message ( #9316 )
2024-05-07 10:27:44 +02:00
कारतोफ्फेलस्क्रिप्ट™
9403657e46
refactor(core): Remove unnecessary indirection in SAML code (no-changelog) ( #9103 )
2024-04-10 10:55:49 +02:00
कारतोफ्फेलस्क्रिप्ट™
28261047c3
feat(core): Prevent session hijacking ( #9057 )
2024-04-09 11:20:35 +02:00
कारतोफ्फेलस्क्रिप्ट™
db4a419c8d
refactor(core): Enforce authorization by default on all routes (no-changelog) ( #8762 )
2024-02-28 17:02:18 +01:00
कारतोफ्फेलस्क्रिप्ट™
2811f77798
refactor(core): Rename RequireGlobalScope to GlobalScope (no-changelog) ( #8760 )
2024-02-28 14:40:02 +01:00
कारतोफ्फेलस्क्रिप्ट™
56c8791aff
refactor(core): Remove all legacy auth middleware code (no-changelog) ( #8755 )
2024-02-28 13:12:28 +01:00
Tomi Turtiainen
05e13a68ea
fix: Fix typeorm .save usage (no-changelog) ( #8678 )
2024-02-20 17:34:54 +02:00
कारतोफ्फेलस्क्रिप्ट™
d6deceacde
refactor(core): Remove roleId indirection (no-changelog) ( #8413 )
2024-01-24 13:38:57 +01:00
Tomi Turtiainen
9a1cc56806
fix: Set '@typescript-eslint/return-await' rule to 'always' for node code (no-changelog) ( #8363 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2024-01-17 17:08:50 +02:00
Omar Ajoue
8c7f39907f
fix: Properly output saml validation errors ( #8284 )
2024-01-10 16:56:04 +01:00
कारतोफ्फेलस्क्रिप्ट™
f69ddcd796
refactor(core): Use Dependency Injection for all Controller classes (no-changelog) ( #8146 )
...
## Review / Merge checklist
- [x] PR title and summary are descriptive
2023-12-27 11:50:43 +01:00
कारतोफ्फेलस्क्रिप्ट™
baee47a276
refactor(core): Move all base URLs to UrlService (no-changelog) ( #8141 )
...
This change kept coming up in #6713 , #7773 , and #8135 .
So this PR moves the existing code without actually changing anything,
to help get rid of some of the circular dependencies.
## Review / Merge checklist
- [x] PR title and summary are descriptive.
2023-12-22 15:19:50 +01:00
Iván Ovejero
c378f60a25
refactor(core): Introduce password utility (no-changelog) ( #7979 )
...
## Summary
Provide details about your pull request and what it adds, fixes, or
changes. Photos and videos are recommended.
Continue breaking down `UserManagementHelper.ts`
...
#### How to test the change:
1. ...
## Issues fixed
Include links to Github issue or Community forum post or **Linear
ticket**:
> Important in order to close automatically and provide context to
reviewers
...
## Review / Merge checklist
- [ ] PR title and summary are descriptive. **Remember, the title
automatically goes into the changelog. Use `(no-changelog)` otherwise.**
([conventions](https://github.com/n8n-io/n8n/blob/master/.github/pull_request_title_conventions.md ))
- [ ] [Docs updated](https://github.com/n8n-io/n8n-docs ) or follow-up
ticket created.
- [ ] Tests included.
> A bug is not considered fixed, unless a test is added to prevent it
from happening again. A feature is not complete without tests.
>
> *(internal)* You can use Slack commands to trigger [e2e
tests](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#a39f9e5ba64a48b58a71d81c837e8227 )
or [deploy test
instance](https://www.notion.so/n8n/How-to-use-Test-Instances-d65f49dfc51f441ea44367fb6f67eb0a?pvs=4#f6a177d32bde4b57ae2da0b8e454bfce )
or [deploy early access version on
Cloud](https://www.notion.so/n8n/Cloudbot-3dbe779836004972b7057bc989526998?pvs=4#fef2d36ab02247e1a0f65a74f6fb534e ).
2023-12-11 18:23:42 +01:00
Iván Ovejero
c08c5cc37b
refactor(core): Switch plain errors in cli to ApplicationError ( #7857 )
...
Ensure all errors in `cli` are `ApplicationError` or children of it and
contain no variables in the message, to continue normalizing all the
errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7839
2023-11-29 12:25:10 +01:00
Val
a37f1cb0ba
feat: Add initial scope checks via decorators ( #7737 )
2023-11-28 11:41:34 +00:00
Iván Ovejero
1c6178759c
refactor(core): Reorganize error hierarchy in cli package (no-changelog) ( #7839 )
...
Ensure all errors in `cli` inherit from `ApplicationError` to continue
normalizing all the errors we report to Sentry
Follow-up to: https://github.com/n8n-io/n8n/pull/7820
2023-11-28 10:19:27 +01:00
कारतोफ्फेलस्क्रिप्ट™
000e76e3b4
ci(core): Reduce memory usage in tests (part-2) (no-changelog) ( #7671 )
...
This also gets rid of `Db.collection`, which was another source of
circular dependencies.
2023-11-10 15:04:26 +01:00
कारतोफ्फेलस्क्रिप्ट™
05586a900d
refactor(core): Make Logger a service (no-changelog) ( #7494 )
2023-10-25 16:35:22 +02:00
Iván Ovejero
7ce5d8fd90
refactor: Upgrade to Prettier 3 (no-changelog) ( #6947 )
...
Supersedes https://github.com/n8n-io/n8n/pull/6937
Excluding fixtures and test workflow JSONs to avoid having to update
tests.
2023-08-16 17:13:57 +02:00
Iván Ovejero
e4f041815a
perf(core): Cache roles ( #6803 )
...
* refactor: Create `RoleService`
* refactor: Refactor to use service
* refactor: Move `getUserRoleForWorkflow`
* refactor: Clear out old `RoleService`
* refactor: Consolidate utils into service
* refactor: Remove unused methods
* test: Add tests
* refactor: Remove redundant return types
* refactor: Missing utility
* chore: Remove commented out bit
* refactor: Make `Db.collections.Repository` inaccessible
* chore: Cleanup
* feat: Prepopulate cache
* chore: Remove logging
* fix: Account for tests where roles are undefined
* fix: Restore `prettier.prettierPath`
* test: Account for cache enabled and disabled
* fix: Restore `Role` in `Db.collections`
* refactor: Simplify by removing `orFail`
* refactor: Rename for clarity
* refactor: Use `cacheKey` for readability
* refactor: Validate role before creation
* refacator: Remove redundant `cache` prefix
* ci: Lint fix
* test: Fix e2e
2023-08-03 08:58:36 +02:00
Iván Ovejero
72523462ea
refactor: Clear unused ESLint directives from BE packages (no-changelog) ( #6798 )
2023-07-31 11:00:48 +02:00
Michael Auerswald
08331c63fb
fix(core): Redirect user to previous url after SSO signin ( #6710 )
...
redirect user to previous url after SSO signin
2023-07-20 17:23:29 +02:00
Michael Auerswald
fce5609fa3
fix(core): Load SAML libraries dynamically ( #6690 )
...
load SAML dynamically
2023-07-18 16:01:56 +02:00
Michael Auerswald
eedde24cc0
fix(core): Use lower cased email for SAML email attribute ( #6663 )
...
lower case saml email attribute
2023-07-13 23:41:52 +02:00
कारतोफ्फेलस्क्रिप्ट™
b895ba438a
refactor(core): Reduce boilterplate code in between tests 🧹 , and fix the tests in node.js 20 (no-changelog) ( #6654 )
...
refactor(core): Reduce boilterplate code in between tests
also cleaned up some imports, and fixed the tests in node.js 20
2023-07-13 10:14:48 +02:00
OlegIvaniv
e5620ab1e4
feat(API): Implement users account quota guards ( #6434 )
...
* feat(cli): Implement users account quota guards
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Remove comment
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Address PR comments
- Getting `usersQuota` from `Settings` repo
- Revert `isUserManagementEnabled` helper
- Fix FE listing of users
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Refactor isWithinUserQuota getter and fix tests
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Revert testDb.ts changes
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Cleanup & improve types
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix duplicated method
* Fix failing test
* Remove `isUserManagementEnabled` completely
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Check for globalRole.name to determine if user is owner
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Fix unit tests
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Set isInstanceOwnerSetUp in specs
* Fix SettingsUserView UM
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* refactor: License typings suggestions for users quota guards (#6636 )
refactor: License typings suggestions
* Update packages/cli/src/Ldap/helpers.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Update packages/cli/test/integration/shared/utils.ts
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
* Address PR comments
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
* Use 403 for all user quota related errors
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
---------
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-07-12 14:11:46 +02:00
Iván Ovejero
8c008f5d22
refactor(core)!: Remove basic-auth, external-jwt-auth, and no-auth options ( #6362 )
...
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-06-22 20:03:47 +02:00
Michael Auerswald
25fe14be56
fix(core): Remove SAML config metadataUrl if XML metadata is set directly ( #6143 )
...
remove metadataUrl if metadata is set directly
2023-05-02 11:22:34 +02:00
Michael Auerswald
c0b1cddc91
fix(core): Improve saml endpoints and audit events ( #6107 )
...
* update saml endpoints and login audit
* fix(core): Skip auth for controllers/routes that don't use the `Authorized` decorator
* fix linting
* lint fix
* add tests and fix endpoint permission
* add hook test
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-04-28 18:11:33 +02:00
कारतोफ्फेलस्क्रिप्ट™
308a94311f
refactor: Async functions don't need to explicitly return promises (no-changelog) ( #6041 )
2023-04-24 13:17:08 +02:00
Jimw383
03be725cef
SSO/SAML : add Base URL to redirects in acsHandler ( #5923 )
...
add Base URL to redirects in acsHandler
I modified the redirections to include the base URL of the instance so that the redirects remain correct even if the instance is accessed from a subdirectory.
Co-authored-by: Michael Auerswald <michael.auerswald@gmail.com>
2023-04-24 12:36:50 +02:00
कारतोफ्फेलस्क्रिप्ट™
1eeadc6114
refactor(core): Setup decorator based RBAC (no-changelog) ( #5787 )
2023-04-24 11:45:31 +02:00
Michael Auerswald
71ed1f410c
feat(core): Add SSH key generation ( #6006 )
...
* basic prefs and ssh key generation
* review change
* cleanup save
* lint fix
2023-04-19 17:46:10 +02:00
Michael Auerswald
4c994faec1
fix(core): Improve SAML connection test result views ( #5981 )
...
* improve test result views
* refactor
* lint fix
2023-04-14 15:49:10 +02:00
Iván Ovejero
1a8a9f8ddb
fix(core): Fix lint on SAML controller (no-changelog) ( #5967 )
...
* 👕 Fix lint on SAML controller
* 📘 Type request properly
* Update requests.ts
* 🚚 Move type to module
Assuming ACS falls under configuration.
---------
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-04-13 14:14:55 +02:00
Michael Auerswald
8474cd386d
fix(core): Skip SAML onboarding for users with first- and lastname ( #5966 )
...
skip onboarding for users with first- and lastname
2023-04-13 10:09:50 +02:00
