Commit graph

8624 commits

Author SHA1 Message Date
कारतोफ्फेलस्क्रिप्ट™ f0fc5b16d3
ci(core): Load config schema after process.env has been overwritten (no-changelog) (#7550) 2023-11-07 15:58:28 +01:00
कारतोफ्फेलस्क्रिप्ट™ 60314248f4
fix(core): Make password-reset urls valid only for single-use (#7622) 2023-11-07 15:35:43 +01:00
Ricardo Espinoza b3470fd64d
fix: Error handling on forgot password page (no-changelog) (#7633)
fixes:
https://linear.app/n8n/issue/ADO-1339/fix-error-handling-on-forgot-password-page
2023-11-07 08:45:58 -05:00
कारतोफ्फेलस्क्रिप्ट™ 2f665683fc
ci: Improve CI performance (no-changelog) (#7637)
1. Split backend and frontend tests to avoid them running in parallel
2. Enable coverage only on `master`
2023-11-07 14:19:39 +01:00
Iván Ovejero f748de9567
fix(core): Ensure pruning starts only after migrations have completed (#7626)
https://linear.app/n8n/issue/PAY-986/bug-execution-pruning-timer-is-started-before-the-database-is-ready

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-11-07 13:56:01 +01:00
Iván Ovejero c857e42677
feat(core): Coordinate workflow activation in multiple main scenario in internal API (#7566)
Story: https://linear.app/n8n/issue/PAY-926

This PR coordinates workflow activation on instance startup and on
leadership change in multiple main scenario in the internal API. Part 3
on manual workflow activation and deactivation will be a separate PR.

### Part 1: Instance startup

In multi-main scenario, on starting an instance...
- [x] If the instance is the leader, it should add webhooks, triggers
and pollers.
- [x] If the instance is the follower, it should not add webhooks,
triggers or pollers.
- [x] Unit tests.

### Part 2: Leadership change 

In multi-main scenario, if the main instance leader dies…

- [x] The new main instance leader must activate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] The old main instance leader must deactivate all trigger- and
poller-based workflows, excluding webhook-based workflows.
- [x] Unit tests.

To test, start two instances and check behavior on startup and
leadership change:

```
EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug npm run start

EXECUTIONS_MODE=queue N8N_LEADER_SELECTION_ENABLED=true N8N_LICENSE_TENANT_ID=... N8N_LICENSE_ACTIVATION_KEY=... N8N_LOG_LEVEL=debug N8N_PORT=5679 npm run start
```
2023-11-07 13:48:48 +01:00
Mutasem Aldmour 151e60f829
fix(editor): Fix local storage flags defaulting to undefined string (#7603)
useStorage takes the default value `undefined` and sets it in local
storage.. also returns "undefined" as string which breaks onboarding
flows

Github issue / Community forum post (link here to close automatically):
2023-11-07 10:06:08 +01:00
Csaba Tuncsik 78b84af8d1
fix(editor): Reset canvas zoom before workspace reset in node view (#7625) 2023-11-06 18:15:49 +01:00
कारतोफ्फेलस्क्रिप्ट™ 4934462b41
fix(editor): More dark-mode fixes (no-changelog) (#7624)
This fixes:
1. The `OR` divider background when SSO Login is enabled
2. Scanning of QR code in settings in dark mode
2023-11-06 14:32:38 +01:00
Iván Ovejero 26361dfcd3
fix(core): Fix accessor error when running partial execution (#7618)
https://n8nio.sentry.io/issues/3760335947

Followup to #6229
2023-11-06 13:48:13 +01:00
Jan Oberhauser db56a9ee37
fix(editor): Fix issue that frontend breaks with unkown nodes (#7596)
Because of recent changes does the frontend break when a node is not
known.

![Screenshot from 2023-11-03
08-27-43](https://github.com/n8n-io/n8n/assets/6249596/ab340c3c-9b72-4220-b1f8-70d80f7a5522)



Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-11-06 13:44:05 +01:00
Iván Ovejero a994ba5e8d
fix(core): Ensure init before checking leader or follower in multi-main scenario (#7621)
This PR ensures `MultiMainInstancePublisher` is initialized before
checking if the instance is leader or follower. Followers skip license
init, license check, and pruning start and stop.
2023-11-06 12:03:35 +01:00
Iván Ovejero 52f655f3d2
refactor(Google Sheets Node): Stop reporting to Sentry sheet not found error (no-changelog) (#7617)
https://n8nio.sentry.io/issues/4264383378
2023-11-06 11:36:22 +01:00
Ricardo Espinoza b11c4de039
fix(editor): Focus mfa token input (no-changelog) (#7610)
Github issue / Community forum post (link here to close automatically):
2023-11-04 20:34:05 -04:00
Ricardo Espinoza 5790e251b8
feat(core): Rate limit forgot password endpoint (#7604)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
2023-11-03 13:44:12 -04:00
कारतोफ्फेलस्क्रिप्ट™ acec9bad71
refactor(core): Convert OAuth1/OAuth2 routes to decorated controller classes (no-changelog) (#5973) 2023-11-03 17:20:54 +01:00
Omar Ajoue c6049a2e97
feat(editor): Fix some UTM tags (no-changelog) (#7583)
Github issue / Community forum post (link here to close automatically):
2023-11-03 16:17:39 +01:00
Alex Grozav 24dfc95974
feat(editor): Improve performance by importing routes dynamically and add route guards (no-changelog) (#7567)
**Before:**
<img width="657" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/0bcced2b-9d3a-43b3-80d7-3c72619941fa">


**After:**
<img width="660" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/e74e0bbf-bf33-49b4-ae11-65f640405ac8">
2023-11-03 16:22:37 +02:00
Elias Meire c92402a3ca
fix(editor): Zoom in/out on canvas the same amount on scroll/gesture (#7602)
Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/ctrl-mousewheel-zoom-jumps-out-possible-to-avoid/31952
2023-11-03 14:09:18 +01:00
कारतोफ्फेलस्क्रिप्ट™ 0bd4e742da
refactor(core): Migrate from crypto-js to native crypto (#7556)
[`crypto-js` has been
discontinued](1da3dabf93)

PS: We'll remove `crypto-js` usage from `n8n-workflow` and
`@n8n_io/license-sdk` in separate PRs.
2023-11-03 13:26:20 +01:00
Alex Grozav 135f9214f5
feat(editor): Update storybook to 7.5.2 (no-changelog) (#7601)
Github issue / Community forum post (link here to close automatically):
2023-11-03 14:14:51 +02:00
Tomi Turtiainen 2aa7f6375a
fix(core): Decrease reset password token expire time (#7598)
Decrease the expiration time from 1 day to 20 minutes

Github issue / Community forum post (link here to close automatically):
2023-11-03 13:32:08 +02:00
Jan Oberhauser b532a7bdb7
fix(editor): Hide not supported node options (#7597)
Currently Trigger-Nodes and Sub-Nodes display options that do not make
sense or work like:
- Always Output Data
- Execute Once
- On Error

This PR hides those options for nodes that can not make use of them
anyway to not confuse users.

Github issue / Community forum post (link here to close automatically):
2023-11-03 12:18:00 +01:00
Csaba Tuncsik 85e1a10021
refactor(editor): Simplify data count in NDV (no-changelog) (#7568) 2023-11-03 12:07:04 +01:00
Iván Ovejero 6d42fad31a
refactor(core): Consolidate binary file not found errors (no-changelog) (#7585)
Logging was originally to see if there was a binary data file failing to
be written for [this
user](https://linear.app/n8n/issue/PAY-844/filesystem-binary-data-mode-causing-alerts-in-cloud)
but the cause was not a file failed to be written but a missing `fileId`
in a binary data item in an execution. The error should no longer be
thrown as of 1.12. See story for more info.

This PR is for cleanup and to consolidate any file not found errors in
the context of binary data, to track if this happens again.
2023-11-03 11:41:15 +01:00
Jon e6d3d1a4c2
feat(LinkedIn Node): Add support for Article thumbnails (#7489)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/linkedin-post-not-showing-image-for-url/10789/


![image](https://github.com/n8n-io/n8n/assets/4688521/5142b984-f531-4731-8510-c7136087861e)

This adds a new property to add a thumbnail binary property for articles
this fixes the previews no longer working because of the LinkedIn API
change.

![image](https://github.com/n8n-io/n8n/assets/4688521/76271525-5791-4bdc-ae73-1fdbb3986694)
2023-11-03 09:50:28 +00:00
Milorad FIlipović 9c55702661
fix(editor): Fix flaky ResourceMapper unit tests (no-changelog) (#7593)
Github issue / Community forum post (link here to close automatically):
2023-11-03 09:56:19 +01:00
कारतोफ्फेलस्क्रिप्ट™ bb2c266e48 Merge tag 'n8n@1.15.1' 2023-11-02 18:11:06 +01:00
Iván Ovejero d633753687
fix(editor): Remove unknown credentials on pasting workflow (#7582)
https://linear.app/n8n/issue/PAY-881
2023-11-02 17:26:39 +01:00
Iván Ovejero 81f43805aa
refactor(core): Stop reporting to Sentry node parameter value extraction failure (no-changelog) (#7587)
https://n8nio.sentry.io/issues/4595192919
2023-11-02 16:28:44 +01:00
Mutasem Aldmour 2854a0cf46
fix(editor): Allow overriding theme from query params (#7591)
Allow overriding theme through query params.. to be able to override it
from preview iframe in webcomponent

Github issue / Community forum post (link here to close automatically):
2023-11-02 16:06:33 +01:00
github-actions[bot] fbce8f5298
🚀 Release 1.15.1 (#7592)
##
[1.15.1](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.1)
(2023-11-02)


### Bug Fixes

* **core:** Ensure execution deletion in worker lifecycle hook
([#7481](https://github.com/n8n-io/n8n/issues/7481))
([742c8a8](742c8a8534))
* **core:** Fix data encryption on credentials import
([#7560](https://github.com/n8n-io/n8n/issues/7560))
([b350568](b350568505))
* **core:** Fix issue that prevents owner logging in when using ldap
([#7408](https://github.com/n8n-io/n8n/issues/7408))
([479f902](479f90231d))
* **core:** Handle missing resultData in runData
([#7523](https://github.com/n8n-io/n8n/issues/7523))
([1055bd3](1055bd3762))
* **core:** Permission check for subworkflow properly checking for
workflow settings ([#7576](https://github.com/n8n-io/n8n/issues/7576))
([437c95e](437c95e84e))
* **core:** Prevent executions from becoming forever running
([#7569](https://github.com/n8n-io/n8n/issues/7569))
([9bdb85c](9bdb85c4ce))
* **core:** Upgrade crypto-js to address CVE-2023-46233
([#7519](https://github.com/n8n-io/n8n/issues/7519))
([65e5593](65e5593233))
* **editor:** Do not truncate form inputs
([#7528](https://github.com/n8n-io/n8n/issues/7528))
([ae616f1](ae616f146b))
* **editor:** Fix NDV close after using input select
([#7544](https://github.com/n8n-io/n8n/issues/7544))
([3b5e181](3b5e181e66))
* **editor:** Fix NDV unexpected re-render
([#7532](https://github.com/n8n-io/n8n/issues/7532))
([2853fcf](2853fcff73))
* **editor:** Fix route component caching, incorrect use of array reduce
method and enable WF history feature
([#7434](https://github.com/n8n-io/n8n/issues/7434))
([12a89e6](12a89e6d14))
* **editor:** Fixes the issue that Switch Node can not be created
([#7516](https://github.com/n8n-io/n8n/issues/7516))
([df89685](df89685e15))
* **editor:** Handle `localStorage` being blocked/unavailable
([#7348](https://github.com/n8n-io/n8n/issues/7348))
([c05bc67](c05bc6728d))
* Fix dark mode small issues
([#7573](https://github.com/n8n-io/n8n/issues/7573))
([1d81afc](1d81afcbdf))
* **Jira Software Node:** Handle missing issue types in issue types
loader ([#7534](https://github.com/n8n-io/n8n/issues/7534))
([9762705](9762705833))
* **Switch Node:** Allow sortable Switch rules
([#7555](https://github.com/n8n-io/n8n/issues/7555))
([7a56e58](7a56e58a60))


### Features

* **core:** Add optional Error-Output
([#7460](https://github.com/n8n-io/n8n/issues/7460))
([655efea](655efeaf66))
* **core:** Make queue mode settings configurable
([#7526](https://github.com/n8n-io/n8n/issues/7526))
([3d95b24](3d95b243e9))
* **core:** Set up leader selection for multiple main instances
([#7527](https://github.com/n8n-io/n8n/issues/7527))
([442c73e](442c73e63b))
* **editor:** Implement the `UserStack` design system component
([#7559](https://github.com/n8n-io/n8n/issues/7559))
([ce14f62](ce14f6266b))
* **HTTP Request Node:** Add pagination support
([#5993](https://github.com/n8n-io/n8n/issues/5993))
([cc2bd2e](cc2bd2e19c))
* **HTTP Request Node:** Update icon and default color
([#7572](https://github.com/n8n-io/n8n/issues/7572))
([ff279ab](ff279ab411))
* **n8n Form Trigger Node:** Add text area and password input types
([#7474](https://github.com/n8n-io/n8n/issues/7474))
([b72040a](b72040aa54))
* **editor:** Dark mode is here! You can change it under personal
settings.([#6980](https://github.com/n8n-io/n8n/pull/6980))
([0746783](0746783e02))

---------

Co-authored-by: krynble <krynble@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-02 14:52:11 +01:00
Michael Kret 59dc36abd9
feat(core): Add the node version to telemetry in node_graph_string (#7449)
Github issue / Community forum post (link here to close automatically):
2023-11-02 15:18:41 +02:00
Iván Ovejero 1c77d6597f
refactor(core): Ensure only leader handles licensing in multi-main scenario (#7558)
https://linear.app/n8n/issue/PAY-953/ensure-only-main-instance-leader-handles-licensing
2023-11-02 14:16:22 +01:00
Tomi Turtiainen 7dac9ab82c
feat(core): Log executed migrations with info level (#7586)
To help debugging possible issues in startup and migrations, log the
executed migrations with log level 'info', instead of 'debug'.

Github issue / Community forum post (link here to close automatically):
2023-11-02 14:24:04 +02:00
Iván Ovejero 921d213ae5
refactor(core): Create pruning service (no-changelog) (#7564)
https://linear.app/n8n/issue/PAY-954/ensure-only-main-instance-leader-handles-pruning
2023-11-02 12:24:25 +01:00
github-actions[bot] 73e9a216b7
🚀 Release 1.15.0 (#7580)
#
[1.15.0](https://github.com/n8n-io/n8n/compare/n8n@1.14.0...n8n@1.15.0)
(2023-11-02)


### Bug Fixes

* **core:** Ensure execution deletion in worker lifecycle hook
([#7481](https://github.com/n8n-io/n8n/issues/7481))
([742c8a8](742c8a8534))
* **core:** Fix data encryption on credentials import
([#7560](https://github.com/n8n-io/n8n/issues/7560))
([b350568](b350568505))
* **core:** Fix issue that prevents owner logging in when using ldap
([#7408](https://github.com/n8n-io/n8n/issues/7408))
([479f902](479f90231d))
* **core:** Handle missing resultData in runData
([#7523](https://github.com/n8n-io/n8n/issues/7523))
([1055bd3](1055bd3762))
* **core:** Permission check for subworkflow properly checking for
workflow settings ([#7576](https://github.com/n8n-io/n8n/issues/7576))
([437c95e](437c95e84e))
* **core:** Prevent executions from becoming forever running
([#7569](https://github.com/n8n-io/n8n/issues/7569))
([9bdb85c](9bdb85c4ce))
* **core:** Upgrade crypto-js to address CVE-2023-46233
([#7519](https://github.com/n8n-io/n8n/issues/7519))
([65e5593](65e5593233))
* **editor:** Do not truncate form inputs
([#7528](https://github.com/n8n-io/n8n/issues/7528))
([ae616f1](ae616f146b))
* **editor:** Fix NDV close after using input select
([#7544](https://github.com/n8n-io/n8n/issues/7544))
([3b5e181](3b5e181e66))
* **editor:** Fix NDV unexpected re-render
([#7532](https://github.com/n8n-io/n8n/issues/7532))
([2853fcf](2853fcff73))
* **editor:** Fix route component caching, incorrect use of array reduce
method and enable WF history feature
([#7434](https://github.com/n8n-io/n8n/issues/7434))
([12a89e6](12a89e6d14))
* **editor:** Fixes the issue that Switch Node can not be created
([#7516](https://github.com/n8n-io/n8n/issues/7516))
([df89685](df89685e15))
* **editor:** Handle `localStorage` being blocked/unavailable
([#7348](https://github.com/n8n-io/n8n/issues/7348))
([c05bc67](c05bc6728d))
* **Jira Software Node:** Handle missing issue types in issue types
loader ([#7534](https://github.com/n8n-io/n8n/issues/7534))
([9762705](9762705833))
* **Switch Node:** Allow sortable Switch rules
([#7555](https://github.com/n8n-io/n8n/issues/7555))
([7a56e58](7a56e58a60))


### Features

* **core:** Add optional Error-Output
([#7460](https://github.com/n8n-io/n8n/issues/7460))
([655efea](655efeaf66))
* **core:** Make queue mode settings configurable
([#7526](https://github.com/n8n-io/n8n/issues/7526))
([3d95b24](3d95b243e9))
* **core:** Set up leader selection for multiple main instances
([#7527](https://github.com/n8n-io/n8n/issues/7527))
([442c73e](442c73e63b))
* **editor:** Implement the `UserStack` design system component
([#7559](https://github.com/n8n-io/n8n/issues/7559))
([ce14f62](ce14f6266b))
* **HTTP Request Node:** Add pagination support
([#5993](https://github.com/n8n-io/n8n/issues/5993))
([cc2bd2e](cc2bd2e19c))
* **HTTP Request Node:** Update icon and default color
([#7572](https://github.com/n8n-io/n8n/issues/7572))
([ff279ab](ff279ab411))
* **n8n Form Trigger Node:** Add text area and password input types
([#7474](https://github.com/n8n-io/n8n/issues/7474))
([b72040a](b72040aa54))
* **editor:** Dark mode is here! You can change it under personal
settings.([#6980](https://github.com/n8n-io/n8n/pull/6980))
([0746783](0746783e02))

---------

Co-authored-by: krynble <krynble@users.noreply.github.com>
Co-authored-by: Omar Ajoue <krynble@gmail.com>
2023-11-02 11:47:11 +01:00
Jan Oberhauser be49778388
fix(editor): Fix more dark mode issues (no-changelog) (#7578)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-11-02 10:57:08 +01:00
Alex Grozav 721a36637c
feat(editor): Handle pin data edge cases and unify validation (no-changelog) (#6685)
Github issue / Community forum post (link here to close automatically):
2023-11-02 10:43:02 +02:00
Jon 479f90231d
fix(core): Fix issue that prevents owner logging in when using ldap (#7408)
This PR prioritises the internal email account over LDAP for the Owner.

---------

Co-authored-by: ricardo <ricardoespinoza105@gmail.com>
2023-11-01 23:02:49 -04:00
Omar Ajoue 437c95e84e
fix(core): Permission check for subworkflow properly checking for workflow settings (#7576)
The `sharing` related code is legacy that was not removed. Subworkflow
execution should check workflow settings alone, and this is now
reflected in the code.

Github issue / Community forum post (link here to close automatically):

https://community.n8n.io/t/bug-when-using-the-execute-workflow-node-when-workflow-is-shared/32207

---------

Co-authored-by: Iván Ovejero <ivov.src@gmail.com>
2023-11-01 18:31:34 +01:00
कारतोफ्फेलस्क्रिप्ट™ 100291e109
refactor(editor): Dark theme improvements (no-changelog) (#7574)
Co-authored-by: Mutasem Aldmour <4711238+mutdmour@users.noreply.github.com>
2023-11-01 17:56:15 +01:00
कारतोफ्फेलस्क्रिप्ट™ ff279ab411
feat(HTTP Request Node): Update icon and default color (#7572)
extracted from https://github.com/n8n-io/n8n/pull/7157

Co-authored-by: Elias Meire <elias@meire.dev>
2023-11-01 17:35:47 +01:00
Mutasem Aldmour 1d81afcbdf
fix: Fix dark mode small issues (#7573)
Github issue / Community forum post (link here to close automatically):
2023-11-01 16:27:32 +01:00
Jan Oberhauser cc2bd2e19c
feat(HTTP Request Node): Add pagination support (#5993)
Is still WIP and does not implement the correct UI yet.

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/pagination-included-into-http-node/15080

https://community.n8n.io/t/how-to-paginate-through-data-in-http-requests/28103
2023-11-01 14:24:43 +01:00
कारतोफ्फेलस्क्रिप्ट™ 9bdb85c4ce
fix(core): Prevent executions from becoming forever running (#7569)
Fixes CP-867
Possibly also fixes PAY-323 and PAY-412
2023-11-01 13:51:13 +01:00
Giulio Andreini 0746783e02
refactor(editor): Color palette updates, introduce dark mode (#6980)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: Mutasem <mutdmour@gmail.com>
2023-11-01 13:33:36 +01:00
Yoshino-s b72040aa54
feat(n8n Form Trigger Node): Add text area and password input types (#7474)
Signed-off-by: yoshino-s <cy-cui@outlook.com>
2023-11-01 12:23:28 +00:00
Milorad FIlipović ce14f6266b
feat(editor): Implement the UserStack design system component (#7559)
Adds [`UserStack`
component](https://www.figma.com/file/5MfPO6Eg2YVfXETAzoGahf/Debt-days-August2023?type=design&node-id=10-13056&mode=design&t=tuJAgCdzkN506SlE-0)
to our design system
2023-11-01 09:26:06 +01:00
Csaba Tuncsik b94b8b2eb0
fix(editor): Rename and move isObjectLiteral utility function (no-changelog) (#7565) 2023-10-31 21:28:01 +01:00
Iván Ovejero c6b688387c
refactor(core): Enable useUnknownInCatchVariables in workflow package (no-changelog) (#7549) 2023-10-31 13:59:33 +01:00
Michael Auerswald b350568505
fix(core): Fix data decryption on credentials import (#7560)
Due to a change, during the credentials import command, the core's
Credential object is being called through its prototype. This caused the
Credential's cipher variable to not be set, thus no cipher service being
available during import. This fix catches this edge case and provides a
fix.
2023-10-31 13:15:09 +01:00
OlegIvaniv 774d521dbd
fix(editor): Keep NodeView component alive for TEMPLATE_IMPORT and WORKFLOW_ONBOARDING routes (no-changelog) (#7557)
Github issue / Community forum post (link here to close automatically):
2023-10-31 10:03:57 +01:00
OlegIvaniv 7a56e58a60
fix(Switch Node): Allow sortable Switch rules (#7555)
Github issue / Community forum post (link here to close automatically):

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-31 09:13:31 +01:00
Jan Oberhauser 655efeaf66
feat(core): Add optional Error-Output (#7460)
Add an additional optional error output to which all items get sent that
could not be processed.
![Screenshot from 2023-10-18
17-29-15](https://github.com/n8n-io/n8n/assets/6249596/e9732807-ab2b-4662-a5f6-bdff24f7ad55)

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/error-connector-for-nodes/3094

https://community.n8n.io/t/error-handling-at-node-level-detect-node-execution-status/26791

---------

Co-authored-by: OlegIvaniv <me@olegivaniv.com>
2023-10-30 18:42:47 +01:00
Iván Ovejero 442c73e63b
feat(core): Set up leader selection for multiple main instances (#7527)
https://linear.app/n8n/issue/PAY-933/set-up-leader-selection-for-multiple-main-instances

- [x] Set up new envs
- [x] Add config and license checks
- [x] Implement `MultiMainInstancePublisher`
- [x] Expand `RedisServicePubSubPublisher` to support
`MultiMainInstancePublisher`
- [x] Init `MultiMainInstancePublisher` on startup and destroy on
shutdown
- [x] Add to sandbox plans
- [x] Test manually

Note: This is only for setup - coordinating in reaction to leadership
changes will come in later PRs.
2023-10-30 16:22:32 +01:00
Csaba Tuncsik 3b5e181e66
fix(editor): Fix NDV close after using input select (#7544) 2023-10-30 13:44:19 +01:00
Iván Ovejero 784b43330b
refactor(GitHub Trigger Node): Stop reporting to Sentry permission errors (no-changelog) (#7552)
https://n8nio.sentry.io/issues/4581327606/
2023-10-30 12:12:43 +01:00
Jackson ea5cd3140f
docs: Fix spelling issue in Gmail trigger node (#7545)
IDK how I noticed this
2023-10-30 11:30:53 +01:00
OlegIvaniv 3ab04e4f9e
ci(core): Extract local e2e run script (no-changelog) (#7551)
Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-30 11:18:51 +01:00
Csaba Tuncsik 2853fcff73
fix(editor): Fix NDV unexpected re-render (#7532) 2023-10-30 09:22:08 +01:00
Iván Ovejero 233683ce1a
refactor(core): Remove webhook deregistration on shutdown flag (#7543)
Removal missing from [original
PR](https://github.com/n8n-io/n8n/pull/7515) after initial revert.
2023-10-27 18:48:21 +02:00
Iván Ovejero 18dcea8c19
refactor(Slack Node): Stop reporting to Sentry errors from missing scopes (no-changelog) (#7542)
https://n8nio.sentry.io/issues/4570238312
2023-10-27 16:46:05 +02:00
Iván Ovejero 6796ba75a1
refactor(core): Stop reporting to Sentry stopping execution with wrong status (no-changelog) (#7541)
https://n8nio.sentry.io/issues/4257040218/
2023-10-27 16:14:01 +02:00
कारतोफ्फेलस्क्रिप्ट™ c05bc6728d
fix(editor): Handle localStorage being blocked/unavailable (#7348) 2023-10-27 15:51:20 +02:00
कारतोफ्फेलस्क्रिप्ट™ 35bb42c1b9
refactor(core): Avoid passing around static state like default timezone (no-changelog) (#7221) 2023-10-27 14:17:52 +02:00
Iván Ovejero 62c096710f
refactor: Run lintfix (no-changelog) (#7537)
- Fix autofixable violations
- Remove unused directives
- Allow for PascalCased variables - needed for dynamically imported or
assigned classes, decorators, routers, etc.
2023-10-27 14:15:02 +02:00
Alex Grozav 1c4ac02db5
fix(editor): Fix executions sidebar height (no-changelog) (#6909)
<img width="1397" alt="image"
src="https://github.com/n8n-io/n8n/assets/6179477/cb142085-3b21-4e18-9f0d-92c5c4018578">
2023-10-27 14:32:23 +03:00
Iván Ovejero 07857e78a9
refactor(core): Stop reporting to Sentry non-execution of workflow with issues (#7533)
https://n8nio.sentry.io/issues/4578929841/
2023-10-27 10:09:23 +02:00
Iván Ovejero 9762705833
fix(Jira Software Node): Handle missing issue types in issue types loader (#7534)
https://n8nio.sentry.io/issues/4576849854
2023-10-27 10:09:14 +02:00
Omar Ajoue 87996a1fcf
refactor(core): Stop reporting non-error to sentry (issue 4229454473) (no-changelog) (#7525)
This PR aims to stop reporting issues such as [this
one](https://n8nio.sentry.io/issues/4229454473/events/42b96bfd6a334c15a84499e981cf90eb/?project=4503924908883968).

Github issue / Community forum post (link here to close automatically):
2023-10-27 09:25:07 +02:00
Csaba Tuncsik 12a89e6d14
fix(editor): Fix route component caching, incorrect use of array reduce method and enable WF history feature (#7434)
Co-authored-by: Giulio Andreini <andreini@netseven.it>
2023-10-26 20:47:42 +02:00
Iván Ovejero ae616f146b
fix(editor): Do not truncate form inputs (#7528) 2023-10-26 17:54:51 +02:00
Omar Ajoue 3d95b243e9
feat(core): Make queue mode settings configurable (#7526)
This PR allows users to configure the settings to Bull, possibly
reducing the errors with `maxStalledCount` and other issues, that
usually happen either when a worker crashes or when the event loop is
super busy. Increasing the lease time and the `maxStalledCount` settings
might improve UX.

Github issue / Community forum post (link here to close automatically):
2023-10-26 17:30:16 +02:00
Iván Ovejero ae8c7a635e
refactor(core)!: Remove webhook deregistration at startup and shutdown (#7515)
https://linear.app/n8n/issue/PAY-932/deprecate-flag-to-skip-webhook-deregistration-on-shutdown
2023-10-26 14:37:54 +02:00
Iván Ovejero 5477e3fb45
refactor(core): Move execution save settings into lifecycle function (no-changelog) (#7370)
Move the handling of execution save settings into a tested lifecycle
function as discussed with Omar
2023-10-26 14:35:38 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1055bd3762
fix(core): Handle missing resultData in runData (#7523) 2023-10-26 13:15:19 +02:00
Iván Ovejero d8ec6eac40
refactor(FileMaker Node): Prevent reporting to Sentry attempted loadOptions calls without credentials (no-changelog) (#7520)
Severity is lost when wrapping the error, but there is no need to change
the error type here.

https://n8nio.slack.com/archives/C03MZF137FV/p1698308092989739
2023-10-26 12:02:35 +02:00
Iván Ovejero a277807404
refactor(Airtable Node): Prevent reporting to Sentry failure to find table (no-changelog) (#7521)
https://n8nio.sentry.io/issues/4356342982/?project=4503924908883968&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=14d&stream_index=8
2023-10-26 12:02:23 +02:00
Iván Ovejero d885daa6a1
refactor(Google Sheets Node): Prevent reporting to Sentry failure to find spreadsheet (no-changelog) (#7518)
To silence this very frequently reported error:
https://n8nio.sentry.io/issues/3823103947/?project=4503924908883968&query=&referrer=issue-stream&statsPeriod=90d&stream_index=0
2023-10-26 11:33:11 +02:00
कारतोफ्फेलस्क्रिप्ट™ 65e5593233
fix(core): Upgrade crypto-js to address CVE-2023-46233 (#7519)
[GH Advisory](https://github.com/advisories/GHSA-xwcq-pm8m-c4vf)
2023-10-26 11:21:53 +02:00
Jan Oberhauser df89685e15
fix(editor): Fixes the issue that Switch Node can not be created (#7516)
Fixes the issue that currently no Switch-Node can be created by for
example pressing + on the parent node or via tab when another node is
already selected.

Github issue / Community forum post (link here to close automatically):

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Co-authored-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-26 09:46:26 +02:00
Iván Ovejero 742c8a8534
fix(core): Ensure execution deletion in worker lifecycle hook (#7481)
Reported by customer
[here](https://n8nio.slack.com/archives/C05PUALKZHD/p1697446945481249?thread_ts=1697196557.638169&cid=C05PUALKZHD),
apparently a very old long-standing bug for queue mode. Please review
closely as I am not familiar with queue mode.
2023-10-25 19:13:06 +02:00
कारतोफ्फेलस्क्रिप्ट™ 05586a900d
refactor(core): Make Logger a service (no-changelog) (#7494) 2023-10-25 16:35:22 +02:00
github-actions[bot] db4e61ba24
🚀 Release 1.14.0 (#7514)
# [1.14.0](https://github.com/n8n-io/n8n/compare/n8n@1.13.0...n8n@1.14.0)
(2023-10-25)


### Features

* **Switch Node:** Add support for infinite Switch outputs
([#7499](https://github.com/n8n-io/n8n/issues/7499))
([2febc61](2febc61ec9))

Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-25 15:34:57 +02:00
कारतोफ्फेलस्क्रिप्ट™ 0643487403 ci: Fix oclif manifest generation 2023-10-25 14:51:10 +02:00
कारतोफ्फेलस्क्रिप्ट™ 28aabb845a Merge remote-tracking branch 'origin/release/1.13.0' 2023-10-25 14:50:48 +02:00
OlegIvaniv 2febc61ec9
feat(Switch Node): Add support for infinite Switch outputs (#7499)
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-more-outputs-to-switch-node/3864

---------

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
2023-10-25 14:34:47 +02:00
github-actions[bot] 2987587e34
🚀 Release 1.13.0 (#7512)
# [1.13.0](https://github.com/n8n-io/n8n/compare/n8n@1.12.0...n8n@1.13.0)
(2023-10-25)


### Bug Fixes

* **core:** Do not return `inviteAcceptUrl` in response if email was
sent ([#7465](https://github.com/n8n-io/n8n/issues/7465))
([55c6a1b](55c6a1b0d3))
* **core:** Ensure nodes post-processors run in the correct order
([#7500](https://github.com/n8n-io/n8n/issues/7500))
([6f45298](6f45298d3d))
* **core:** Fix `frontend.settings` external hook execution
([#7496](https://github.com/n8n-io/n8n/issues/7496))
([774fe20](774fe202bf))
* **core:** Handle gzip and deflate compressed request payloads
([#7461](https://github.com/n8n-io/n8n/issues/7461))
([83762e0](83762e051d))
* **core:** Reduce logging overhead for levels that do not output
([#7479](https://github.com/n8n-io/n8n/issues/7479))
([76c0481](76c04815f7))
* **Customer.io Node:** Fix api endpoint when using EU region
([#7485](https://github.com/n8n-io/n8n/issues/7485))
([519680c](519680c2cf))
* **editor:** Allow importing the same workflow multiple times
([#7458](https://github.com/n8n-io/n8n/issues/7458))
([3c0a166](3c0a166f7f))
* **editor:** Fix canvas selection breaking after interacting with node
actions ([#7466](https://github.com/n8n-io/n8n/issues/7466))
([bc47365](bc473655fb))
* **editor:** Fix connections disappearing after reactivating canvas and
renaming a node ([#7483](https://github.com/n8n-io/n8n/issues/7483))
([450e0cc](450e0cc66a))
* **Google Sheets Node:** Append or update runs forever when without
column headers ([#7463](https://github.com/n8n-io/n8n/issues/7463))
([ab6a9bb](ab6a9bbac2))
* **Microsoft SQL Node:** Prevent SQL injection
([#7467](https://github.com/n8n-io/n8n/issues/7467))
([a739245](a739245332))
* **MQTT Trigger Node:** Fix node causing a start up hang when active
([#7498](https://github.com/n8n-io/n8n/issues/7498))
([baecb93](baecb93bef))
* **MySQL Node:** Resolve expressions in v1
([#7464](https://github.com/n8n-io/n8n/issues/7464))
([5c46bb0](5c46bb09c1))
* **Redis Node:** Fix adding sets data types
([#7444](https://github.com/n8n-io/n8n/issues/7444))
([4e66023](4e66023cd4))
* **Spreadsheet File Node:** Fix include empty cells not working with v2
([#7505](https://github.com/n8n-io/n8n/issues/7505))
([05e6f2a](05e6f2a6ac))


### Features

* **core:** Add support for oauth based service accounts with UM SMTP
([#7311](https://github.com/n8n-io/n8n/issues/7311))
([647372b](647372be27))
* **editor:** Add PH tracking to event
([#7511](https://github.com/n8n-io/n8n/issues/7511))
([c47d27d](c47d27dd6d))
* **Facebook Lead Ads Trigger Node:** Add Facebook Lead Ads Trigger Node
([#7113](https://github.com/n8n-io/n8n/issues/7113))
([ac814a9](ac814a9c61))
* **Ghost Node:** Add support for lexical format
([#7488](https://github.com/n8n-io/n8n/issues/7488))
([7b1973c](7b1973c058))
* **RSS Feed Trigger Node:** Add RSS feed trigger node
([#7386](https://github.com/n8n-io/n8n/issues/7386))
([689360e](689360ee06))

Co-authored-by: netroy <netroy@users.noreply.github.com>
2023-10-25 14:29:28 +02:00
कारतोफ्फेलस्क्रिप्ट™ 6f45298d3d
fix(core): Ensure nodes post-processors run in the correct order (#7500)
Fixes #7497
2023-10-25 13:59:38 +02:00
Mutasem Aldmour c47d27dd6d
feat(editor): Add PH tracking to event (#7511)
Github issue / Community forum post (link here to close automatically):
2023-10-25 12:18:19 +02:00
Val 93cfabbeac
fix(core): Fix workflow activation with history and workflow history for EE (no-changelog) (#7508)
Github issue / Community forum post (link here to close automatically):
2023-10-25 11:07:11 +01:00
Iván Ovejero 671c95760b
refactor(core): Make executions pruning more resilient (#7480)
This PR converts the hard-deletion interval to a timeout:
- to prevent the interval from not being restored when hard deletion
throws, and
- to prevent a long-running hard deletion from leading to duplicate
deletions.
2023-10-24 16:16:45 +02:00
Jon 05e6f2a6ac
fix(Spreadsheet File Node): Fix include empty cells not working with v2 (#7505)
Github issue / Community forum post (link here to close automatically):
Ticket#763644
2023-10-24 14:22:45 +01:00
कारतोफ्फेलस्क्रिप्ट™ 8ff9f97493
fix(core): Create instance settings directory recursively (no-changelog) (#7506) 2023-10-24 15:10:22 +02:00
Michael Kret a739245332
fix(Microsoft SQL Node): Prevent SQL injection (#7467)
Github issue / Community forum post (link here to close automatically):

---------

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2023-10-24 12:36:44 +03:00
Iván Ovejero 78243edd18
refactor(core): Make pruning via lifecycle configuration in S3 mode mandatory (#7482)
Since we do not store which executions produced binary data, for pruning
on S3 we need to query for binary data items for each execution in order
to delete them. To minimize requests to S3, allow the user to skip
pruning requests when setting TTL at bucket level.
2023-10-24 10:37:02 +02:00
कारतोफ्फेलस्क्रिप्ट™ a9fdd018f4
fix(core): Always derive instanceId from the encryption key (no-changlog) (#7501)
This was the expected behavior, until I changed it in
https://github.com/n8n-io/n8n/pull/7471
2023-10-24 09:55:57 +02:00
Val baecb93bef
fix(MQTT Trigger Node): Fix node causing a start up hang when active (#7498)
Github issue / Community forum post (link here to close automatically):
2023-10-24 09:37:49 +02:00
Cornelius Suermann 3ef771ea38
feat: Collect usage metrics on license renewal (no-changelog) (#7486) 2023-10-23 21:39:29 +02:00