Commit graph

1184 commits

Author SHA1 Message Date
Mutasem Aldmour 402b75ac28
fix: Fix user redirect to signin bug (#4623) 2022-11-16 14:21:49 +01:00
कारतोफ्फेलस्क्रिप्ट™ 13659d036f
ci: Ensure that eslint runs on all frontend code (no-changelog) (#4602)
* ensure that eslint runs on all frontend code

* remove tslint from `design-system`

* enable prettier and eslint-prettier for `design-system`

* Delete tslint.json

* use a single editorconfig for the repo

* enable prettier for all code in `design-system`

* more linting fixes on design-system

* ignore coverage for git and prettier

* lintfix on editor-ui
2022-11-15 18:20:54 +01:00
Milorad FIlipović 6eee155ecb
fix(editor): Update to 'Expression/Fixed' toggle - Keep expression when switching to Fixed (#4599)
 Keep the expression string when switching to `Fixed` parameter value
2022-11-15 13:55:53 +01:00
Alex Grozav 898c25fd7e
feat: Add workflow sharing functionality and permissions (#4370)
* feat(editor): extract credentials view into reusable layout components for workflows view

* feat(editor): add workflow card and start work on empty state

* feat: add hoverable card and finish workflows empty state

* fix: undo workflows response interface changes

* chore: fix linting issues.

* fix: remove enterprise sharing env schema

* fix(editor): fix workflows resource view when sharing is enabled

* fix: change owner tag design and order

* feat: add personalization survey on workflows page

* fix: update component snapshots

* feat: refactored workflow card to use workflow-activator properly

* fix: fix workflow activator and proptypes

* fix: hide owner tag for workflow card until sharing is available

* fix: fixed ownedBy and sharedWith appearing for workflows list

* feat: update tags component design

* refactor: change resource filter select to n8n-user-select

* fix: made telemetry messages reusable

* chore: remove unused import

* refactor: fix component name casing

* refactor: use Vue.set to make workflow property reactive

* feat: add support for clicking on tags for filtering

* chore: fix tags linting issues

* fix: fix resources list layout when title words are very long

* refactor: add active and inactive status text to workflow activator

* fix: fix credentials and workflows sorting when name contains leading whitespace

* fix: remove wrongfully added style tag

* feat: add translations and storybook examples for truncated tags

* fix: remove enterprise sharing env from schema

* refactor: fix workflows module and workflows field store naming conflict

* feat: add workflow share button and open dummy modal

* feat: add workflow sharing modal (in progress)

* feat: add message when sharing disabled

* feat: add sharing messages based on flags

* feat: add workflow sharing api integration and readonly state handling

* fix: change how foreign credentials are handled

* refactor: migrate newly added workflow sharing store methods to pinia

* fix: update foreign credentials handler and add executable prop to node-settings

* fix: fix credentials display issue caused by addCredentials override

* fix: fix various issues when sharing from empty state

* fix: update node duplication credentials

* fix: revert defautl values for sharing env

* feat: hide share button behind feature flag

* chore: add env variable for sharing feature (testing only)

* fix: change enterprise-edition component casing
2022-11-15 14:25:04 +02:00
Alex Grozav d1ffc58aa4
fix: Change feature flag for starting at empty WF state for PH experiments (no-changelog) (#4606) 2022-11-15 13:28:15 +02:00
कारतोफ्फेलस्क्रिप्ट™ 0148631d28
build: Upgrade some of the backend dev-tooling (no-changelog) (#4589)
* upgrade ts-node

* move tslint and typescript to a single place

* source-map-support should be loaded in the `n8n` bin script, and not in core

* upgrade jest

* Support only node.js 14, 16, or 18
2022-11-14 15:37:32 +01:00
Milorad FIlipović edebad1a89
fix(editor): Hide pin data in production executions (#4595)
*  Passing an execution mode to the preview iframe so UI can be adjusted based on it
*  Handling production execution mode to hide the pin data in node details view
2022-11-14 13:28:26 +01:00
Iván Ovejero 69b332b0e3
fix(editor): Fix expression editor variable selector filter (#4590)
* 🐛 Fix expression editor variable selector filter

*  Use optional chaining
2022-11-14 11:23:05 +01:00
Iván Ovejero 271cd06a6a
fix(editor): Curb direct item access linting (#4591)
🐛 Curb direct item access linting
2022-11-14 11:22:55 +01:00
Iván Ovejero ccacd42b37
fix(editor): Skip optional chaining operators in Code Node editor linting (#4592)
* 🐛 Skip optional chaining operators

*  Wrap in try-catch
2022-11-14 11:22:35 +01:00
Milorad FIlipović e0ec5a6aa9
fix(editor): Fix for execution retry dropdown not closing (#4575)
* 🐛 Fixing execution retry popup closing behavior
* 👌 Updating child component ref type casting
* 👌 Handling `undefined` possibility in action dropdown blur event
2022-11-14 09:35:16 +01:00
OlegIvaniv 50f7538779
refactor(editor): Add Workflows view e2e tests (#4573) 2022-11-11 09:07:14 +01:00
Jan Oberhauser efde8ce45a 🔖 Release n8n-editor-ui@0.168.1 2022-11-10 20:55:01 +00:00
Jan Oberhauser 03032ea4ef ⬆️ Set n8n-workflow@0.124.1 on n8n-editor-ui 2022-11-10 20:55:00 +00:00
Jan Oberhauser be5b89ef3e 🔖 Release n8n-editor-ui@0.168.0 2022-11-10 15:45:53 +00:00
Jan Oberhauser bd22135b06 ⬆️ Set n8n-design-system@0.42.0 and n8n-workflow@0.124.0 on n8n-editor-ui 2022-11-10 15:45:51 +00:00
Iván Ovejero 9582a0f1c0
refactor(editor): Reintroduce item and items to CodeNodeEditor (#4553)
*  Alias legacy refs to new syntax

* 📘 Adjust types

* 👕 Switch `item` lint error to warning

*  Add completions for legacy vars

* ✏️ Add descriptions to completions

*  Add lintings

* 📘 Skip `any` for now

*  Expand regex
2022-11-10 16:29:41 +01:00
Milorad FIlipović d06197d879
fix(editor): Fix for oauth authorization (#4572)
🐛 Fixing credentials response type check that prevented oauth authorization
2022-11-10 12:51:50 +01:00
OlegIvaniv 49748f27a2
fix(editor): Prevent adding of the start node when importing workflow in the demo mode (#4564) 2022-11-09 18:36:06 +01:00
कारतोफ्फेलस्क्रिप्ट™ 736777385c
feat: Switch from npm to pnpm (#4429) 2022-11-09 17:32:05 +01:00
Milorad FIlipović db163b71b9
fix(editor): Use base path in workflow preview component URL (#4560)
🐛 Fix for workflow preview component URL
2022-11-09 16:46:13 +01:00
Mutasem Aldmour 536c834313
fix(editor): Fix duplicate bug when new workflow is open (#4559)
fix(editor): fix duplicate bug when new worklfow
2022-11-09 16:09:58 +01:00
Csaba Tuncsik b3cd62d866
fix(editor): Tweak dragged mapping state (#4550)
* fix(editor): show input value when dragging

* fix(editor): show input value when dragging

* fix(editor): add back some input value hiding logic
2022-11-09 16:05:42 +01:00
Milorad FIlipović de96def372
feat(editor): Add support for notice credentials properties (#4557)
 Added notice parameter support for credentials.
2022-11-09 14:50:01 +01:00
Milorad FIlipović bae3098e4e
refactor(editor): Finish pinia migration, remove all vuex dependancies (#4533)
*  Added pinia support. Migrated community nodes module.
*  Added ui pinia store, moved some data from root store to it, updated modals to work with pinia stores
*  Added ui pinia store and migrated a part of the root store
*  Migrated `settings` store to pinia
*  Removing vuex store refs from router
*  Migrated `users` module to pinia store
*  Fixing errors after sync with master
*  One more error after merge
*  Created `workflows` pinia store. Moved large part of root store to it. Started updating references.
*  Finished migrating workflows store to pinia
*  Renaming some getters and actions to make more sense
*  Finished migrating the root store to pinia
*  Migrated ndv store to pinia
*  Renaming main panel dimensions getter so it doesn't clash with data prop name
* ✔️ Fixing lint errors
*  Migrated `templates` store to pinia
*  Migrated the `nodeTypes`store
*  Removed unused pieces of code and oold vuex modules
*  Adding vuex calls to pinia store, fixing wrong references
* 💄 Removing leftover $store refs
*  Added legacy getters and mutations to store to support webhooks
*  Added missing front-end hooks, updated vuex state subscriptions to pinia
* ✔️ Fixing linting errors
*  Removing vue composition api plugin
*  Fixing main sidebar state when loading node view
* 🐛 Fixing an error when activating workflows
* 🐛 Fixing isses with workflow settings and executions auto-refresh
* 🐛 Removing duplicate listeners which cause import error
* 🐛 Fixing route authentication
*  Updating freshly pulled $store refs
*  Adding deleted const
*  Updating store references in ee features. Reseting NodeView credentials update flag when resetting workspace
*  Adding return type to email submission modal
*  Making NodeView only react to paste event when active
* 🐛 Fixing signup view errors
*  Started migrating the `credentials` module to pinia
* 👌 Addressing PR review comments
*  Migrated permissions module to pinia
*  Migrated `nodeCreator`, `tags` and `versions` modules to pinia
*  Implemented webhooks pinia store
*  Removing all leftover vuex files and references
*  Removing final vuex refs
*  Updating expected credentialId type
*  Removing node credentials subscription code, reducing node click debounce timeout
* 🐛 Fixing pushing nodes downstream when inserting new node
* ✔️ Fixing a lint error in new type guard
*  Updating helper reference
* ✔️ Removing unnecessary awaits
*  fix(editor): remove unnecessary imports from NDV
*  Merging mapStores blocks in NodeView
*  fix(editor): make sure JS Plumb not loaded earlier than needed
*  Updating type guard nad credentials subscriptions
*  Updating type guard so it doesn't use `any` type

Co-authored-by: Csaba Tuncsik <csaba@n8n.io>
2022-11-09 10:01:50 +01:00
OlegIvaniv 825637f02a
fix(editor): Fix workflow back button navigation (#4546)
* 🐛 Fix back button navigation from recetly saved workflow

* 🐛 Fix coming-soon routes
2022-11-09 09:31:23 +01:00
Milorad FIlipović d2bec63cec
fix(editor): Fix workflow activation from the Workflows view (#4549)
🐛 Fixing a bug when activating workflow from workflows view
2022-11-08 18:05:50 +01:00
Milorad FIlipović 01171912e7
fix(editor): Fix for incorrect execution saving indicator in executions view (#4547)
🐛 Fix workflow settings icon in executions view
2022-11-08 17:16:36 +01:00
Alex Grozav 77644860c0
feat: Add cypress e2e tests for signup and signin (#3490)
* feat: Added cypress setup files.

* feat: Added server bootup and initial test run.

* feat: Added e2e tests for signin, signup, and personalization form.

* feat: Added e2e tests for adding a function node.

* feat: Added set node and workflow execution steps.

* feat: Added test id to main sidebar.

* feat: Added test for creating a new workflow.

* feat: Finished test for creating a blank workflow

* chore: Removed screenshots from e2e tests.

* refactor: change e2e tests to per page structure

* feat: add cypress type enchancements

* feat: add typescript for cypress tests

* fix: remove component after merge

* feat: update cypress definitions

* feat: add cypress cleanup task

* refactor: update cypress script names

* ci: add smoke tests to workflow

* chore: remove cypress example files

* feat: update signup flow to be reusable

* fix: fix signup route for cypress page object

* fix: remove cypress reset command

* fix: remove unused imports

* fix: Add unhandled error catcher
2022-11-08 14:21:10 +02:00
कारतोफ्फेलस्क्रिप्ट™ 1c98f97e9e
ci: Revert support for node.js 18 (#4518) (#4537)
Revert "ci: Start supporting node.js 18 (#4518)"

This reverts commit 9ee292cd17.
2022-11-07 17:23:08 +01:00
कारतोफ्फेलस्क्रिप्ट™ 9ee292cd17
ci: Start supporting node.js 18 (#4518)
* ci: start supporting node.js 18

Node.js 18 becomes the active LTS on 2022-10-25, as Node.js 16 goes into maintenance mode.
https://github.com/nodejs/Release#release-schedule

* continue using node 16 for production images

* node 16 for debian and base images as well for now
2022-11-07 15:51:57 +01:00
Csaba Tuncsik 88baaa0eb1
fix(editor): Update workflow buttons spacings (#4534) 2022-11-07 12:56:19 +01:00
Csaba Tuncsik f6b85f4a69
fix(editor): Showing string numbers and null properly in JSON view (#4513)
* fix(editor): update `vue-json-pretty` package

* fix(editor): JSON view show string numbers and null properly

* fix(editor): testing if RunDataJson.vue display the values according to its type

* chore(editor): resolve package-lock.json conflict

* fix(editor): using @pinia/testing library to mock pinia store

* chore: fix package-lock.json after merge conflicts
2022-11-07 12:27:02 +01:00
Iván Ovejero 5e0ded4a84
fix(editor): Switch CodeNodeEditor linter parser to esprima-next (#4524)
* ⬆️ Switch to `esprima-next`

* 📦 Update `package-lock.json`

*  Use `esprima-next`

* 📘 Ignore type issue

* 📦 Update `package-lock.json`
2022-11-07 10:34:44 +01:00
Csaba Tuncsik 350b356271
refactor(editor): Encapsulate canvas actions (#4416)
* feat(editor): encapsulating canvas actions

* fiz(editor): zoomToFit

* fiz(editor): zoomToFit

* fiz(editor): fix imoprts in canvas controls

* fiz(editor): fix imports in node view

* fiz(editor): remove unused props from canvas controls

* fiz(editor): fix zoomToFit functionality

* fiz(editor): move more functions from NodeView to canvas store

* chore(editor): code formatting fixes

* fix(editor): adding back some lost refactoring after merge

* fix(editor): remove console.log

* fix(editor): add missing canvasAddButtonPosition

* fix(editor): modify root store env query

* fix(editor): modify canvas control position styling

* fix(editor): modify canvas control position styling

* fix(editor): roll back process.env

* fix(editor): fix canvas controls positioning

* fix(editor): fix canvas controls positioning

* fix(editor): adopting new styles after merge

* fix(editor): not storing html element in the store

* fix(editor): remove unused variables

* fix(editor): update canvas controls after conflict resolution

* fix(editor): revert main.ts to reduce change noise

* fix(editor): remove old store commit

* fix(editor): simplify canvas store

* fix(editor): reposition execute workflow button in mobile view

* fix(editor): fox mouse scroll zoom in canvas

* fix(editor): move canvas scroll handling into canvas controls
2022-11-07 09:53:27 +01:00
Iván Ovejero 0edd4bcc87
fix(editor): Curb arg linting for $input.first() and $input.last() (#4526)
🐛 Curb arg linting
2022-11-04 17:24:29 +01:00
Milorad FIlipović 40e413d958
refactor(editor): Migrate part of the vuex store to pinia (#4484)
*  Added pinia support. Migrated community nodes module.
*  Added ui pinia store, moved some data from root store to it, updated modals to work with pinia stores
*  Added ui pinia store and migrated a part of the root store
*  Migrated `settings` store to pinia
*  Removing vuex store refs from router
*  Migrated `users` module to pinia store
*  Fixing errors after sync with master
*  One more error after merge
*  Created `workflows` pinia store. Moved large part of root store to it. Started updating references.
*  Finished migrating workflows store to pinia
*  Renaming some getters and actions to make more sense
*  Finished migrating the root store to pinia
*  Migrated ndv store to pinia
*  Renaming main panel dimensions getter so it doesn't clash with data prop name
* ✔️ Fixing lint errors
*  Migrated `templates` store to pinia
*  Migrated the `nodeTypes`store
*  Removed unused pieces of code and oold vuex modules
*  Adding vuex calls to pinia store, fi	xing wrong references
* 💄 Removing leftover $store refs
*  Added legacy getters and mutations to store to support webhooks
*  Added missing front-end hooks, updated vuex state subscriptions to pinia
* ✔️ Fixing linting errors
*  Removing vue composition api plugin
*  Fixing main sidebar state when loading node view
* 🐛 Fixing an error when activating workflows
* 🐛 Fixing isses with workflow settings and executions auto-refresh
* 🐛 Removing duplicate listeners which cause import error
* 🐛 Fixing route authentication
*  Updating freshly pulled $store refs
* Adding deleted const
*  Updating store references in ee features. Reseting NodeView credentials update flag when resetting workspace
*  Adding return type to email submission modal
*  Making NodeView only react to paste event when active
* 🐛 Fixing signup view errors
* 👌 Addressing PR review comments
* 👌 Addressing new PR comments
* 👌 Updating invite id logic in signup view
2022-11-04 14:04:31 +01:00
Mutasem Aldmour c2c7927414
fix(editor): fix themes the monaco editor (no-changelog) (#4521)
fix(editor): fix dark mode for the monaco editor (no-changelog)

just the default light and dark themes that are shipped with the editor

Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
2022-11-04 13:16:44 +01:00
Csaba Tuncsik 78c024b247
refactor(editor): restrict mapping discoverability tooltip showing only on string input (#4496)
* refactor(editor): restrict mapping discoverability tooltip showing only on string input

* refactor(editor): renaming computed prop because not only string inputs can be mapped, but we want to show tooltips only on string inputs

* fix(editor): removing unused prop from ParameterInputWrapper.vue

* fix(editor): reorganizing and updating props in ParameterInputFull.vue

* fix(editor): proper typings for node related translations

* fix(editor): fix typings for input localisation functions

* fix(editor): simplifying localisation functions

* Revert "fix(editor): simplifying localisation functions"

This reverts commit 3d93ccf0cf.

* fix(editor): move nullish coalescing into called function
2022-11-03 13:04:53 +01:00
Jan Oberhauser b47e1ffa28 🔖 Release n8n-editor-ui@0.167.0 2022-11-02 17:26:50 +00:00
Jan Oberhauser 21576eb164 ⬆️ Set n8n-design-system@0.41.0 and n8n-workflow@0.123.0 on n8n-editor-ui 2022-11-02 17:26:50 +00:00
Milorad FIlipović 721ef26d5f
fix(editor): workflow settings link font size change (no-changelog) (#4511)
💄 Updating `Workflow settings` link font size in executions view
2022-11-02 15:37:34 +01:00
Csaba Tuncsik b0df810745
perf(editor): improve array intersection utility function (#4503) 2022-11-02 15:03:55 +01:00
Mutasem Aldmour 3c9ad02ce3
refactor(editor): put editor theme behind local storage flag (#4498)
set theme
2022-11-02 11:37:09 +01:00
Csaba Tuncsik 41e6489b75
fix(editor): limiting columns in table view to prevent unresponsive UI when opening NDV (#4480)
* fix(editor): limiting columns in table view

* fix(editor): adding ghost table column with tooltip to table view

* fix(editor): limit columns to 40

* fix(editor): show table columns if it doesn't exceed the limit

* fix(editor): rolling back globalLinkActions changes

* fix(editor): using i18n tag for having cleaner event handling

* fix(editor): emphasizing magic variable

* fix(editor): removing unused prop
2022-11-02 09:23:09 +01:00
Milorad FIlipović dcec5e9e82
fix(editor): disable settings link in executions view for unsaved workflows (#4493)
 Disabling settings link in executions view for unsaved workflows
2022-11-01 22:23:05 +01:00
Iván Ovejero cf034c015f
fix(editor): fix interim updates on executions view (#4497)
🐛 Set hash on executions view
2022-11-01 17:40:45 +01:00
OlegIvaniv f24497589f
fix(editor): fix node creator search when there's active subcategory (#4494)
* fix(editor): fix node creator search when there's active subcategory

* 🎨 Add intersection util and replace lodash one with it

* 🎨 Remove unused imports
2022-11-01 17:11:31 +01:00
Csaba Tuncsik 6c2c621f1d
feat(editor): block UI in NDV when workflow is listening to events (#4390)
* feature: block UI in NDV when workflow is listening to events

* feature: hide stop listening button in parameters pane and show stop listening button in input pane for webhook

* feature: create block UI design system component

* fix: add back accidentally removed prop

* fix(editor): extend node settings event listener button functionality

* refactor(editor): using composition API in BlockUi component
2022-10-31 18:59:53 +01:00
Iván Ovejero ec5ef0c50d
refactor(core): clear @ts-ignore from workflow and core packages (#4467)
* 📘 Clear all `@ts-ignore` comments from workflow package

* 👕 Default to error with package-level overrides

* refactor(core): clear all `@ts-ignore` comments from core package (#4473)

👕 Clear all `@ts-ignore` comments from core package

* ✏️ Update comment
2022-10-31 12:45:34 +01:00