कारतोफ्फेलस्क्रिप्ट™
1d2666b37c
refactor(Peekalink Node): Stricter typing for Peekalink api call + Tests (no-changelog) ( #8125 )
...
This PR is an example for how we can
1. improve typing and remove boilerplate code in may of our nodes
2. use nock to write effective unit tests for nodes that make external
calls
## Review / Merge checklist
- [x] PR title and summary are descriptive
- [x] Add tests
2023-12-21 18:22:32 +01:00
Iván Ovejero
78c83168ac
refactor: Enable cred-class-field-documentation-url-missing (no-changelog) ( #6907 )
2023-08-10 16:35:06 +02:00
Iván Ovejero
6f48593134
refactor: Enable cred-class-field-properties-assertion (no-changelog) ( #6908 )
2023-08-10 15:28:03 +02:00
Iván Ovejero
dec19585bc
refactor: Enforce expanded sensitive inputs rules (no-changelog) ( #6815 )
...
* refactor: Enforce expanded sensitive inputs rules (no-changelog)
* refactor: Add extra exemption
* fix: Add setting to `sessionToken` fields
* fix: Restore for `hidden` fields
* fix: More edge case exemptions
* fix: One more
2023-08-01 13:08:25 +02:00
कारतोफ्फेलस्क्रिप्ट™
6fb8a9ee39
ci: Fix linting issues (no-changelog) ( #6788 )
...
* ci: Fix linting (no-changelog)
* lintfix for nodes-base as well
2023-07-28 18:28:17 +02:00
Iván Ovejero
3566c13afc
feat: Allow eslint-config to be externally consumable ( #6694 )
...
* feat: Allow `eslint-config` to be externally consumable
* refactor: Adjust import styles
2023-07-19 09:35:10 +02:00
Iván Ovejero
57aab63c10
refactor: Integrate consistent-type-imports in FE packages (no-changelog) ( #6060 )
...
* 👕 Move `consistent-type-imports` to top level
* 👕 Apply lintfixes
* 👕 Apply more lintfixes
* 👕 More lintfixes
* 👕 More lintfixes
2023-04-24 12:18:24 +02:00
Michael Kret
0e93fe064e
refactor(core): Forbid raw enums (no-changelog)
2023-04-21 14:23:15 +03:00
कारतोफ्फेलस्क्रिप्ट™
161de110ce
fix(core): Improve community nodes loading ( #5608 )
2023-03-24 17:04:26 +01:00
Michael Kret
bb4db58819
fix(core): Remove linting exceptions in nodes-base, @typescript-eslint/no-unsafe-argument (no-changelog)
2023-02-28 05:39:43 +02:00
Iván Ovejero
b03e358a12
refactor: Integrate consistent-type-imports in nodes-base (no-changelog) ( #5267 )
...
* 👕 Enable `consistent-type-imports` for nodes-base
* 👕 Apply to nodes-base
* ⏪ Undo unrelated changes
* 🚚 Move to `.eslintrc.js` in nodes-base
* ⏪ Revert "Enable `consistent-type-imports` for nodes-base"
This reverts commit 529ad72b05👕 Fix severity
2023-01-27 12:22:44 +01:00
Michael Kret
e667df783c
fix(core): Revert rule @typescript-eslint/prefer-nullish-coalescing
2023-01-19 14:37:19 +02:00
Michael Kret
6608e69457
refactor(core): Remove linting exceptions in nodes-base (no-changelog) ( #4944 )
2023-01-13 18:11:56 +01:00
Iván Ovejero
7e3f3c5097
refactor: Add lint rule node-class-description-name-miscased (no-changelog) ( #5065 )
...
* 📦 Update `eslint-plugin-n8n-nodes-base` version
* 📦 Update `pnpm-lock`
* 👕 Enable rule
* 👕 Exempt pre-existing nodes with miscased names
2023-01-02 09:22:33 +01:00
कारतोफ्फेलस्क्रिप्ट™
17f13b3b6e
ci: Setup eslint-import-resolver-typescript for improved TS linting ( #4996 )
...
* Setup stricter linting for typescript
* make `import/no-unresolved` an error everywhere
* use prettier to format `.vscode/settings.default.json`
* address PR comments
2022-12-22 09:55:39 +01:00
Michael Kret
61e26804ba
refactor(core): Remove linting exceptions in nodes-base ( #4794 )
...
* ⚡ enabled array-type
* ⚡ await-thenable on
* ⚡ ban-types on
* ⚡ default-param-last on
* ⚡ dot-notation on
* ⚡ member-delimiter-style on
* ⚡ no-duplicate-imports on
* ⚡ no-empty-interface on
* ⚡ no-floating-promises on
* ⚡ no-for-in-array on
* ⚡ no-invalid-void-type on
* ⚡ no-loop-func on
* ⚡ no-shadow on
* ⚡ ban-ts-comment re enabled
* ⚡ @typescript-eslint/lines-between-class-members on
* address my own comment
* @typescript-eslint/return-await on
* @typescript-eslint/promise-function-async on
* @typescript-eslint/no-unnecessary-boolean-literal-compare on
* @typescript-eslint/no-unnecessary-type-assertion on
* prefer-const on
* @typescript-eslint/prefer-optional-chain on
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <[email protected] >
2022-12-02 21:54:28 +01:00
Iván Ovejero
cc7f8fd5de
refactor: Apply lint rule cred-class-field-display-name-miscased ( #4762 )
...
* 👕 Apply lint rule `cred-class-field-display-name-miscased`
* ⚡ Update `pnpm-lock.yaml`
* 🙈 Update `.prettierignore`
2022-11-30 15:31:44 +01:00
Iván Ovejero
60d66426ff
refactor: Validate formatting in nodes-base (no-changelog) ( #4685 )
...
* 🔥 Remove Prettier exceptions
* 👕 Start linting on formatting
* ⚡ Update `format` command
* 🎨 Apply formatting
2022-11-22 12:44:35 +01:00
Michael Kret
479644a499
refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ ( #4523 )
...
* ⚡ rule and fixes
* ⚡ clean up
2022-11-08 15:28:21 +01:00
Iván Ovejero
1c229a7b52
refactor(core): apply lint rule cred-class-field-unobscured-sensitive-input ( #4495 )
...
* ⬆️ Upgrade linter
* 📦 Update `package-lock.json`
* 👕 Enable rule
* 👕 Apply rule
* 📦 Re-update `package-lock.json`
2022-11-01 17:41:45 +01:00
Iván Ovejero
ec5ef0c50d
refactor(core): clear @ts-ignore from workflow and core packages ( #4467 )
...
* 📘 Clear all `@ts-ignore` comments from workflow package
* 👕 Default to error with package-level overrides
* refactor(core): clear all `@ts-ignore` comments from core package (#4473 )
👕 Clear all `@ts-ignore` comments from core package
* ✏️ Update comment
2022-10-31 12:45:34 +01:00
Iván Ovejero
d2b97c0713
refactor(core): apply lint rule node-class-description-non-core-color-present ( #4426 )
...
* 👕 Enable rule `node-class-description-non-core-color-present`
* 👕 Apply rule to remove deprecated `color`
* ✏️ Fix unrelated typos
* ✏️ Fix another unrelated typo
Co-authored-by: Michael Kret <[email protected] >
2022-10-25 09:06:54 +02:00
Iván Ovejero
27d04062f5
refactor(core): integrate lint rule node-param-name-untrimmed ( #4331 )
...
* ⬆️ Upgrade `eslint-plugin-n8n-nodes-base`
* 📦 Update `package-lock.json`
* 👕 Add `node-param-name-untrimmed`
Co-authored-by: Michael Kret <[email protected] >
2022-10-13 09:19:17 +02:00
Iván Ovejero
3a9c7acb04
refactor(nodes-base): Apply lint rule node-param-operation-option-description-wrong-for-get-many ( #4064 )
...
* 👕 Enable rule
* ⬆️ Upgrade linter
* 📦 Update `package-lock.json`
* 👕 Apply rule
* ✏️ Fix plurals
* ✏️ More typos
* ✏️ Final typos
2022-09-13 12:36:36 +02:00
कारतोफ्फेलस्क्रिप्ट™
69eb97999d
fix(eslint): setup eslint to run on every package - N8N-4553 ( #4050 )
...
* fix(eslint): setup eslint to run on every package
Also, unify eslint config and dependencies into a private package in the workspace.
2022-09-12 11:41:50 +02:00
